[INFO] cloning repository https://github.com/Filo6699/rpg [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Filo6699/rpg" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFilo6699%2Frpg", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFilo6699%2Frpg'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e7abc95a4eb0c3a820f802a0605cebe640e90987 [INFO] checking Filo6699/rpg/e7abc95a4eb0c3a820f802a0605cebe640e90987 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFilo6699%2Frpg" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Filo6699/rpg on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Filo6699/rpg [INFO] finished tweaking git repo https://github.com/Filo6699/rpg [INFO] tweaked toml for git repo https://github.com/Filo6699/rpg written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Filo6699/rpg already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 929992c793de94b38cc907f8f50d57307795e96d0911faaa4c2b7e12049366da [INFO] running `Command { std: "docker" "start" "-a" "929992c793de94b38cc907f8f50d57307795e96d0911faaa4c2b7e12049366da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "929992c793de94b38cc907f8f50d57307795e96d0911faaa4c2b7e12049366da", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "929992c793de94b38cc907f8f50d57307795e96d0911faaa4c2b7e12049366da", kill_on_drop: false }` [INFO] [stdout] 929992c793de94b38cc907f8f50d57307795e96d0911faaa4c2b7e12049366da [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 19c47afcdc1b175a9992a98bf557d66e9e2e8a229acb655052308e09b90a446a [INFO] running `Command { std: "docker" "start" "-a" "19c47afcdc1b175a9992a98bf557d66e9e2e8a229acb655052308e09b90a446a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.148 [INFO] [stderr] Compiling proc-macro2 v1.0.67 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking smallvec v1.11.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking deranged v0.3.8 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling serde_json v1.0.107 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling indoc v2.0.4 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking time v0.3.28 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling syn v2.0.37 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling strum_macros v0.25.2 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking ratatui v0.23.0 [INFO] [stderr] Checking rpg v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:51:60 [INFO] [stdout] | [INFO] [stdout] 51 | let _ = terminal.draw(|f| scene_manager.render(f, &shared_data.lock().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:51:60 [INFO] [stdout] | [INFO] [stdout] 51 | let _ = terminal.draw(|f| scene_manager.render(f, &shared_data.lock().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/game/scenes/shop.rs:204:41 [INFO] [stdout] | [INFO] [stdout] 204 | .title(Title::from(title.clone()).alignment(Alignment::Right)); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/game/utils.rs:94:33 [INFO] [stdout] | [INFO] [stdout] 94 | .title(Title::from(title.clone()).alignment(Alignment::Right)); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/game/scenes/shop.rs:204:41 [INFO] [stdout] | [INFO] [stdout] 204 | .title(Title::from(title.clone()).alignment(Alignment::Right)); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/game/utils.rs:94:33 [INFO] [stdout] | [INFO] [stdout] 94 | .title(Title::from(title.clone()).alignment(Alignment::Right)); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rpg` (bin "rpg" test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rpg` (bin "rpg") due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "19c47afcdc1b175a9992a98bf557d66e9e2e8a229acb655052308e09b90a446a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "19c47afcdc1b175a9992a98bf557d66e9e2e8a229acb655052308e09b90a446a", kill_on_drop: false }` [INFO] [stdout] 19c47afcdc1b175a9992a98bf557d66e9e2e8a229acb655052308e09b90a446a