[INFO] cloning repository https://github.com/Fergus-Molloy/todo [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Fergus-Molloy/todo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFergus-Molloy%2Ftodo", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFergus-Molloy%2Ftodo'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 18d6ee10a314be5a9988ba0d29668f653a5d8e9a [INFO] checking Fergus-Molloy/todo/18d6ee10a314be5a9988ba0d29668f653a5d8e9a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFergus-Molloy%2Ftodo" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Fergus-Molloy/todo on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Fergus-Molloy/todo [INFO] finished tweaking git repo https://github.com/Fergus-Molloy/todo [INFO] tweaked toml for git repo https://github.com/Fergus-Molloy/todo written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Fergus-Molloy/todo already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 582438827e6c413cef5221d87ef758467367cd95e2b27585c1f963ebb2f099a0 [INFO] running `Command { std: "docker" "start" "-a" "582438827e6c413cef5221d87ef758467367cd95e2b27585c1f963ebb2f099a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "582438827e6c413cef5221d87ef758467367cd95e2b27585c1f963ebb2f099a0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "582438827e6c413cef5221d87ef758467367cd95e2b27585c1f963ebb2f099a0", kill_on_drop: false }` [INFO] [stdout] 582438827e6c413cef5221d87ef758467367cd95e2b27585c1f963ebb2f099a0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be9a335c70ce72b5a8b14d6f912b8415ab1fb1f9228765dd77ed18cf04cba79b [INFO] running `Command { std: "docker" "start" "-a" "be9a335c70ce72b5a8b14d6f912b8415ab1fb1f9228765dd77ed18cf04cba79b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Checking ahash v0.4.7 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling libsqlite3-sys v0.20.1 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking hashlink v0.6.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Checking rusqlite v0.24.2 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Checking todo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `id` and `list` are never read [INFO] [stdout] --> src/task.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Task { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 30 | pub id: u32, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub list: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Task` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/clean.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 8 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let con = database::connect(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | let mut stmt = con.prepare(remove).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | stmt.execute(params![format!("{}", list_id)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/database.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 71 | let con = connect(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let sql = "SELECT name from lists where id==?"; [INFO] [stdout] 73 | con.query_row(sql, params![list_id], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `todo` (bin "todo" test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `id` and `list` are never read [INFO] [stdout] --> src/task.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct Task { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 30 | pub id: u32, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub list: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Task` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/clean.rs:22:5 [INFO] [stdout] | [INFO] [stdout] 8 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let con = database::connect(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | let mut stmt = con.prepare(remove).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | stmt.execute(params![format!("{}", list_id)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/database/database.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 71 | let con = connect(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | let sql = "SELECT name from lists where id==?"; [INFO] [stdout] 73 | con.query_row(sql, params![list_id], |row| Ok(row.get(0)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `todo` (bin "todo") due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "be9a335c70ce72b5a8b14d6f912b8415ab1fb1f9228765dd77ed18cf04cba79b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be9a335c70ce72b5a8b14d6f912b8415ab1fb1f9228765dd77ed18cf04cba79b", kill_on_drop: false }` [INFO] [stdout] be9a335c70ce72b5a8b14d6f912b8415ab1fb1f9228765dd77ed18cf04cba79b