[INFO] cloning repository https://github.com/FeistyKit/universe-simulator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FeistyKit/universe-simulator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFeistyKit%2Funiverse-simulator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFeistyKit%2Funiverse-simulator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 162012a2b62ba37cf63d9c71ed16d8004a0a2fd4 [INFO] checking FeistyKit/universe-simulator/162012a2b62ba37cf63d9c71ed16d8004a0a2fd4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFeistyKit%2Funiverse-simulator" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/FeistyKit/universe-simulator on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/FeistyKit/universe-simulator [INFO] finished tweaking git repo https://github.com/FeistyKit/universe-simulator [INFO] tweaked toml for git repo https://github.com/FeistyKit/universe-simulator written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/FeistyKit/universe-simulator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4151a7f9343f19d15a3422458b5285e713a5063fd8ebe7b47bff38985a78c81c [INFO] running `Command { std: "docker" "start" "-a" "4151a7f9343f19d15a3422458b5285e713a5063fd8ebe7b47bff38985a78c81c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4151a7f9343f19d15a3422458b5285e713a5063fd8ebe7b47bff38985a78c81c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4151a7f9343f19d15a3422458b5285e713a5063fd8ebe7b47bff38985a78c81c", kill_on_drop: false }` [INFO] [stdout] 4151a7f9343f19d15a3422458b5285e713a5063fd8ebe7b47bff38985a78c81c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b6a6b05a5d90a50bce9152dfc0229803910b62d8b6b13cba5eac5c66993ee4c1 [INFO] running `Command { std: "docker" "start" "-a" "b6a6b05a5d90a50bce9152dfc0229803910b62d8b6b13cba5eac5c66993ee4c1", kill_on_drop: false }` [INFO] [stderr] Compiling sfml-build v0.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling crossbeam-utils v0.8.5 [INFO] [stderr] Compiling memoffset v0.6.4 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling libc v0.2.97 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Checking widestring v0.4.3 [INFO] [stderr] Compiling csfml-system-sys v0.5.0 [INFO] [stderr] Compiling csfml-window-sys v0.5.0 [INFO] [stderr] Compiling csfml-graphics-sys v0.5.0 [INFO] [stderr] Compiling csfml-audio-sys v0.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking sfml v0.15.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking universe-sim v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/./rendering/graphichandler.rs:94:51 [INFO] [stdout] | [INFO] [stdout] 94 | GuiToGraphicsEvent::EnableGuideline { position, colour } => { [INFO] [stdout] | ^^^^^^^^ help: try ignoring the field: `position: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `colour` [INFO] [stdout] --> src/./rendering/graphichandler.rs:94:61 [INFO] [stdout] | [INFO] [stdout] 94 | GuiToGraphicsEvent::EnableGuideline { position, colour } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `colour: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./simulation/worldspace.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | let mut body = &mut self.bodies[idx]; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `rect`, `mouse_moved`, and `unclick` are never used [INFO] [stdout] --> src/./gui/gui.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub trait GuiWidget: Debug { [INFO] [stdout] | --------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 49 | fn rect(&self) -> FloatRect; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn mouse_moved( [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | fn unclick( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `to_file` and `from_file` are never used [INFO] [stdout] --> src/./simulation/worldspace.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl WorldSpace { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 146 | pub fn to_file(&self, name: String) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | pub fn from_file(name: String) -> Result> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./rendering/graphichandler.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 25 | sim_receiver: Receiver, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | gui_reciever: Receiver, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | bodies: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./rendering/graphichandler.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 25 | sim_receiver: Receiver, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | gui_reciever: Receiver, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | guideline_spots: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./gui/gui.rs:172:20 [INFO] [stdout] | [INFO] [stdout] 167 | graphics_sender: Sender, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | sim_sender: Sender, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | input_receiver: Receiver, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | items: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `position` [INFO] [stdout] --> src/./rendering/graphichandler.rs:94:51 [INFO] [stdout] | [INFO] [stdout] 94 | GuiToGraphicsEvent::EnableGuideline { position, colour } => { [INFO] [stdout] | ^^^^^^^^ help: try ignoring the field: `position: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `colour` [INFO] [stdout] --> src/./rendering/graphichandler.rs:94:61 [INFO] [stdout] | [INFO] [stdout] 94 | GuiToGraphicsEvent::EnableGuideline { position, colour } => { [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `colour: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `universe-sim` (bin "universe-sim" test) due to 4 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/./simulation/worldspace.rs:95:17 [INFO] [stdout] | [INFO] [stdout] 95 | let mut body = &mut self.bodies[idx]; [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `rect`, `mouse_moved`, and `unclick` are never used [INFO] [stdout] --> src/./gui/gui.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 43 | pub trait GuiWidget: Debug { [INFO] [stdout] | --------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 49 | fn rect(&self) -> FloatRect; [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | fn mouse_moved( [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | fn unclick( [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `to_file` and `from_file` are never used [INFO] [stdout] --> src/./simulation/worldspace.rs:146:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl WorldSpace { [INFO] [stdout] | --------------- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 146 | pub fn to_file(&self, name: String) -> Result<(), Box> { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 154 | pub fn from_file(name: String) -> Result> { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./rendering/graphichandler.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 25 | sim_receiver: Receiver, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | gui_reciever: Receiver, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | bodies: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./rendering/graphichandler.rs:30:30 [INFO] [stdout] | [INFO] [stdout] 25 | sim_receiver: Receiver, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | gui_reciever: Receiver, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | guideline_spots: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/./gui/gui.rs:172:20 [INFO] [stdout] | [INFO] [stdout] 167 | graphics_sender: Sender, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | sim_sender: Sender, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | input_receiver: Receiver, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | items: Vec::new(), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `universe-sim` (bin "universe-sim") due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b6a6b05a5d90a50bce9152dfc0229803910b62d8b6b13cba5eac5c66993ee4c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b6a6b05a5d90a50bce9152dfc0229803910b62d8b6b13cba5eac5c66993ee4c1", kill_on_drop: false }` [INFO] [stdout] b6a6b05a5d90a50bce9152dfc0229803910b62d8b6b13cba5eac5c66993ee4c1