[INFO] cloning repository https://github.com/Faynot/protoF [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Faynot/protoF" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFaynot%2FprotoF", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFaynot%2FprotoF'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7c4bcd0d8f6c1c2b503967474572ad8098e9a42c [INFO] checking Faynot/protoF/7c4bcd0d8f6c1c2b503967474572ad8098e9a42c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFaynot%2FprotoF" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Faynot/protoF on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Faynot/protoF [INFO] finished tweaking git repo https://github.com/Faynot/protoF [INFO] tweaked toml for git repo https://github.com/Faynot/protoF written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Faynot/protoF already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 009a3c1a0321a1a8ca2289362942e62e400882129401ab64d4b308c0c54a47e8 [INFO] running `Command { std: "docker" "start" "-a" "009a3c1a0321a1a8ca2289362942e62e400882129401ab64d4b308c0c54a47e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "009a3c1a0321a1a8ca2289362942e62e400882129401ab64d4b308c0c54a47e8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "009a3c1a0321a1a8ca2289362942e62e400882129401ab64d4b308c0c54a47e8", kill_on_drop: false }` [INFO] [stdout] 009a3c1a0321a1a8ca2289362942e62e400882129401ab64d4b308c0c54a47e8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8b933ab8251b208c6070e674fee4325442d17534e045e5ed3421dc1dea016c0b [INFO] running `Command { std: "docker" "start" "-a" "8b933ab8251b208c6070e674fee4325442d17534e045e5ed3421dc1dea016c0b", kill_on_drop: false }` [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Compiling protof v0.0.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking str_indices v0.4.3 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking cc v1.0.98 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking ropey v1.6.1 [INFO] [stderr] Checking mio v0.7.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking crossterm v0.19.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking indicatif v0.16.2 [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | use std::io::{self, stdout, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Read` [INFO] [stdout] --> src/main.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | use std::io::{self, stdout, Read, Write}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/search.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn key_adder(self, mode: &Mode) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | / self.insert_mapping_chain( [INFO] [stdout] 75 | | mode, [INFO] [stdout] 76 | | ('a'..='z').collect::().as_str(), [INFO] [stdout] 77 | | KeyModifiers::NONE, [INFO] [stdout] ... | [INFO] [stdout] 87 | | KeyModifiers::NONE, [INFO] [stdout] 88 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 92 | fn build_normal(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | / self.insert_mapping( [INFO] [stdout] 96 | | &Normal, [INFO] [stdout] 97 | | KeyEvent::new(KeyCode::Esc, KeyModifiers::NONE), [INFO] [stdout] 98 | | Box::new(|editor| editor.is_running = false), [INFO] [stdout] ... | [INFO] [stdout] 178 | | }), [INFO] [stdout] 179 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:187:13 [INFO] [stdout] | [INFO] [stdout] 92 | fn build_normal(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | / Box::new(|editor| { [INFO] [stdout] 188 | | editor.mode = Command; [INFO] [stdout] 189 | | editor.command.clear(); [INFO] [stdout] 190 | | editor.error = EditorError::NONE; [INFO] [stdout] 191 | | editor.output = String::new(); [INFO] [stdout] 192 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 196 | fn build_insert(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | / self.insert_mapping( [INFO] [stdout] 200 | | &Normal, [INFO] [stdout] 201 | | KeyEvent::new(KeyCode::Char('i'), KeyModifiers::NONE), [INFO] [stdout] 202 | | Box::new(|editor| editor.mode = Mode::Insert), [INFO] [stdout] ... | [INFO] [stdout] 249 | | }), [INFO] [stdout] 250 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 254 | fn build_command(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | / self.insert_mapping( [INFO] [stdout] 258 | | &Command, [INFO] [stdout] 259 | | KeyEvent::new(KeyCode::Esc, KeyModifiers::NONE), [INFO] [stdout] 260 | | Box::new(|editor| editor.mode = Normal), [INFO] [stdout] ... | [INFO] [stdout] 276 | | ) [INFO] [stdout] 277 | | .key_adder(&Command) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:281:13 [INFO] [stdout] | [INFO] [stdout] 254 | fn build_command(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | / Box::new(|editor: &mut Editor| { [INFO] [stdout] 282 | | match editor.command.as_str() { [INFO] [stdout] 283 | | "q" => editor.is_running = false, [INFO] [stdout] 284 | | "w" => { [INFO] [stdout] ... | [INFO] [stdout] 308 | | editor.command = String::new(); // vec![" "; editor.screen.max_w].into_iter().collect(); [INFO] [stdout] 309 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protof` (bin "protof") due to 7 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/search.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | fn main() { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn key_adder(self, mode: &Mode) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | / self.insert_mapping_chain( [INFO] [stdout] 75 | | mode, [INFO] [stdout] 76 | | ('a'..='z').collect::().as_str(), [INFO] [stdout] 77 | | KeyModifiers::NONE, [INFO] [stdout] ... | [INFO] [stdout] 87 | | KeyModifiers::NONE, [INFO] [stdout] 88 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 92 | fn build_normal(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 95 | / self.insert_mapping( [INFO] [stdout] 96 | | &Normal, [INFO] [stdout] 97 | | KeyEvent::new(KeyCode::Esc, KeyModifiers::NONE), [INFO] [stdout] 98 | | Box::new(|editor| editor.is_running = false), [INFO] [stdout] ... | [INFO] [stdout] 178 | | }), [INFO] [stdout] 179 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:187:13 [INFO] [stdout] | [INFO] [stdout] 92 | fn build_normal(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 187 | / Box::new(|editor| { [INFO] [stdout] 188 | | editor.mode = Command; [INFO] [stdout] 189 | | editor.command.clear(); [INFO] [stdout] 190 | | editor.error = EditorError::NONE; [INFO] [stdout] 191 | | editor.output = String::new(); [INFO] [stdout] 192 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:199:9 [INFO] [stdout] | [INFO] [stdout] 196 | fn build_insert(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | / self.insert_mapping( [INFO] [stdout] 200 | | &Normal, [INFO] [stdout] 201 | | KeyEvent::new(KeyCode::Char('i'), KeyModifiers::NONE), [INFO] [stdout] 202 | | Box::new(|editor| editor.mode = Mode::Insert), [INFO] [stdout] ... | [INFO] [stdout] 249 | | }), [INFO] [stdout] 250 | | ) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:257:9 [INFO] [stdout] | [INFO] [stdout] 254 | fn build_command(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 257 | / self.insert_mapping( [INFO] [stdout] 258 | | &Command, [INFO] [stdout] 259 | | KeyEvent::new(KeyCode::Esc, KeyModifiers::NONE), [INFO] [stdout] 260 | | Box::new(|editor| editor.mode = Normal), [INFO] [stdout] ... | [INFO] [stdout] 276 | | ) [INFO] [stdout] 277 | | .key_adder(&Command) [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/keymapper.rs:281:13 [INFO] [stdout] | [INFO] [stdout] 254 | fn build_command(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | / Box::new(|editor: &mut Editor| { [INFO] [stdout] 282 | | match editor.command.as_str() { [INFO] [stdout] 283 | | "q" => editor.is_running = false, [INFO] [stdout] 284 | | "w" => { [INFO] [stdout] ... | [INFO] [stdout] 308 | | editor.command = String::new(); // vec![" "; editor.screen.max_w].into_iter().collect(); [INFO] [stdout] 309 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `protof` (bin "protof" test) due to 7 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8b933ab8251b208c6070e674fee4325442d17534e045e5ed3421dc1dea016c0b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b933ab8251b208c6070e674fee4325442d17534e045e5ed3421dc1dea016c0b", kill_on_drop: false }` [INFO] [stdout] 8b933ab8251b208c6070e674fee4325442d17534e045e5ed3421dc1dea016c0b