[INFO] cloning repository https://github.com/FauxFaux/quad-image [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/FauxFaux/quad-image" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFauxFaux%2Fquad-image", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFauxFaux%2Fquad-image'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1b87c25c5540edd1a88a54404237c52cac612566 [INFO] checking FauxFaux/quad-image/1b87c25c5540edd1a88a54404237c52cac612566 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFauxFaux%2Fquad-image" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/FauxFaux/quad-image on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/FauxFaux/quad-image [INFO] finished tweaking git repo https://github.com/FauxFaux/quad-image [INFO] tweaked toml for git repo https://github.com/FauxFaux/quad-image written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/FauxFaux/quad-image already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a21a63586de49ae53a63f8bbe6b02a296f7cbc331a4063a477a8ee6a920787ef [INFO] running `Command { std: "docker" "start" "-a" "a21a63586de49ae53a63f8bbe6b02a296f7cbc331a4063a477a8ee6a920787ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a21a63586de49ae53a63f8bbe6b02a296f7cbc331a4063a477a8ee6a920787ef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a21a63586de49ae53a63f8bbe6b02a296f7cbc331a4063a477a8ee6a920787ef", kill_on_drop: false }` [INFO] [stdout] a21a63586de49ae53a63f8bbe6b02a296f7cbc331a4063a477a8ee6a920787ef [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] afd4528e9eaffcf0702302a6a2ce8e1589729b9e9661857e116cab813aa117cc [INFO] running `Command { std: "docker" "start" "-a" "afd4528e9eaffcf0702302a6a2ce8e1589729b9e9661857e116cab813aa117cc", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling serde v1.0.206 [INFO] [stderr] Compiling syn v2.0.74 [INFO] [stderr] Compiling cc v1.1.10 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling serde_json v1.0.124 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking gzip-header v1.0.0 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking deflate v1.0.0 [INFO] [stderr] Checking filetime v0.2.24 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking zune-jpeg v0.4.13 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Checking image-webp v0.1.3 [INFO] [stderr] Checking brotli v3.5.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking mutate_once v0.1.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Compiling libsqlite3-sys v0.30.1 [INFO] [stderr] Checking kamadak-exif v0.5.5 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking image v0.25.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.206 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking multipart v0.18.0 [INFO] [stderr] Checking tempfile-fast v0.3.4 [INFO] [stderr] Checking rouille v3.6.2 [INFO] [stderr] Checking rusqlite v0.32.1 [INFO] [stderr] Checking quad-image v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:221:11 [INFO] [stdout] | [INFO] [stdout] 141 | fn gallery_put(conn: Conn, global_secret: &[u8], request: &Request) -> Response { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Err(other) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Some(captures) => ( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | match gallery::gallery_store(conn, global_secret, gallery, private, &images) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:247:11 [INFO] [stdout] | [INFO] [stdout] 234 | fn gallery_get(request: &Request, conn: Conn, public: &str) -> Response { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let mut conn = match conn.lock() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | Ok(conn) => conn, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | Err(_posion) => { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | match gallery::gallery_list_all(&mut *conn, public) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:345:39 [INFO] [stdout] | [INFO] [stdout] 344 | fn static_file(content_type: &'static str, path: impl AsRef) -> Response { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | Response::from_file(content_type, fs::File::open(path).expect("static")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thumbs.rs:38:21 [INFO] [stdout] | [INFO] [stdout] 38 | .map(|path| thumbnail(path).with_context(|| anyhow!("thumbnailing {:?}", path))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:221:11 [INFO] [stdout] | [INFO] [stdout] 141 | fn gallery_put(conn: Conn, global_secret: &[u8], request: &Request) -> Response { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Err(other) => { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 209 | Some(captures) => ( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 221 | match gallery::gallery_store(conn, global_secret, gallery, private, &images) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:247:11 [INFO] [stdout] | [INFO] [stdout] 234 | fn gallery_get(request: &Request, conn: Conn, public: &str) -> Response { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 239 | let mut conn = match conn.lock() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 240 | Ok(conn) => conn, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | Err(_posion) => { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | match gallery::gallery_list_all(&mut *conn, public) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quad-image` (bin "quad-image") due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:345:39 [INFO] [stdout] | [INFO] [stdout] 344 | fn static_file(content_type: &'static str, path: impl AsRef) -> Response { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 345 | Response::from_file(content_type, fs::File::open(path).expect("static")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tests.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 25 | .map(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | e.unwrap() [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thumbs.rs:38:21 [INFO] [stdout] | [INFO] [stdout] 38 | .map(|path| thumbnail(path).with_context(|| anyhow!("thumbnailing {:?}", path))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quad-image` (bin "quad-image" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "afd4528e9eaffcf0702302a6a2ce8e1589729b9e9661857e116cab813aa117cc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "afd4528e9eaffcf0702302a6a2ce8e1589729b9e9661857e116cab813aa117cc", kill_on_drop: false }` [INFO] [stdout] afd4528e9eaffcf0702302a6a2ce8e1589729b9e9661857e116cab813aa117cc