[INFO] cloning repository https://github.com/Farmadupe/vid_dup_finder_lib [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Farmadupe/vid_dup_finder_lib" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFarmadupe%2Fvid_dup_finder_lib", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFarmadupe%2Fvid_dup_finder_lib'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 49165d15991faea0ab69f9f68e85ab9b3506ebe9 [INFO] checking Farmadupe/vid_dup_finder_lib/49165d15991faea0ab69f9f68e85ab9b3506ebe9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FFarmadupe%2Fvid_dup_finder_lib" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Farmadupe/vid_dup_finder_lib on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Farmadupe/vid_dup_finder_lib [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking git repo https://github.com/Farmadupe/vid_dup_finder_lib [INFO] tweaked toml for git repo https://github.com/Farmadupe/vid_dup_finder_lib written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 73 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding image v0.24.9 (latest: v0.25.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num-complex v0.3.1 (latest: v0.4.6) [INFO] [stderr] Adding rustdct v0.6.0 (latest: v0.7.1) [INFO] [stderr] Adding rustfft v5.1.1 (latest: v6.2.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 36413945a4e3e280621a03ffd104ae7cc7d03be14d54dcfe2ce8a94598aeac0f [INFO] running `Command { std: "docker" "start" "-a" "36413945a4e3e280621a03ffd104ae7cc7d03be14d54dcfe2ce8a94598aeac0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "36413945a4e3e280621a03ffd104ae7cc7d03be14d54dcfe2ce8a94598aeac0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "36413945a4e3e280621a03ffd104ae7cc7d03be14d54dcfe2ce8a94598aeac0f", kill_on_drop: false }` [INFO] [stdout] 36413945a4e3e280621a03ffd104ae7cc7d03be14d54dcfe2ce8a94598aeac0f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 73f0001c0a16a6bf1a14d530a5999ef58be14f19855f7c0caea6aec46b062ada [INFO] running `Command { std: "docker" "start" "-a" "73f0001c0a16a6bf1a14d530a5999ef58be14f19855f7c0caea6aec46b062ada", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking weezl v0.1.8 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking fdeflate v0.3.4 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking flume v0.11.0 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking lebe v0.5.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking bit_field v0.10.2 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking gif v0.13.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking num-complex v0.3.1 [INFO] [stderr] Checking exr v1.72.0 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rustfft v5.1.1 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking jpeg-decoder v0.3.1 [INFO] [stderr] Checking tiff v0.9.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rustdct v0.6.0 [INFO] [stderr] Checking ffmpeg_cmdline_utils v0.1.3 [INFO] [stderr] Checking vid_dup_finder_lib v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `*` [INFO] [stdout] --> src/lib.rs:108:54 [INFO] [stdout] | [INFO] [stdout] 108 | pub use video_hashing::video_hash::test_util::{self, *}; [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/video_hashing/search.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | for mut entry in self.duration_slice(target.duration()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/video_hashing/search.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | for mut entry in self.duration_slice(target.duration()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:21:25 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(entries: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | duplicates: entries.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new_with_reference(reference: VideoHash, entries: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | duplicates: entries.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(it: I) -> MatchGroup { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | MatchGroup::new(it.into_iter().map(|x| x.borrow().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/video_dup_finder.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 18 | ref_hashes: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | new_hashes: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | / ref_hashes [INFO] [stdout] 24 | | .into_iter() [INFO] [stdout] 25 | | .filter_map(|new_hash| { [INFO] [stdout] 26 | | let search_result = [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/video_hash.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 89 | src_path: impl AsRef [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> Result<(FfmpegFrames, VideoInfo), HashCreationErrorKind> { [INFO] [stdout] 91 | / FfmpegFrameReaderBuilder::new(src_path.as_ref().to_owned()) [INFO] [stdout] 92 | | .num_frames(HASH_NUM_IMAGES as u32) [INFO] [stdout] 93 | | .fps(crate::definitions::HASH_FRAMERATE) [INFO] [stdout] 94 | | .timeout_secs(60) [INFO] [stdout] 95 | | .spawn() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:21:25 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(entries: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 21 | duplicates: entries.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:30:25 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn new_with_reference(reference: VideoHash, entries: impl IntoIterator) -> Self { [INFO] [stdout] | -------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 30 | duplicates: entries.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vid_dup_finder_lib` (lib) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/matches/match_group.rs:56:25 [INFO] [stdout] | [INFO] [stdout] 55 | fn from(it: I) -> MatchGroup { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | MatchGroup::new(it.into_iter().map(|x| x.borrow().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/video_dup_finder.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 18 | ref_hashes: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | new_hashes: impl IntoIterator, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | / ref_hashes [INFO] [stdout] 24 | | .into_iter() [INFO] [stdout] 25 | | .filter_map(|new_hash| { [INFO] [stdout] 26 | | let search_result = [INFO] [stdout] ... | [INFO] [stdout] 33 | | } [INFO] [stdout] 34 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video_hashing/video_hash.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 89 | src_path: impl AsRef [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | ) -> Result<(FfmpegFrames, VideoInfo), HashCreationErrorKind> { [INFO] [stdout] 91 | / FfmpegFrameReaderBuilder::new(src_path.as_ref().to_owned()) [INFO] [stdout] 92 | | .num_frames(HASH_NUM_IMAGES as u32) [INFO] [stdout] 93 | | .fps(crate::definitions::HASH_FRAMERATE) [INFO] [stdout] 94 | | .timeout_secs(60) [INFO] [stdout] 95 | | .spawn() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vid_dup_finder_lib` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "73f0001c0a16a6bf1a14d530a5999ef58be14f19855f7c0caea6aec46b062ada", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "73f0001c0a16a6bf1a14d530a5999ef58be14f19855f7c0caea6aec46b062ada", kill_on_drop: false }` [INFO] [stdout] 73f0001c0a16a6bf1a14d530a5999ef58be14f19855f7c0caea6aec46b062ada