[INFO] updating cached repository https://github.com/EstebanBorai/data-structures-and-algorithms-with-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9c734424fb3b1f5bc653cae252adfd2eda119768 [INFO] checking EstebanBorai/data-structures-and-algorithms-with-rust/9c734424fb3b1f5bc653cae252adfd2eda119768 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEstebanBorai%2Fdata-structures-and-algorithms-with-rust" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/EstebanBorai/data-structures-and-algorithms-with-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/EstebanBorai/data-structures-and-algorithms-with-rust [INFO] finished tweaking git repo https://github.com/EstebanBorai/data-structures-and-algorithms-with-rust [INFO] tweaked toml for git repo https://github.com/EstebanBorai/data-structures-and-algorithms-with-rust written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/EstebanBorai/data-structures-and-algorithms-with-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 39e29df172dbd40dbb8d2cb6c838c2817bab3ccf2585845fc1fb0eeb210db2ba [INFO] running `Command { std: "docker" "start" "-a" "39e29df172dbd40dbb8d2cb6c838c2817bab3ccf2585845fc1fb0eeb210db2ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "39e29df172dbd40dbb8d2cb6c838c2817bab3ccf2585845fc1fb0eeb210db2ba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39e29df172dbd40dbb8d2cb6c838c2817bab3ccf2585845fc1fb0eeb210db2ba", kill_on_drop: false }` [INFO] [stdout] 39e29df172dbd40dbb8d2cb6c838c2817bab3ccf2585845fc1fb0eeb210db2ba [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c8a9badfd2785abf0b1215eecb705a548b260caaa21d129c28ecf07aa078d1ea [INFO] running `Command { std: "docker" "start" "-a" "c8a9badfd2785abf0b1215eecb705a548b260caaa21d129c28ecf07aa078d1ea", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.94 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking dsa-in-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: type alias `Tree` is never used [INFO] [stdout] --> src/binary_search_tree.rs:9:6 [INFO] [stdout] | [INFO] [stdout] 9 | type Tree = Option>>; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/binary_search_tree.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `boxed`, and `peek` are never used [INFO] [stdout] --> src/binary_search_tree.rs:25:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl Node { [INFO] [stdout] | -------------------------------------------------------- associated items in this implementation [INFO] [stdout] 25 | pub fn new(value: T) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 33 | pub fn boxed(value: T) -> Box { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub fn peek(&self) -> &T { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BinarySearchTree` is never constructed [INFO] [stdout] --> src/binary_search_tree.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct BinarySearchTree { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BinarySearchTree` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/binary_search_tree.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 51 | impl BinarySearchTree { [INFO] [stdout] | -------------------------------------------------------------------- associated items in this implementation [INFO] [stdout] 52 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn add(&mut self, value: T) { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 75 | fn add_recursive(&mut self, node: Tree, value: T) -> Tree { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn find(&self, value: T) -> Option { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | fn find_recursive(&self, node: &Tree, value: T) -> Option { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 109 | pub fn walk(&self, func: impl Fn(&T) -> ()) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 113 | fn walk_in_order(&self, node: &Tree, func: &impl Fn(&T) -> ()) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `peek_value` are never used [INFO] [stdout] --> src/doubly_linked_list.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 23 | / impl Node [INFO] [stdout] 24 | | where [INFO] [stdout] 25 | | T: Clone + Debug, [INFO] [stdout] | |_____________________- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn new(value: T) -> Rc> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | pub fn peek_value(&self) -> &T { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DoublyLinkedList` is never constructed [INFO] [stdout] --> src/doubly_linked_list.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 46 | pub struct DoublyLinkedList { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DoublyLinkedList` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `len`, `append`, and `pop` are never used [INFO] [stdout] --> src/doubly_linked_list.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 52 | / impl DoublyLinkedList [INFO] [stdout] 53 | | where [INFO] [stdout] 54 | | T: Clone + Debug, [INFO] [stdout] | |_____________________- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 58 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 67 | pub fn len(&self) -> u32 { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 72 | pub fn append(&mut self, value: T) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 90 | pub fn pop(&mut self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/doubly_linked_list.rs:120:8 [INFO] [stdout] | [INFO] [stdout] 116 | / impl ListIterator [INFO] [stdout] 117 | | where [INFO] [stdout] 118 | | T: Clone + Debug, [INFO] [stdout] | |_____________________- associated function in this implementation [INFO] [stdout] 119 | { [INFO] [stdout] 120 | fn new(current: Link) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DynamicArray` is never constructed [INFO] [stdout] --> src/dynamic_array.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct DynamicArray { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `grow`, `ensure_capacity`, `item_at`, and `add` are never used [INFO] [stdout] --> src/dynamic_array.rs:18:12 [INFO] [stdout] | [INFO] [stdout] 17 | impl DynamicArray { [INFO] [stdout] | ------------------------------ associated items in this implementation [INFO] [stdout] 18 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 32 | fn grow(&mut self, min_cap: usize) { [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 46 | fn ensure_capacity(&mut self, items_to_add: usize) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 52 | pub fn item_at(&mut self, index: usize) -> Option { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 60 | pub fn add(&mut self, value: T) { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Link` is never used [INFO] [stdout] --> src/singly_linked_list.rs:8:10 [INFO] [stdout] | [INFO] [stdout] 8 | pub type Link = Option>>>; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/singly_linked_list.rs:13:12 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `peek_value` are never used [INFO] [stdout] --> src/singly_linked_list.rs:23:12 [INFO] [stdout] | [INFO] [stdout] 18 | / impl Node [INFO] [stdout] 19 | | where [INFO] [stdout] 20 | | T: std::fmt::Debug, [INFO] [stdout] | |_______________________- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 23 | pub fn new(value: T) -> Rc> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 28 | pub fn peek_value(&self) -> &T { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SinglyLinkedList` is never constructed [INFO] [stdout] --> src/singly_linked_list.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct SinglyLinkedList { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SinglyLinkedList` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `len`, `append`, and `pop` are never used [INFO] [stdout] --> src/singly_linked_list.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 43 | / impl SinglyLinkedList [INFO] [stdout] 44 | | where [INFO] [stdout] 45 | | T: std::fmt::Debug, [INFO] [stdout] | |_______________________- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 49 | pub fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 58 | pub fn len(&self) -> u32 { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn append(&mut self, value: T) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 76 | pub fn pop(&mut self) -> Option { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Link` is never used [INFO] [stdout] --> src/skip_list.rs:16:10 [INFO] [stdout] | [INFO] [stdout] 16 | pub type Link = Option>>>; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Node` is never constructed [INFO] [stdout] --> src/skip_list.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct Node { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new` and `peek_value` are never used [INFO] [stdout] --> src/skip_list.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 26 | / impl Node [INFO] [stdout] 27 | | where [INFO] [stdout] 28 | | T: std::fmt::Debug, [INFO] [stdout] | |_______________________- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 31 | pub fn new(level: usize, value: T) -> Rc> { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn peek_value(&self) -> &T { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `SkipList` is never constructed [INFO] [stdout] --> src/skip_list.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 45 | pub struct SkipList { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SkipList` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `new`, `append`, and `get_level` are never used [INFO] [stdout] --> src/skip_list.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 52 | / impl SkipList [INFO] [stdout] 53 | | where [INFO] [stdout] 54 | | T: std::fmt::Debug, [INFO] [stdout] | |_______________________- associated items in this implementation [INFO] [stdout] 55 | { [INFO] [stdout] 56 | pub fn new(max_level: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 65 | pub fn append(&mut self, value: T) { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 96 | fn get_level(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/binary_search_tree.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | type Tree = Option>>; [INFO] [stdout] | --^^^^^^^^^^^^^---^^^^^^^^^^^^^^^---^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | left: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | right: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn boxed(value: T) -> Box { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Box::new(Node::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 75 | fn add_recursive(&mut self, node: Tree, value: T) -> Tree { [INFO] [stdout] | ------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Some(Node::boxed(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doubly_linked_list.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(value: T) -> Rc> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 30 | | value, [INFO] [stdout] 31 | | next: None, [INFO] [stdout] 32 | | prev: None, [INFO] [stdout] 33 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doubly_linked_list.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 91 | self.head.take().map(|head| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / Rc::try_unwrap(head) [INFO] [stdout] 101 | | .ok() [INFO] [stdout] 102 | | .expect("Failed to retrieve node from list") [INFO] [stdout] 103 | | .into_inner() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doubly_linked_list.rs:163:23 [INFO] [stdout] | [INFO] [stdout] 159 | let current = current.borrow(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | match current.prev.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/singly_linked_list.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(value: T) -> Rc> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Rc::new(RefCell::new(Node { next: None, value })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/singly_linked_list.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 77 | self.head.take().map(|head| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / Rc::try_unwrap(head) [INFO] [stdout] 87 | | .ok() [INFO] [stdout] 88 | | .expect("Failed to retrieve node from list") [INFO] [stdout] 89 | | .into_inner() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/skip_list.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(level: usize, value: T) -> Rc> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 33 | | links: vec![None; level], [INFO] [stdout] 34 | | value, [INFO] [stdout] 35 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 22 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsa-in-rust` (lib) due to 11 previous errors; 22 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `peek` is never used [INFO] [stdout] --> src/binary_search_tree.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 24 | impl Node { [INFO] [stdout] | -------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 37 | pub fn peek(&self) -> &T { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `value` is never read [INFO] [stdout] --> src/skip_list.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct Node { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 22 | links: Vec>, [INFO] [stdout] 23 | value: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Node` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `peek_value` is never used [INFO] [stdout] --> src/skip_list.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 26 | / impl Node [INFO] [stdout] 27 | | where [INFO] [stdout] 28 | | T: std::fmt::Debug, [INFO] [stdout] | |_______________________- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 39 | pub fn peek_value(&self) -> &T { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: bounds on generic parameters in type aliases are not enforced [INFO] [stdout] --> src/binary_search_tree.rs:9:14 [INFO] [stdout] | [INFO] [stdout] 9 | type Tree = Option>>; [INFO] [stdout] | --^^^^^^^^^^^^^---^^^^^^^^^^^^^^^---^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | will not be checked at usage sites of the type alias [INFO] [stdout] | help: remove this bound [INFO] [stdout] | [INFO] [stdout] = note: this is a known limitation of the type checker that may be lifted in a future edition. [INFO] [stdout] see issue #112792 for more information [INFO] [stdout] = help: add `#![feature(lazy_type_alias)]` to the crate attributes to enable the desired semantics [INFO] [stdout] = note: `#[warn(type_alias_bounds)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | left: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree.rs:29:20 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | right: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree.rs:34:18 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn boxed(value: T) -> Box { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Box::new(Node::new(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/binary_search_tree.rs:86:14 [INFO] [stdout] | [INFO] [stdout] 75 | fn add_recursive(&mut self, node: Tree, value: T) -> Tree { [INFO] [stdout] | ------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Some(Node::boxed(value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doubly_linked_list.rs:29:17 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn new(value: T) -> Rc> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 30 | | value, [INFO] [stdout] 31 | | next: None, [INFO] [stdout] 32 | | prev: None, [INFO] [stdout] 33 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doubly_linked_list.rs:100:13 [INFO] [stdout] | [INFO] [stdout] 91 | self.head.take().map(|head| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / Rc::try_unwrap(head) [INFO] [stdout] 101 | | .ok() [INFO] [stdout] 102 | | .expect("Failed to retrieve node from list") [INFO] [stdout] 103 | | .into_inner() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/doubly_linked_list.rs:163:23 [INFO] [stdout] | [INFO] [stdout] 159 | let current = current.borrow(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | match current.prev.clone() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/singly_linked_list.rs:24:17 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(value: T) -> Rc> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | Rc::new(RefCell::new(Node { next: None, value })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/singly_linked_list.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 77 | self.head.take().map(|head| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / Rc::try_unwrap(head) [INFO] [stdout] 87 | | .ok() [INFO] [stdout] 88 | | .expect("Failed to retrieve node from list") [INFO] [stdout] 89 | | .into_inner() [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/skip_list.rs:32:17 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn new(level: usize, value: T) -> Rc> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | Rc::new(RefCell::new(Node { [INFO] [stdout] | _________________^ [INFO] [stdout] 33 | | links: vec![None; level], [INFO] [stdout] 34 | | value, [INFO] [stdout] 35 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dsa-in-rust` (lib test) due to 11 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c8a9badfd2785abf0b1215eecb705a548b260caaa21d129c28ecf07aa078d1ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c8a9badfd2785abf0b1215eecb705a548b260caaa21d129c28ecf07aa078d1ea", kill_on_drop: false }` [INFO] [stdout] c8a9badfd2785abf0b1215eecb705a548b260caaa21d129c28ecf07aa078d1ea