[INFO] cloning repository https://github.com/ErichDonGubler/dit [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ErichDonGubler/dit" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FErichDonGubler%2Fdit", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FErichDonGubler%2Fdit'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d2561c70544984c640c74b91765fa3af95d516ed [INFO] checking ErichDonGubler/dit/d2561c70544984c640c74b91765fa3af95d516ed against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FErichDonGubler%2Fdit" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ErichDonGubler/dit on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ErichDonGubler/dit [INFO] finished tweaking git repo https://github.com/ErichDonGubler/dit [INFO] tweaked toml for git repo https://github.com/ErichDonGubler/dit written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ErichDonGubler/dit already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7d55e32acc3556d1aa9747928b2d5c19f5009f8ef24be60a7e57461828691caf [INFO] running `Command { std: "docker" "start" "-a" "7d55e32acc3556d1aa9747928b2d5c19f5009f8ef24be60a7e57461828691caf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7d55e32acc3556d1aa9747928b2d5c19f5009f8ef24be60a7e57461828691caf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7d55e32acc3556d1aa9747928b2d5c19f5009f8ef24be60a7e57461828691caf", kill_on_drop: false }` [INFO] [stdout] 7d55e32acc3556d1aa9747928b2d5c19f5009f8ef24be60a7e57461828691caf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af35bd97c5d56937c77e1e7938c9409f4f7f811358a8d4eaafa6a0c67d270a37 [INFO] running `Command { std: "docker" "start" "-a" "af35bd97c5d56937c77e1e7938c9409f4f7f811358a8d4eaafa6a0c67d270a37", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling unicode-segmentation v1.10.1 [INFO] [stderr] Checking anstyle-parse v0.2.2 [INFO] [stderr] Checking anstyle v1.0.4 [INFO] [stderr] Checking cvt v0.1.2 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking termcolor v1.4.0 [INFO] [stderr] Compiling thiserror v1.0.50 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking format-core v0.2.4 [INFO] [stderr] Checking anstream v0.6.4 [INFO] [stderr] Checking normpath v1.1.1 [INFO] [stderr] Checking path-clean v0.1.0 [INFO] [stderr] Checking path-dsl v0.6.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling syn v2.0.39 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking colored v2.0.4 [INFO] [stderr] Checking clap_builder v4.4.9 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking directories v4.0.1 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking fs_at v0.1.10 [INFO] [stderr] Checking remove_dir_all v0.8.2 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.50 [INFO] [stderr] Compiling clap_derive v4.4.7 [INFO] [stderr] Checking env_logger v0.10.1 [INFO] [stderr] Checking colog v1.2.0 [INFO] [stderr] Compiling lifetime_proc_macros_impl v0.1.0 [INFO] [stderr] Checking clap v4.4.10 [INFO] [stderr] Compiling strum_macros v0.21.1 [INFO] [stderr] Compiling lifetime_proc_macros v0.1.0 [INFO] [stderr] Compiling format-macro v0.2.4 [INFO] [stderr] Checking lifetime v0.1.0 [INFO] [stderr] Checking format v0.2.4 [INFO] [stderr] Checking strum v0.21.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking bellboy v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `NewRepoNameContainer` is never used [INFO] [stdout] --> src/bin/bb/cli.rs:292:11 [INFO] [stdout] | [INFO] [stdout] 292 | pub trait NewRepoNameContainer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | / path_buf [INFO] [stdout] 87 | | .file_name() [INFO] [stdout] 88 | | .with_context(|| anyhow!("no base name found for path {:?}", path))? [INFO] [stdout] 89 | | .to_str() [INFO] [stdout] 90 | | .context("base name is not UTF-8") [INFO] [stdout] 91 | | .and_then(|base_name| Ok(RepoName::from_str(base_name)?)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner.rs:339:21 [INFO] [stdout] | [INFO] [stdout] 337 | let cmd_status = repo.run_cmd(cmd, |mut cmd| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | log::debug!("running command {:?}", cmd); [INFO] [stdout] 339 | cmd.status().context("failed to spawn command") [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner.rs:374:70 [INFO] [stdout] | [INFO] [stdout] 374 | .map(|(name, repo)| (name.clone().into_static(), repo.short_desc().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:324:25 [INFO] [stdout] | [INFO] [stdout] 321 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | Some(anyhow::Error::new(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:392:58 [INFO] [stdout] | [INFO] [stdout] 392 | .map_err(|e| err("spawn command".into(), Some(anyhow::Error::new(e))))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:424:58 [INFO] [stdout] | [INFO] [stdout] 424 | .map_err(|e| err("spawn command".into(), Some(anyhow::Error::new(e))))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:515:13 [INFO] [stdout] | [INFO] [stdout] 513 | let mut cmd = Command::new("git"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | cmd.arg("ls-files").stderr(Stdio::inherit()); [INFO] [stdout] 515 | / (|| { [INFO] [stdout] 516 | | let cwd = current_dir()?; [INFO] [stdout] 517 | | [INFO] [stdout] 518 | | set_current_dir(&self.work_tree_path) [INFO] [stdout] ... | [INFO] [stdout] 544 | | })() [INFO] [stdout] 545 | | .map(|i| -> Box> { Box::new(i) }) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:533:25 [INFO] [stdout] | [INFO] [stdout] 532 | .map(|l| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | l.context("failed to read line from output") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/repo_db.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | git.open_repo(options) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/repo_db.rs:274:25 [INFO] [stdout] | [INFO] [stdout] 273 | entries.filter_map(|ent| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | / (|| -> anyhow::Result<_> { [INFO] [stdout] 275 | | let ent = ent.with_context(|| anyhow!("failed to read a dir entry in overlay repo path"))?; [INFO] [stdout] 276 | | [INFO] [stdout] 277 | | let file_name = ent.file_name(); [INFO] [stdout] ... | [INFO] [stdout] 292 | | Ok(Some(file_name)) [INFO] [stdout] 293 | | })().transpose() [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/repo_db/conflict.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | Ok(RepoConflictSearcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | search_name: name, [INFO] [stdout] 41 | | search_path, [INFO] [stdout] 42 | | dirs, [INFO] [stdout] 43 | | iter: Box::new(repo_db.repos.iter()), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `NewRepoNameContainer` is never used [INFO] [stdout] --> src/bin/bb/cli.rs:292:11 [INFO] [stdout] | [INFO] [stdout] 292 | pub trait NewRepoNameContainer { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner.rs:86:13 [INFO] [stdout] | [INFO] [stdout] 86 | / path_buf [INFO] [stdout] 87 | | .file_name() [INFO] [stdout] 88 | | .with_context(|| anyhow!("no base name found for path {:?}", path))? [INFO] [stdout] 89 | | .to_str() [INFO] [stdout] 90 | | .context("base name is not UTF-8") [INFO] [stdout] 91 | | .and_then(|base_name| Ok(RepoName::from_str(base_name)?)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bellboy` (bin "bb" test) due to 12 previous errors; 1 warning emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner.rs:339:21 [INFO] [stdout] | [INFO] [stdout] 337 | let cmd_status = repo.run_cmd(cmd, |mut cmd| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 338 | log::debug!("running command {:?}", cmd); [INFO] [stdout] 339 | cmd.status().context("failed to spawn command") [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner.rs:374:70 [INFO] [stdout] | [INFO] [stdout] 374 | .map(|(name, repo)| (name.clone().into_static(), repo.short_desc().to_string())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:324:25 [INFO] [stdout] | [INFO] [stdout] 321 | .map_err(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | Some(anyhow::Error::new(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:392:58 [INFO] [stdout] | [INFO] [stdout] 392 | .map_err(|e| err("spawn command".into(), Some(anyhow::Error::new(e))))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:424:58 [INFO] [stdout] | [INFO] [stdout] 424 | .map_err(|e| err("spawn command".into(), Some(anyhow::Error::new(e))))?; [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:515:13 [INFO] [stdout] | [INFO] [stdout] 513 | let mut cmd = Command::new("git"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 514 | cmd.arg("ls-files").stderr(Stdio::inherit()); [INFO] [stdout] 515 | / (|| { [INFO] [stdout] 516 | | let cwd = current_dir()?; [INFO] [stdout] 517 | | [INFO] [stdout] 518 | | set_current_dir(&self.work_tree_path) [INFO] [stdout] ... | [INFO] [stdout] 544 | | })() [INFO] [stdout] 545 | | .map(|i| -> Box> { Box::new(i) }) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/git.rs:533:25 [INFO] [stdout] | [INFO] [stdout] 532 | .map(|l| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 533 | l.context("failed to read line from output") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/repo_db.rs:206:9 [INFO] [stdout] | [INFO] [stdout] 206 | git.open_repo(options) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/repo_db.rs:274:25 [INFO] [stdout] | [INFO] [stdout] 273 | entries.filter_map(|ent| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | / (|| -> anyhow::Result<_> { [INFO] [stdout] 275 | | let ent = ent.with_context(|| anyhow!("failed to read a dir entry in overlay repo path"))?; [INFO] [stdout] 276 | | [INFO] [stdout] 277 | | let file_name = ent.file_name(); [INFO] [stdout] ... | [INFO] [stdout] 292 | | Ok(Some(file_name)) [INFO] [stdout] 293 | | })().transpose() [INFO] [stdout] | |____________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/bb/runner/repo_db/conflict.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | Ok(RepoConflictSearcher { [INFO] [stdout] | ____________^ [INFO] [stdout] 40 | | search_name: name, [INFO] [stdout] 41 | | search_path, [INFO] [stdout] 42 | | dirs, [INFO] [stdout] 43 | | iter: Box::new(repo_db.repos.iter()), [INFO] [stdout] 44 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bellboy` (bin "bb") due to 12 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "af35bd97c5d56937c77e1e7938c9409f4f7f811358a8d4eaafa6a0c67d270a37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af35bd97c5d56937c77e1e7938c9409f4f7f811358a8d4eaafa6a0c67d270a37", kill_on_drop: false }` [INFO] [stdout] af35bd97c5d56937c77e1e7938c9409f4f7f811358a8d4eaafa6a0c67d270a37