[INFO] cloning repository https://github.com/EricCrosson/retry [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EricCrosson/retry" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEricCrosson%2Fretry", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEricCrosson%2Fretry'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7f7823c63358cac8f2f465c928e368e4ed2b88de [INFO] checking EricCrosson/retry/7f7823c63358cac8f2f465c928e368e4ed2b88de against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEricCrosson%2Fretry" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/EricCrosson/retry on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/EricCrosson/retry [INFO] finished tweaking git repo https://github.com/EricCrosson/retry [INFO] tweaked toml for git repo https://github.com/EricCrosson/retry written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/EricCrosson/retry already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6caeadcd53945f8d30ce75c75fad1cb92d7e0b66777f1f69bba6232e022c4bb0 [INFO] running `Command { std: "docker" "start" "-a" "6caeadcd53945f8d30ce75c75fad1cb92d7e0b66777f1f69bba6232e022c4bb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6caeadcd53945f8d30ce75c75fad1cb92d7e0b66777f1f69bba6232e022c4bb0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6caeadcd53945f8d30ce75c75fad1cb92d7e0b66777f1f69bba6232e022c4bb0", kill_on_drop: false }` [INFO] [stdout] 6caeadcd53945f8d30ce75c75fad1cb92d7e0b66777f1f69bba6232e022c4bb0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d25b0bb9a8fa9b46fdcce5d0c64035bcb1bfa060c43f83af46f95a82f1fa1a83 [INFO] running `Command { std: "docker" "start" "-a" "d25b0bb9a8fa9b46fdcce5d0c64035bcb1bfa060c43f83af46f95a82f1fa1a83", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.69 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling quote v1.0.26 [INFO] [stderr] Compiling rustix v0.38.25 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking linux-raw-sys v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking anstyle-parse v0.2.0 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking duration-string v0.4.0 [INFO] [stderr] Checking anstream v0.6.7 [INFO] [stderr] Compiling syn v2.0.8 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking retry v1.3.17 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decider.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 50 | fn new(retry_on_exit_codes: HashSet) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Self(retry_on_exit_codes.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:71:51 [INFO] [stdout] | [INFO] [stdout] 71 | .map_err(|err| create_err(ExecuteErrorKind::Spawn(err)))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:91:51 [INFO] [stdout] | [INFO] [stdout] 91 | .map_err(|err| create_err(ExecuteErrorKind::Spawn(err)))? [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/little_anyhow.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 69 | fn from(error: E) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Error(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn new(command: C, task_timeout: Option) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | command: command.into_iter().map(Into::into).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `retry` (bin "retry") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/decider.rs:51:14 [INFO] [stdout] | [INFO] [stdout] 50 | fn new(retry_on_exit_codes: HashSet) -> Self { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | Self(retry_on_exit_codes.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:71:51 [INFO] [stdout] | [INFO] [stdout] 71 | .map_err(|err| create_err(ExecuteErrorKind::Spawn(err)))?; [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/executor.rs:91:51 [INFO] [stdout] | [INFO] [stdout] 91 | .map_err(|err| create_err(ExecuteErrorKind::Spawn(err)))? [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/little_anyhow.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 69 | fn from(error: E) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | Error(Box::new(error)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/task.rs:22:22 [INFO] [stdout] | [INFO] [stdout] 16 | pub(crate) fn new(command: C, task_timeout: Option) -> Self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | command: command.into_iter().map(Into::into).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `retry` (bin "retry" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "d25b0bb9a8fa9b46fdcce5d0c64035bcb1bfa060c43f83af46f95a82f1fa1a83", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d25b0bb9a8fa9b46fdcce5d0c64035bcb1bfa060c43f83af46f95a82f1fa1a83", kill_on_drop: false }` [INFO] [stdout] d25b0bb9a8fa9b46fdcce5d0c64035bcb1bfa060c43f83af46f95a82f1fa1a83