[INFO] cloning repository https://github.com/EmmaLa/tokio-chat [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EmmaLa/tokio-chat" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmmaLa%2Ftokio-chat", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmmaLa%2Ftokio-chat'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bf17a85c54d53a88e8ceb4789897defe10667c70 [INFO] checking EmmaLa/tokio-chat/bf17a85c54d53a88e8ceb4789897defe10667c70 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEmmaLa%2Ftokio-chat" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/EmmaLa/tokio-chat on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/EmmaLa/tokio-chat [INFO] finished tweaking git repo https://github.com/EmmaLa/tokio-chat [INFO] tweaked toml for git repo https://github.com/EmmaLa/tokio-chat written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/EmmaLa/tokio-chat already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa7b19d4409d6106b71ed99a96879e2d1b93afb04c2efe44c793c40cf3ab55bc [INFO] running `Command { std: "docker" "start" "-a" "fa7b19d4409d6106b71ed99a96879e2d1b93afb04c2efe44c793c40cf3ab55bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa7b19d4409d6106b71ed99a96879e2d1b93afb04c2efe44c793c40cf3ab55bc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa7b19d4409d6106b71ed99a96879e2d1b93afb04c2efe44c793c40cf3ab55bc", kill_on_drop: false }` [INFO] [stdout] fa7b19d4409d6106b71ed99a96879e2d1b93afb04c2efe44c793c40cf3ab55bc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1549bb0920c1607760b39e39b36ad8fd6b9c24a424523edd632afc0907a6235 [INFO] running `Command { std: "docker" "start" "-a" "c1549bb0920c1607760b39e39b36ad8fd6b9c24a424523edd632afc0907a6235", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking libc v0.2.36 [INFO] [stderr] Checking cfg-if v0.1.2 [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Checking slab v0.3.0 [INFO] [stderr] Checking futures v0.1.18 [INFO] [stderr] Checking lazycell v0.6.0 [INFO] [stderr] Checking slab v0.4.0 [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking net2 v0.2.31 [INFO] [stderr] Checking bytes v0.4.6 [INFO] [stderr] Checking mio v0.6.13 [INFO] [stderr] Checking tokio-io v0.1.5 [INFO] [stderr] Checking tokio v0.1.1 [INFO] [stderr] Checking tokio-chat v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `AsyncWrite` [INFO] [stdout] --> src/main.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | use tokio_io::{ AsyncRead, AsyncWrite}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/main.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | use std::io::{Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/main.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsyncWrite` [INFO] [stdout] --> src/main.rs:9:28 [INFO] [stdout] | [INFO] [stdout] 9 | use tokio_io::{ AsyncRead, AsyncWrite}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/main.rs:16:15 [INFO] [stdout] | [INFO] [stdout] 16 | use std::io::{Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Arc` [INFO] [stdout] --> src/main.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | use std::sync::Arc; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Mutex` [INFO] [stdout] --> src/main.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use std::sync::Mutex; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::sync::Mutex` [INFO] [stdout] --> src/main.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | use std::sync::Mutex; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | let mut chuck_data = chunk_data.for_each(move |data| { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Rx` is never used [INFO] [stdout] --> src/main.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | type Rx = mpsc::UnboundedReceiver; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/main.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 34 | struct ChunkData{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 37 | state: Rc> [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 41 | fn new(socket: io::ReadHalf, state: Rc>) -> Self { [INFO] [stdout] | ------------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | buffer: BytesMut::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:131:25 [INFO] [stdout] | [INFO] [stdout] 93 | let listener = TcpListener::bind(&adress).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let shared_state: Rc> = Rc::new(RefCell::new(HashMap::new())); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let server = listener.incoming().for_each(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | current_thread::run(|_| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 132 | | current_thread::spawn(server); [INFO] [stdout] 133 | | println!("Server running on port 10000"); [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:119:13 [INFO] [stdout] | [INFO] [stdout] 119 | let mut chuck_data = chunk_data.for_each(move |data| { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type alias `Rx` is never used [INFO] [stdout] --> src/main.rs:28:6 [INFO] [stdout] | [INFO] [stdout] 28 | type Rx = mpsc::UnboundedReceiver; [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `state` is never read [INFO] [stdout] --> src/main.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 34 | struct ChunkData{ [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 37 | state: Rc> [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:44:21 [INFO] [stdout] | [INFO] [stdout] 41 | fn new(socket: io::ReadHalf, state: Rc>) -> Self { [INFO] [stdout] | ------------------------------- ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | buffer: BytesMut::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 107 | let client_resolve_future = recv_for_client_sending.fold(sock_writer, |sock_writer, bytes_received_to_send| { [INFO] [stdout] | ----------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | / io::write_all(sock_writer, bytes_received_to_send) [INFO] [stdout] 109 | | .map(|(writer, _bytes)| writer) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:131:25 [INFO] [stdout] | [INFO] [stdout] 93 | let listener = TcpListener::bind(&adress).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | let shared_state: Rc> = Rc::new(RefCell::new(HashMap::new())); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let server = listener.incoming().for_each(move |socket| { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | current_thread::run(|_| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 132 | | current_thread::spawn(server); [INFO] [stdout] 133 | | println!("Server running on port 10000"); [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 107 | let client_resolve_future = recv_for_client_sending.fold(sock_writer, |sock_writer, bytes_received_to_send| { [INFO] [stdout] | ----------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | / io::write_all(sock_writer, bytes_received_to_send) [INFO] [stdout] 109 | | .map(|(writer, _bytes)| writer) [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tokio-chat` (bin "tokio-chat") due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `tokio-chat` (bin "tokio-chat" test) due to 4 previous errors; 7 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c1549bb0920c1607760b39e39b36ad8fd6b9c24a424523edd632afc0907a6235", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1549bb0920c1607760b39e39b36ad8fd6b9c24a424523edd632afc0907a6235", kill_on_drop: false }` [INFO] [stdout] c1549bb0920c1607760b39e39b36ad8fd6b9c24a424523edd632afc0907a6235