[INFO] cloning repository https://github.com/Ell/grflib [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Ell/grflib" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEll%2Fgrflib", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEll%2Fgrflib'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 937969abdfa30588517edb5d83c2602e8b0f3b08 [INFO] checking Ell/grflib/937969abdfa30588517edb5d83c2602e8b0f3b08 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEll%2Fgrflib" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Ell/grflib on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Ell/grflib [INFO] finished tweaking git repo https://github.com/Ell/grflib [INFO] tweaked toml for git repo https://github.com/Ell/grflib written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Ell/grflib already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 758e397471f6c1ae021bbb840cc8364c9567aeb5ffe3f712bd0bd11660013606 [INFO] running `Command { std: "docker" "start" "-a" "758e397471f6c1ae021bbb840cc8364c9567aeb5ffe3f712bd0bd11660013606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "758e397471f6c1ae021bbb840cc8364c9567aeb5ffe3f712bd0bd11660013606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "758e397471f6c1ae021bbb840cc8364c9567aeb5ffe3f712bd0bd11660013606", kill_on_drop: false }` [INFO] [stdout] 758e397471f6c1ae021bbb840cc8364c9567aeb5ffe3f712bd0bd11660013606 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ddfcb995c615c25bd25bc221de1ae10f47f89dc9c92ff439a7c4c2a985ee9e9b [INFO] running `Command { std: "docker" "start" "-a" "ddfcb995c615c25bd25bc221de1ae10f47f89dc9c92ff439a7c4c2a985ee9e9b", kill_on_drop: false }` [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling anyhow v1.0.69 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking miniz_oxide v0.6.2 [INFO] [stderr] Checking flate2 v1.0.25 [INFO] [stderr] Checking grflib v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/des.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | let mut tmp: &mut [u8] = &mut [0; 8]; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/des.rs:106:9 [INFO] [stdout] | [INFO] [stdout] 106 | let mut tmp: &mut [u8] = &mut [0; 8]; [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `magic`, `key`, `seed`, and `version` are never read [INFO] [stdout] --> src/lib.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 48 | pub magic: [u8; 15], [INFO] [stdout] | ^^^^^ [INFO] [stdout] 49 | pub key: [u8; 15], [INFO] [stdout] | ^^^ [INFO] [stdout] 50 | pub file_table_offset: u32, [INFO] [stdout] 51 | pub seed: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 52 | pub file_count: u32, [INFO] [stdout] 53 | pub version: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/lib.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 57 | struct Entry { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 58 | pub path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Entry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `magic`, `key`, `seed`, and `version` are never read [INFO] [stdout] --> src/lib.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | struct Header { [INFO] [stdout] | ------ fields in this struct [INFO] [stdout] 48 | pub magic: [u8; 15], [INFO] [stdout] | ^^^^^ [INFO] [stdout] 49 | pub key: [u8; 15], [INFO] [stdout] | ^^^ [INFO] [stdout] 50 | pub file_table_offset: u32, [INFO] [stdout] 51 | pub seed: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 52 | pub file_count: u32, [INFO] [stdout] 53 | pub version: u32, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Header` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/lib.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 57 | struct Entry { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 58 | pub path: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Entry` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `size_packed` and `size` are never read [INFO] [stdout] --> src/lib.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | struct EntryTable { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 68 | pub size_packed: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 69 | pub size: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EntryTable` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `header` is never read [INFO] [stdout] --> src/lib.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct Archive { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 75 | file: R, [INFO] [stdout] 76 | header: Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Archive` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn from_reader(mut reader: F) -> Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | file: reader, [INFO] [stdout] 94 | | header, [INFO] [stdout] 95 | | entry_table, [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `size_packed` and `size` are never read [INFO] [stdout] --> src/lib.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 67 | struct EntryTable { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 68 | pub size_packed: u32, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 69 | pub size: u32, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `EntryTable` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `header` is never read [INFO] [stdout] --> src/lib.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct Archive { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 75 | file: R, [INFO] [stdout] 76 | header: Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Archive` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn from_reader(mut reader: F) -> Result> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | Ok(Archive { [INFO] [stdout] | ____________^ [INFO] [stdout] 93 | | file: reader, [INFO] [stdout] 94 | | header, [INFO] [stdout] 95 | | entry_table, [INFO] [stdout] 96 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `grflib` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `grflib` (lib) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ddfcb995c615c25bd25bc221de1ae10f47f89dc9c92ff439a7c4c2a985ee9e9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddfcb995c615c25bd25bc221de1ae10f47f89dc9c92ff439a7c4c2a985ee9e9b", kill_on_drop: false }` [INFO] [stdout] ddfcb995c615c25bd25bc221de1ae10f47f89dc9c92ff439a7c4c2a985ee9e9b