[INFO] cloning repository https://github.com/EduardovEduard/RaytracingRust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EduardovEduard/RaytracingRust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEduardovEduard%2FRaytracingRust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEduardovEduard%2FRaytracingRust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bcb1e857e4efc944a03cc346b919d37dfd33daca [INFO] checking EduardovEduard/RaytracingRust/bcb1e857e4efc944a03cc346b919d37dfd33daca against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEduardovEduard%2FRaytracingRust" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/EduardovEduard/RaytracingRust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/EduardovEduard/RaytracingRust [INFO] finished tweaking git repo https://github.com/EduardovEduard/RaytracingRust [INFO] tweaked toml for git repo https://github.com/EduardovEduard/RaytracingRust written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/EduardovEduard/RaytracingRust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 068fca257fe4e7206b54313ee7e811e9cf00ba9884db899ae3722c1b0e351ce4 [INFO] running `Command { std: "docker" "start" "-a" "068fca257fe4e7206b54313ee7e811e9cf00ba9884db899ae3722c1b0e351ce4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "068fca257fe4e7206b54313ee7e811e9cf00ba9884db899ae3722c1b0e351ce4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "068fca257fe4e7206b54313ee7e811e9cf00ba9884db899ae3722c1b0e351ce4", kill_on_drop: false }` [INFO] [stdout] 068fca257fe4e7206b54313ee7e811e9cf00ba9884db899ae3722c1b0e351ce4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5cb32cf65c382f75f64e35d9bb40952de0e38b09df24a449efc5d3a2a9b05c40 [INFO] running `Command { std: "docker" "start" "-a" "5cb32cf65c382f75f64e35d9bb40952de0e38b09df24a449efc5d3a2a9b05c40", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking bytemuck v1.14.3 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking wide v0.7.15 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.8.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking simba v0.8.1 [INFO] [stderr] Compiling nalgebra-macros v0.2.1 [INFO] [stderr] Checking nalgebra v0.32.3 [INFO] [stderr] Checking raytracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `assert_relative_eq` and `relative_eq` [INFO] [stdout] --> src/main.rs:178:18 [INFO] [stdout] | [INFO] [stdout] 178 | use approx::{assert_relative_eq, relative_eq}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Vector3` and `vector` [INFO] [stdout] --> src/main.rs:179:14 [INFO] [stdout] | [INFO] [stdout] 179 | use na::{vector, Vector3}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::rand_unit_vector` [INFO] [stdout] --> src/main.rs:180:9 [INFO] [stdout] | [INFO] [stdout] 180 | use crate::utils::rand_unit_vector; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `counter` [INFO] [stdout] --> src/camera.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | let counter = AtomicUsize::new(0); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_counter` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `counter` [INFO] [stdout] --> src/camera.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | let counter = AtomicUsize::new(0); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_counter` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setup_scene` is never used [INFO] [stdout] --> src/main.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | fn setup_scene() -> Scene { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setup_scene` is never used [INFO] [stdout] --> src/main.rs:54:4 [INFO] [stdout] | [INFO] [stdout] 54 | fn setup_scene() -> Scene { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setup_scene2` is never used [INFO] [stdout] --> src/main.rs:84:4 [INFO] [stdout] | [INFO] [stdout] 84 | fn setup_scene2() -> Scene { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `width` and `height` are never used [INFO] [stdout] --> src/image.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Image { [INFO] [stdout] | ----- methods in this trait [INFO] [stdout] 6 | fn width(&self) -> usize; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | fn height(&self) -> usize; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `clear` is never used [INFO] [stdout] --> src/scene.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 65 | impl Scene { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 74 | pub fn clear(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rand_on_hemisphere` is never used [INFO] [stdout] --> src/utils.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn rand_on_hemisphere(normal: &Vector3) -> Vector3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Pixel` is never constructed [INFO] [stdout] --> src/camera.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct Pixel { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Pixel` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `render` is never used [INFO] [stdout] --> src/camera.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl Camera { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn render(&mut self, scene: &Scene) -> Box { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R` should have a snake case name [INFO] [stdout] --> src/main.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | let R = (PI / 4.0).cos(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/camera.rs:33:64 [INFO] [stdout] | [INFO] [stdout] 32 | let s = scene.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | (0..self.render_width).clone().into_par_iter().map(move |j| { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 34 | | let mut sample_result = Vector3::::zeros(); [INFO] [stdout] 35 | | for _ in 0..self.samples_per_pixel { [INFO] [stdout] 36 | | let ray = self.camera.sample_ray(i, j); [INFO] [stdout] ... | [INFO] [stdout] 41 | | RGB::from(sample_result) [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `setup_scene2` is never used [INFO] [stdout] --> src/main.rs:84:4 [INFO] [stdout] | [INFO] [stdout] 84 | fn setup_scene2() -> Scene { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `width` and `height` are never used [INFO] [stdout] --> src/image.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Image { [INFO] [stdout] | ----- methods in this trait [INFO] [stdout] 6 | fn width(&self) -> usize; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 7 | fn height(&self) -> usize; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `clear` is never used [INFO] [stdout] --> src/scene.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 65 | impl Scene { [INFO] [stdout] | ---------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 74 | pub fn clear(&mut self) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `rand_on_hemisphere` is never used [INFO] [stdout] --> src/utils.rs:41:8 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn rand_on_hemisphere(normal: &Vector3) -> Vector3 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Pixel` is never constructed [INFO] [stdout] --> src/camera.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 12 | struct Pixel { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Pixel` has a derived impl for the trait `Default`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `render` is never used [INFO] [stdout] --> src/camera.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl Camera { [INFO] [stdout] | ----------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 123 | pub fn render(&mut self, scene: &Scene) -> Box { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `R` should have a snake case name [INFO] [stdout] --> src/main.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | let R = (PI / 4.0).cos(); [INFO] [stdout] | ^ help: convert the identifier to snake case: `r` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/camera.rs:33:64 [INFO] [stdout] | [INFO] [stdout] 32 | let s = scene.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | (0..self.render_width).clone().into_par_iter().map(move |j| { [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] 34 | | let mut sample_result = Vector3::::zeros(); [INFO] [stdout] 35 | | for _ in 0..self.samples_per_pixel { [INFO] [stdout] 36 | | let ray = self.camera.sample_ray(i, j); [INFO] [stdout] ... | [INFO] [stdout] 41 | | RGB::from(sample_result) [INFO] [stdout] 42 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 12 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `raytracer` (bin "raytracer") due to 2 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `raytracer` (bin "raytracer" test) due to 2 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5cb32cf65c382f75f64e35d9bb40952de0e38b09df24a449efc5d3a2a9b05c40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5cb32cf65c382f75f64e35d9bb40952de0e38b09df24a449efc5d3a2a9b05c40", kill_on_drop: false }` [INFO] [stdout] 5cb32cf65c382f75f64e35d9bb40952de0e38b09df24a449efc5d3a2a9b05c40