[INFO] cloning repository https://github.com/EdMcBane/rustyworld [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EdMcBane/rustyworld" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdMcBane%2Frustyworld", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdMcBane%2Frustyworld'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2e9a5ab1ba800b625ef1a9f90863d31126e6f8fb [INFO] checking EdMcBane/rustyworld/2e9a5ab1ba800b625ef1a9f90863d31126e6f8fb against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdMcBane%2Frustyworld" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/EdMcBane/rustyworld on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/EdMcBane/rustyworld [INFO] finished tweaking git repo https://github.com/EdMcBane/rustyworld [INFO] tweaked toml for git repo https://github.com/EdMcBane/rustyworld written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/EdMcBane/rustyworld already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad228c957a2a4047f1adf02c4c8410b95f571b6443bfaf9de5193cb67a03a37c [INFO] running `Command { std: "docker" "start" "-a" "ad228c957a2a4047f1adf02c4c8410b95f571b6443bfaf9de5193cb67a03a37c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad228c957a2a4047f1adf02c4c8410b95f571b6443bfaf9de5193cb67a03a37c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad228c957a2a4047f1adf02c4c8410b95f571b6443bfaf9de5193cb67a03a37c", kill_on_drop: false }` [INFO] [stdout] ad228c957a2a4047f1adf02c4c8410b95f571b6443bfaf9de5193cb67a03a37c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3727ef6d3d83146fc9a4204bb0d2a84b817c1f4273721eaae5bf5e0fe0b1ad92 [INFO] running `Command { std: "docker" "start" "-a" "3727ef6d3d83146fc9a4204bb0d2a84b817c1f4273721eaae5bf5e0fe0b1ad92", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling unicode-width v0.1.11 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling nom v5.1.3 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling libloading v0.8.3 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling bindgen v0.56.0 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Compiling clang-sys v1.7.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling wayland-sys v0.28.6 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling x11-dl v2.21.0 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Checking cty v0.2.2 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling cpal v0.13.5 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking raw-window-handle v0.4.3 [INFO] [stderr] Checking xcursor v0.3.5 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Compiling wayland-scanner v0.28.6 [INFO] [stderr] Compiling syn v2.0.53 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking nix v0.20.0 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking raw-window-handle v0.3.4 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling jobserver v0.1.28 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Compiling cexpr v0.4.0 [INFO] [stderr] Compiling wayland-client v0.28.6 [INFO] [stderr] Compiling wayland-protocols v0.28.6 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking num v0.4.1 [INFO] [stderr] Compiling minifb v0.19.3 [INFO] [stderr] Checking wayland-commons v0.28.6 [INFO] [stderr] Checking alsa v0.6.0 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling env_logger v0.8.4 [INFO] [stderr] Compiling arr_macro_impl v0.1.3 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking arr_macro v0.1.3 [INFO] [stderr] Checking wayland-cursor v0.28.6 [INFO] [stderr] Checking rodio v0.14.0 [INFO] [stderr] Compiling xkbcommon-sys v0.7.5 [INFO] [stderr] Checking xkb v0.2.1 [INFO] [stderr] Checking rustyworld v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 131 | fn map_input(inputs: HashSet) -> HashSet { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | / inputs.into_iter().map(|i| match i { [INFO] [stdout] 133 | | Input::UP => VmInput::UP, [INFO] [stdout] 134 | | Input::DOWN => VmInput::DOWN, [INFO] [stdout] 135 | | Input::LEFT => VmInput::LEFT, [INFO] [stdout] 136 | | Input::RIGHT => VmInput::RIGHT, [INFO] [stdout] 137 | | Input::BUTTON => VmInput::BUTTON, [INFO] [stdout] 138 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/vm.rs:372:23 [INFO] [stdout] | [INFO] [stdout] 372 | for res_id in &part.video2_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 372 | while let Some(res_id) = &part.video2_id { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 372 | if let Some(res_id) = &part.video2_id { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/music.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn iter_chan<'a>(self: Arc, channel: usize) -> BeatIter { // TODO: tinytypes [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | BeatIter { [INFO] [stdout] 163 | module: self.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minifb.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(window: Window) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self::sharing_window(Rc::new(RefCell::new(window))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minifb.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(window: Window) -> Self{ [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | MiniInputDevice { [INFO] [stdout] 57 | window: Rc::new(RefCell::new(window)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minifb.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 75 | .filter(|(_, k)| (*self.window).borrow().is_key_down(*k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rodio.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 108 | fn new(channel: usize, speed_up: usize, beat_interval_ms: Arc, sender: mpsc::Sender, module: Arc) -> Self { [INFO] [stdout] | ---------------------------------- ------------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | module: module.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rodio.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 108 | fn new(channel: usize, speed_up: usize, beat_interval_ms: Arc, sender: mpsc::Sender, module: Arc) -> Self { [INFO] [stdout] | ---------------------------------- ------------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | beats: module.iter_chan(channel), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rodio.rs:232:31 [INFO] [stdout] | [INFO] [stdout] 219 | let (os, stream_handle) = OutputStream::try_default().unwrap(); [INFO] [stdout] | -- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let channels = [ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let (tx, rx) = mpsc::channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | beat_interval_ms: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustyworld` (lib) due to 9 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:132:5 [INFO] [stdout] | [INFO] [stdout] 131 | fn map_input(inputs: HashSet) -> HashSet { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | / inputs.into_iter().map(|i| match i { [INFO] [stdout] 133 | | Input::UP => VmInput::UP, [INFO] [stdout] 134 | | Input::DOWN => VmInput::DOWN, [INFO] [stdout] 135 | | Input::LEFT => VmInput::LEFT, [INFO] [stdout] 136 | | Input::RIGHT => VmInput::RIGHT, [INFO] [stdout] 137 | | Input::BUTTON => VmInput::BUTTON, [INFO] [stdout] 138 | | }).collect() [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/vm.rs:372:23 [INFO] [stdout] | [INFO] [stdout] 372 | for res_id in &part.video2_id { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 372 | while let Some(res_id) = &part.video2_id { [INFO] [stdout] | ~~~~~~~~~~~~~~~ ~~~ [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 372 | if let Some(res_id) = &part.video2_id { [INFO] [stdout] | ~~~~~~~~~~~~ ~~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/music.rs:163:21 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn iter_chan<'a>(self: Arc, channel: usize) -> BeatIter { // TODO: tinytypes [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | BeatIter { [INFO] [stdout] 163 | module: self.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minifb.rs:18:30 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(window: Window) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | Self::sharing_window(Rc::new(RefCell::new(window))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minifb.rs:57:21 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(window: Window) -> Self{ [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | MiniInputDevice { [INFO] [stdout] 57 | window: Rc::new(RefCell::new(window)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/minifb.rs:75:30 [INFO] [stdout] | [INFO] [stdout] 75 | .filter(|(_, k)| (*self.window).borrow().is_key_down(*k)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rodio.rs:116:21 [INFO] [stdout] | [INFO] [stdout] 108 | fn new(channel: usize, speed_up: usize, beat_interval_ms: Arc, sender: mpsc::Sender, module: Arc) -> Self { [INFO] [stdout] | ---------------------------------- ------------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | module: module.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rodio.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 108 | fn new(channel: usize, speed_up: usize, beat_interval_ms: Arc, sender: mpsc::Sender, module: Arc) -> Self { [INFO] [stdout] | ---------------------------------- ------------------------- ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | beats: module.iter_chan(channel), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rodio.rs:232:31 [INFO] [stdout] | [INFO] [stdout] 219 | let (os, stream_handle) = OutputStream::try_default().unwrap(); [INFO] [stdout] | -- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | let channels = [ [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 226 | let (tx, rx) = mpsc::channel::(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | beat_interval_ms: Arc::new(AtomicUsize::new(0)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustyworld` (lib test) due to 9 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3727ef6d3d83146fc9a4204bb0d2a84b817c1f4273721eaae5bf5e0fe0b1ad92", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3727ef6d3d83146fc9a4204bb0d2a84b817c1f4273721eaae5bf5e0fe0b1ad92", kill_on_drop: false }` [INFO] [stdout] 3727ef6d3d83146fc9a4204bb0d2a84b817c1f4273721eaae5bf5e0fe0b1ad92