[INFO] cloning repository https://github.com/EcomDev/csrf-cookie-token-generator [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EcomDev/csrf-cookie-token-generator" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEcomDev%2Fcsrf-cookie-token-generator", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEcomDev%2Fcsrf-cookie-token-generator'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b41fa20f7b2fcb63b07f0e7c4a29bf0214e0b1df [INFO] checking EcomDev/csrf-cookie-token-generator/b41fa20f7b2fcb63b07f0e7c4a29bf0214e0b1df against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEcomDev%2Fcsrf-cookie-token-generator" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/EcomDev/csrf-cookie-token-generator on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/EcomDev/csrf-cookie-token-generator [INFO] finished tweaking git repo https://github.com/EcomDev/csrf-cookie-token-generator [INFO] tweaked toml for git repo https://github.com/EcomDev/csrf-cookie-token-generator written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/EcomDev/csrf-cookie-token-generator already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59b521184b89e3a2819ce7046ab96989b83d6b2536c04adc77341da20784b58f [INFO] running `Command { std: "docker" "start" "-a" "59b521184b89e3a2819ce7046ab96989b83d6b2536c04adc77341da20784b58f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59b521184b89e3a2819ce7046ab96989b83d6b2536c04adc77341da20784b58f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59b521184b89e3a2819ce7046ab96989b83d6b2536c04adc77341da20784b58f", kill_on_drop: false }` [INFO] [stdout] 59b521184b89e3a2819ce7046ab96989b83d6b2536c04adc77341da20784b58f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e584e3a9ad31a3db85695ebcfcbfa0957c5314d56ca9096c060eafc358e52a3 [INFO] running `Command { std: "docker" "start" "-a" "2e584e3a9ad31a3db85695ebcfcbfa0957c5314d56ca9096c060eafc358e52a3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.6 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking fnv v1.0.6 [INFO] [stderr] Checking tokio-executor v0.1.8 [INFO] [stderr] Compiling proc-macro2 v1.0.3 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Checking stable_deref_trait v1.1.1 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking owning_ref v0.4.0 [INFO] [stderr] Compiling getrandom v0.1.12 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking lock_api v0.1.5 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking tokio-sync v0.1.6 [INFO] [stderr] Checking iovec v0.1.2 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Compiling parking_lot_core v0.4.0 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking net2 v0.2.33 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking tokio-io v0.1.12 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking http v0.1.18 [INFO] [stderr] Checking mio v0.6.19 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling serde v1.0.100 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Compiling unicode-segmentation v1.3.0 [INFO] [stderr] Checking parking_lot v0.7.1 [INFO] [stderr] Checking tokio-threadpool v0.1.15 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking tokio-reactor v0.1.9 [INFO] [stderr] Checking string v0.2.1 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking tokio-buf v0.1.1 [INFO] [stderr] Compiling hyper v0.12.34 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking tokio-current-thread v0.1.6 [INFO] [stderr] Checking tokio-timer v0.2.11 [INFO] [stderr] Checking indexmap v1.2.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking try-lock v0.2.2 [INFO] [stderr] Checking want v0.2.0 [INFO] [stderr] Checking tokio-tcp v0.1.3 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking rand_pcg v0.2.0 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking cookie v0.12.0 [INFO] [stderr] Checking md5 v0.6.1 [INFO] [stderr] Checking h2 v0.1.26 [INFO] [stderr] Checking http-body v0.1.0 [INFO] [stderr] Compiling proc-macro-error v0.2.6 [INFO] [stderr] Compiling structopt-derive v0.3.1 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking structopt v0.3.1 [INFO] [stderr] Checking csrf-cookie-token v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_handler.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn serve(&mut self, req: Request) -> Response { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let default_domain = HeaderValue::from_str(&self.cookie_domain).unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | / Response::builder() [INFO] [stdout] 89 | | .header( [INFO] [stdout] 90 | | SET_COOKIE, [INFO] [stdout] 91 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 106 | | ) [INFO] [stdout] 107 | | .body(Body::from(r#"{"status":"ok"}"#)).unwrap() [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_handler.rs:132:20 [INFO] [stdout] | [INFO] [stdout] 131 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | future::ok(self.serve(req)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csrf-cookie-token` (bin "csrf-cookie-token") due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_handler.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn serve(&mut self, req: Request) -> Response { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | let default_domain = HeaderValue::from_str(&self.cookie_domain).unwrap(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | / Response::builder() [INFO] [stdout] 89 | | .header( [INFO] [stdout] 90 | | SET_COOKIE, [INFO] [stdout] 91 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 106 | | ) [INFO] [stdout] 107 | | .body(Body::from(r#"{"status":"ok"}"#)).unwrap() [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_handler.rs:132:20 [INFO] [stdout] | [INFO] [stdout] 131 | fn call(&mut self, req: Request) -> Self::Future { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | future::ok(self.serve(req)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_handler.rs:165:42 [INFO] [stdout] | [INFO] [stdout] 160 | let body = request_page( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | assert_eq!(r#"{"status":"ok"}"#, body.into_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http_handler.rs:221:15 [INFO] [stdout] | [INFO] [stdout] 220 | fn request_page(responder: &mut Http, request: Request) -> Response { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 221 | match responder.call( [INFO] [stdout] | _______________^ [INFO] [stdout] 222 | | request [INFO] [stdout] 223 | | ).poll().unwrap() { [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `csrf-cookie-token` (bin "csrf-cookie-token" test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "2e584e3a9ad31a3db85695ebcfcbfa0957c5314d56ca9096c060eafc358e52a3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e584e3a9ad31a3db85695ebcfcbfa0957c5314d56ca9096c060eafc358e52a3", kill_on_drop: false }` [INFO] [stdout] 2e584e3a9ad31a3db85695ebcfcbfa0957c5314d56ca9096c060eafc358e52a3