[INFO] cloning repository https://github.com/ECUsam/kv [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ECUsam/kv" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FECUsam%2Fkv", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FECUsam%2Fkv'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] fa0c827070dfb258723065fd4fb4c75aa0a84246 [INFO] checking ECUsam/kv/fa0c827070dfb258723065fd4fb4c75aa0a84246 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FECUsam%2Fkv" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ECUsam/kv on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ECUsam/kv [INFO] finished tweaking git repo https://github.com/ECUsam/kv [INFO] tweaked toml for git repo https://github.com/ECUsam/kv written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ECUsam/kv already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 221029ee12c2108632c2f393a05d1ab9ef23a57821b91eb3ebdbb62361b34660 [INFO] running `Command { std: "docker" "start" "-a" "221029ee12c2108632c2f393a05d1ab9ef23a57821b91eb3ebdbb62361b34660", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "221029ee12c2108632c2f393a05d1ab9ef23a57821b91eb3ebdbb62361b34660", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "221029ee12c2108632c2f393a05d1ab9ef23a57821b91eb3ebdbb62361b34660", kill_on_drop: false }` [INFO] [stdout] 221029ee12c2108632c2f393a05d1ab9ef23a57821b91eb3ebdbb62361b34660 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 869483c10b710dc7ecb4d8fabf54c3fe9e05f4f9563540db95744d8235181e65 [INFO] running `Command { std: "docker" "start" "-a" "869483c10b710dc7ecb4d8fabf54c3fe9e05f4f9563540db95744d8235181e65", kill_on_drop: false }` [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling hashbrown v0.12.3 [INFO] [stderr] Compiling bytes v1.6.1 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling fastrand v2.1.0 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling fixedbitset v0.2.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling log v0.4.22 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Compiling petgraph v0.5.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking dashmap v6.0.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling prost-derive v0.8.0 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Compiling prost-build v0.8.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling prost v0.8.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling prost-types v0.8.0 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling kv v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: named argument `field__1` is not used by name [INFO] [stdout] --> src/error.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | #[error("cannot convert {:0} to {1}")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this named argument is referred to by position in formatting string [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(named_arguments_used_positionally)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: named argument `field__0` is not used by name [INFO] [stdout] --> src/error.rs:12:13 [INFO] [stdout] | [INFO] [stdout] 12 | #[error("cannot process command {0} with table: {1}, key: {2}, error: {}")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this named argument is referred to by position in formatting string [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `pb::abi::*` [INFO] [stdout] --> src/lib.rs:8:9 [INFO] [stdout] | [INFO] [stdout] 8 | pub use pb::abi::*; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb/mod.rs:11:27 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new_hset(table: impl Into, key: impl Into, value: Value) -> Self{ [INFO] [stdout] | ------------------------ ---------------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | Self{ [INFO] [stdout] 11 | request_data: Some(RequestData::Hset(Hset{ [INFO] [stdout] | ___________________________^ [INFO] [stdout] 12 | | table: table.into(), [INFO] [stdout] 13 | | pair: Some(Kvpair::new(key, value)), [INFO] [stdout] 14 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb/mod.rs:19:30 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new_hget(table: impl Into, key: impl Into) -> Self{ [INFO] [stdout] | ------------------------ ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | Self { request_data: Some(RequestData::Hget(Hget { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 20 | | table: table.into(), [INFO] [stdout] 21 | | key: key.into()})) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb/mod.rs:27:27 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new_hgetall(table: impl Into) -> Self{ [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self{ [INFO] [stdout] 27 | request_data: Some(RequestData::Hgetall(Hgetall { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 28 | | table: table.into(), [INFO] [stdout] 29 | | })) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb/mod.rs:39:20 [INFO] [stdout] | [INFO] [stdout] 36 | pub fn new(key: impl Into, value: Value) -> Self{ [INFO] [stdout] | ---------------------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | value: Some(value), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb/mod.rs:75:15 [INFO] [stdout] | [INFO] [stdout] 71 | fn from(v: Value) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pb/mod.rs:86:15 [INFO] [stdout] | [INFO] [stdout] 82 | fn from(v: Vec) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/memory.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 29 | let table = self.get_or_create_table(table); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | Ok(table.get(key).map(|v| v.value().clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/memory.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 33 | fn set(&self, table: &str, key: String, value: Value) -> Result, KvError> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | let table = self.get_or_create_table(table); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | Ok(table.insert(key, value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/memory.rs:45:12 [INFO] [stdout] | [INFO] [stdout] 44 | let table = self.get_or_create_table(table); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | Ok(table.remove(key).map(|(_k, v)| v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/memory.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 49 | let table = self.get_or_create_table(table); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Ok(table [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | .iter() [INFO] [stdout] 52 | | .map(|v| Kvpair::new(v.key(), v.value().clone())) [INFO] [stdout] 53 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/storage/memory.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | .map(|v| Kvpair::new(v.key(), v.value().clone())) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/service/mod.rs:35:20 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn new(store: Store) -> Self{ [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | Self{ [INFO] [stdout] 35 | inner: Arc::new(ServiceInner{store}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `kv` (lib) due to 13 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "869483c10b710dc7ecb4d8fabf54c3fe9e05f4f9563540db95744d8235181e65", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "869483c10b710dc7ecb4d8fabf54c3fe9e05f4f9563540db95744d8235181e65", kill_on_drop: false }` [INFO] [stdout] 869483c10b710dc7ecb4d8fabf54c3fe9e05f4f9563540db95744d8235181e65