[INFO] cloning repository https://github.com/E314c/rusty-craft [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/E314c/rusty-craft" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FE314c%2Frusty-craft", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FE314c%2Frusty-craft'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e6a1e578b55c9f717a1893f6865d5c7baf2999d9 [INFO] checking E314c/rusty-craft/e6a1e578b55c9f717a1893f6865d5c7baf2999d9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FE314c%2Frusty-craft" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/E314c/rusty-craft on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/E314c/rusty-craft [INFO] finished tweaking git repo https://github.com/E314c/rusty-craft [INFO] tweaked toml for git repo https://github.com/E314c/rusty-craft written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/E314c/rusty-craft already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7e4a9797d9e146f427af7c589c5372ddfa052ff934549e8ba452cb4c830a4316 [INFO] running `Command { std: "docker" "start" "-a" "7e4a9797d9e146f427af7c589c5372ddfa052ff934549e8ba452cb4c830a4316", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7e4a9797d9e146f427af7c589c5372ddfa052ff934549e8ba452cb4c830a4316", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7e4a9797d9e146f427af7c589c5372ddfa052ff934549e8ba452cb4c830a4316", kill_on_drop: false }` [INFO] [stdout] 7e4a9797d9e146f427af7c589c5372ddfa052ff934549e8ba452cb4c830a4316 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0cd63a0ae373bfdafd9b6915707c8ceb1b8b95bf4501a9a9cfd1c4d45fa3b980 [INFO] running `Command { std: "docker" "start" "-a" "0cd63a0ae373bfdafd9b6915707c8ceb1b8b95bf4501a9a9cfd1c4d45fa3b980", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling libc v0.2.65 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling arrayvec v0.4.12 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Checking nodrop v0.1.14 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Compiling sdl2-sys v0.32.6 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling rayon-core v1.6.0 [INFO] [stderr] Compiling memoffset v0.5.2 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Compiling xml-rs v0.8.0 [INFO] [stderr] Compiling typenum v1.11.2 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling libm v0.1.4 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Compiling same-file v1.0.5 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling num-complex v0.2.3 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stderr] Checking c2-chacha v0.2.3 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Compiling walkdir v2.2.9 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Compiling sdl2 v0.32.2 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking crossbeam-deque v0.7.1 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking matrixmultiply v0.2.3 [INFO] [stderr] Checking gif v0.10.3 [INFO] [stderr] Compiling rusty-craft v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking num_cpus v1.11.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking png v0.15.0 [INFO] [stderr] Checking generic-array v0.13.2 [INFO] [stderr] Checking rayon v1.2.0 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking rand v0.7.2 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking approx v0.3.2 [INFO] [stderr] Checking rand_distr v0.2.2 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking alga v0.9.2 [INFO] [stderr] Checking jpeg-decoder v0.1.16 [INFO] [stderr] Checking nalgebra v0.19.0 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking image v0.22.3 [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/obj/shape.rs:1:26 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::obj::vertex::{self, Vertex, Coords3D}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Coords3D`, `VertexP`, and `Vertex` [INFO] [stdout] --> src/main.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::obj::vertex::{Vertex, VertexP, VertexPT, Coords3D}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `self` [INFO] [stdout] --> src/obj/shape.rs:1:26 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::obj::vertex::{self, Vertex, Coords3D}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Coords3D`, `VertexP`, and `Vertex` [INFO] [stdout] --> src/main.rs:14:26 [INFO] [stdout] | [INFO] [stdout] 14 | use crate::obj::vertex::{Vertex, VertexP, VertexPT, Coords3D}; [INFO] [stdout] | ^^^^^^ ^^^^^^^ ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `texture` [INFO] [stdout] --> src/main.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | let texture = render::texture::Texture::from_resource(&resources, "textures/test_16.png").unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_texture` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fps` [INFO] [stdout] --> src/main.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let fps : f32 = 1000.0 / ( tick_diff as f32); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fps` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `texture` [INFO] [stdout] --> src/main.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | let texture = render::texture::Texture::from_resource(&resources, "textures/test_16.png").unwrap(); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_texture` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `fps` [INFO] [stdout] --> src/main.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | let fps : f32 = 1000.0 / ( tick_diff as f32); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_fps` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/main.rs:143:125 [INFO] [stdout] | [INFO] [stdout] 143 | let radius_uniform_location = gl::GetUniformLocation(shader_program.id(), CString::new("timed_colour").unwrap().as_ptr() ); [INFO] [stdout] | ------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/main.rs:143:125 [INFO] [stdout] | [INFO] [stdout] 143 | let radius_uniform_location = gl::GetUniformLocation(shader_program.id(), CString::new("timed_colour").unwrap().as_ptr() ); [INFO] [stdout] | ------------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] = note: `#[warn(temporary_cstring_as_ptr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 51 | let mut file = fs::File::open( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(unsafe { ffi::CString::from_vec_unchecked(buffer) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:67:12 [INFO] [stdout] | [INFO] [stdout] 51 | let mut file = fs::File::open( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Ok(unsafe { ffi::CString::from_vec_unchecked(buffer) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 73 | let file = fs::File::open( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | png::PNGDecoder::new(file).or_else(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 78 | png::PNGDecoder::new(file).or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | println!("{:?}",e); [INFO] [stdout] 80 | Err(Error::ImageDecodeFailed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 73 | let file = fs::File::open( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | png::PNGDecoder::new(file).or_else(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/texture.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 16 | let image_decoder = res.load_image(name) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(Texture{id}) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/obj/shape.rs:146:119 [INFO] [stdout] | [INFO] [stdout] 146 | let translation_location = gl::GetUniformLocation(shader_program_id, CString::new("translation").unwrap().as_ptr()); [INFO] [stdout] | ------------------------------------ ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/obj/shape.rs:153:113 [INFO] [stdout] | [INFO] [stdout] 153 | let rotation_location = gl::GetUniformLocation(shader_program_id, CString::new("rotation").unwrap().as_ptr()); [INFO] [stdout] | --------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/obj/shape.rs:160:107 [INFO] [stdout] | [INFO] [stdout] 160 | let scale_location = gl::GetUniformLocation(shader_program_id, CString::new("scale").unwrap().as_ptr()); [INFO] [stdout] | ------------------------------ ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resources.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 78 | png::PNGDecoder::new(file).or_else(|e| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | println!("{:?}",e); [INFO] [stdout] 80 | Err(Error::ImageDecodeFailed) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render/texture.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 16 | let image_decoder = res.load_image(name) [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Ok(Texture{id}) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/obj/shape.rs:146:119 [INFO] [stdout] | [INFO] [stdout] 146 | let translation_location = gl::GetUniformLocation(shader_program_id, CString::new("translation").unwrap().as_ptr()); [INFO] [stdout] | ------------------------------------ ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/obj/shape.rs:153:113 [INFO] [stdout] | [INFO] [stdout] 153 | let rotation_location = gl::GetUniformLocation(shader_program_id, CString::new("rotation").unwrap().as_ptr()); [INFO] [stdout] | --------------------------------- ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: getting the inner pointer of a temporary `CString` [INFO] [stdout] --> src/obj/shape.rs:160:107 [INFO] [stdout] | [INFO] [stdout] 160 | let scale_location = gl::GetUniformLocation(shader_program_id, CString::new("scale").unwrap().as_ptr()); [INFO] [stdout] | ------------------------------ ^^^^^^ this pointer will be invalid [INFO] [stdout] | | [INFO] [stdout] | this `CString` is deallocated at the end of the statement, bind it to a variable to extend its lifetime [INFO] [stdout] | [INFO] [stdout] = note: pointers do not have a lifetime; when calling `as_ptr` the `CString` will be deallocated at the end of the statement because nothing is referencing it as far as the type system is concerned [INFO] [stdout] = help: for more information, see https://doc.rust-lang.org/reference/destructors.html [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rusty-craft` (bin "rusty-craft") due to 5 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `rusty-craft` (bin "rusty-craft" test) due to 5 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0cd63a0ae373bfdafd9b6915707c8ceb1b8b95bf4501a9a9cfd1c4d45fa3b980", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0cd63a0ae373bfdafd9b6915707c8ceb1b8b95bf4501a9a9cfd1c4d45fa3b980", kill_on_drop: false }` [INFO] [stdout] 0cd63a0ae373bfdafd9b6915707c8ceb1b8b95bf4501a9a9cfd1c4d45fa3b980