[INFO] cloning repository https://github.com/Dwscdv3/gamecrab [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Dwscdv3/gamecrab" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDwscdv3%2Fgamecrab", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDwscdv3%2Fgamecrab'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 81fe76d3928987c6922170955210c156b14531cf [INFO] checking Dwscdv3/gamecrab/81fe76d3928987c6922170955210c156b14531cf against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDwscdv3%2Fgamecrab" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Dwscdv3/gamecrab on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Dwscdv3/gamecrab [INFO] finished tweaking git repo https://github.com/Dwscdv3/gamecrab [INFO] tweaked toml for git repo https://github.com/Dwscdv3/gamecrab written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Dwscdv3/gamecrab already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f7f5357804b859a49efd8774fb9731878a2acb2aae2a5e8614bca59a7409d6c [INFO] running `Command { std: "docker" "start" "-a" "9f7f5357804b859a49efd8774fb9731878a2acb2aae2a5e8614bca59a7409d6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f7f5357804b859a49efd8774fb9731878a2acb2aae2a5e8614bca59a7409d6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f7f5357804b859a49efd8774fb9731878a2acb2aae2a5e8614bca59a7409d6c", kill_on_drop: false }` [INFO] [stdout] 9f7f5357804b859a49efd8774fb9731878a2acb2aae2a5e8614bca59a7409d6c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 70a595e649bf2c1860549de69e71c6edb72504bdfe56597ded2971fbff8b0575 [INFO] running `Command { std: "docker" "start" "-a" "70a595e649bf2c1860549de69e71c6edb72504bdfe56597ded2971fbff8b0575", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.151 [INFO] [stderr] Compiling khronos_api v3.1.0 [INFO] [stderr] Checking rustc-serialize v0.3.25 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling xml-rs v0.8.19 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling sdl2-sys v0.36.0 [INFO] [stderr] Checking smallvec v1.11.2 [INFO] [stderr] Compiling sdl2 v0.36.0 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Compiling gl_generator v0.14.0 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking memmap2 v0.9.0 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Compiling gl v0.14.0 [INFO] [stderr] Checking num-complex v0.1.43 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking stopwatch v0.0.7 [INFO] [stderr] Checking gamecrab v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `sram_bank` and `dma_transferring` are never read [INFO] [stdout] --> src/core/bus.rs:19:7 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Bus { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub sram_bank : u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub dma_transferring : bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `lock_vram`, `unlock_vram`, `lock_oam`, and `unlock_oam` are never used [INFO] [stdout] --> src/core/bus.rs:101:10 [INFO] [stdout] | [INFO] [stdout] 28 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 101 | pub fn lock_vram(&mut self) { self.vram_lock = true; } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 102 | pub fn unlock_vram(&mut self) { self.vram_lock = false; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 103 | pub fn lock_oam(&mut self) { self.oam_lock = true; } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 104 | pub fn unlock_oam(&mut self) { self.oam_lock = false; } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Serial` and `Joypad` are never constructed [INFO] [stdout] --> src/core/cpu.rs:62:42 [INFO] [stdout] | [INFO] [stdout] 62 | pub enum Interrupt { VBlank, LCD, Timer, Serial, Joypad } [INFO] [stdout] | --------- variants in this enum ^^^^^^ ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Interrupt` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `STAT`, `SCY`, `SCX`, and `LYC` are never constructed [INFO] [stdout] --> src/core/emu.rs:13:3 [INFO] [stdout] | [INFO] [stdout] 10 | pub enum RegHw { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 13 | STAT = 0xFF41, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | SCY = 0xFF42, [INFO] [stdout] | ^^^ [INFO] [stdout] 15 | SCX = 0xFF43, [INFO] [stdout] | ^^^ [INFO] [stdout] 16 | LY = 0xFF44, [INFO] [stdout] 17 | LYC = 0xFF45, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RegHw` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/emu.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(rom: Mmap) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let bus = Rc::new(RefCell::new(Bus::new(rom, None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | bus: bus.clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/emu.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(rom: Mmap) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let bus = Rc::new(RefCell::new(Bus::new(rom, None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | cpu: Cpu::new(bus.clone(), clock.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/emu.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(rom: Mmap) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let bus = Rc::new(RefCell::new(Bus::new(rom, None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | ppu: Ppu::new(bus.clone(), clock.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gamecrab` (bin "gamecrab") due to 4 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `sram_bank` and `dma_transferring` are never read [INFO] [stdout] --> src/core/bus.rs:19:7 [INFO] [stdout] | [INFO] [stdout] 9 | pub struct Bus { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | pub sram_bank : u8, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | pub dma_transferring : bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `lock_vram`, `unlock_vram`, `lock_oam`, and `unlock_oam` are never used [INFO] [stdout] --> src/core/bus.rs:101:10 [INFO] [stdout] | [INFO] [stdout] 28 | impl Bus { [INFO] [stdout] | -------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 101 | pub fn lock_vram(&mut self) { self.vram_lock = true; } [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 102 | pub fn unlock_vram(&mut self) { self.vram_lock = false; } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 103 | pub fn lock_oam(&mut self) { self.oam_lock = true; } [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 104 | pub fn unlock_oam(&mut self) { self.oam_lock = false; } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `Serial` and `Joypad` are never constructed [INFO] [stdout] --> src/core/cpu.rs:62:42 [INFO] [stdout] | [INFO] [stdout] 62 | pub enum Interrupt { VBlank, LCD, Timer, Serial, Joypad } [INFO] [stdout] | --------- variants in this enum ^^^^^^ ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Interrupt` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `STAT`, `SCY`, `SCX`, and `LYC` are never constructed [INFO] [stdout] --> src/core/emu.rs:13:3 [INFO] [stdout] | [INFO] [stdout] 10 | pub enum RegHw { [INFO] [stdout] | ----- variants in this enum [INFO] [stdout] ... [INFO] [stdout] 13 | STAT = 0xFF41, [INFO] [stdout] | ^^^^ [INFO] [stdout] 14 | SCY = 0xFF42, [INFO] [stdout] | ^^^ [INFO] [stdout] 15 | SCX = 0xFF43, [INFO] [stdout] | ^^^ [INFO] [stdout] 16 | LY = 0xFF44, [INFO] [stdout] 17 | LYC = 0xFF45, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RegHw` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/emu.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(rom: Mmap) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let bus = Rc::new(RefCell::new(Bus::new(rom, None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 33 | bus: bus.clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/emu.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(rom: Mmap) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let bus = Rc::new(RefCell::new(Bus::new(rom, None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | cpu: Cpu::new(bus.clone(), clock.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/emu.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(rom: Mmap) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let bus = Rc::new(RefCell::new(Bus::new(rom, None))); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | ppu: Ppu::new(bus.clone(), clock.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gamecrab` (bin "gamecrab" test) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "70a595e649bf2c1860549de69e71c6edb72504bdfe56597ded2971fbff8b0575", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "70a595e649bf2c1860549de69e71c6edb72504bdfe56597ded2971fbff8b0575", kill_on_drop: false }` [INFO] [stdout] 70a595e649bf2c1860549de69e71c6edb72504bdfe56597ded2971fbff8b0575