[INFO] cloning repository https://github.com/DunnNDusted/portfolio [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DunnNDusted/portfolio" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDunnNDusted%2Fportfolio", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDunnNDusted%2Fportfolio'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] aab20202d553b9e1e6228af18da90982db4bd6e4 [INFO] checking DunnNDusted/portfolio/aab20202d553b9e1e6228af18da90982db4bd6e4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDunnNDusted%2Fportfolio" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DunnNDusted/portfolio on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DunnNDusted/portfolio [INFO] finished tweaking git repo https://github.com/DunnNDusted/portfolio [INFO] tweaked toml for git repo https://github.com/DunnNDusted/portfolio written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DunnNDusted/portfolio already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6c0d82806ec04ac4ac21f8a9a425a143315be0e88ae7bbf6658edfd9919c7f9d [INFO] running `Command { std: "docker" "start" "-a" "6c0d82806ec04ac4ac21f8a9a425a143315be0e88ae7bbf6658edfd9919c7f9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6c0d82806ec04ac4ac21f8a9a425a143315be0e88ae7bbf6658edfd9919c7f9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c0d82806ec04ac4ac21f8a9a425a143315be0e88ae7bbf6658edfd9919c7f9d", kill_on_drop: false }` [INFO] [stdout] 6c0d82806ec04ac4ac21f8a9a425a143315be0e88ae7bbf6658edfd9919c7f9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e1738e1fb04866913d2e2f18c69ced1954845a648046ddb3e80cc8b8539f209c [INFO] running `Command { std: "docker" "start" "-a" "e1738e1fb04866913d2e2f18c69ced1954845a648046ddb3e80cc8b8539f209c", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libc v0.2.112 [INFO] [stderr] Checking unicode-segmentation v1.8.0 [INFO] [stderr] Checking ppv-lite86 v0.2.15 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking purple_blox v0.1.0 (/opt/rustwide/workdir/purple_blox) [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> purple_blox/src/pool.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 126 | PoolInitialisationErrorKind::ZeroThreads => "pools cannot be initialised with no threads", [INFO] [stdout] | ---------------------------------------- matches all the relevant values [INFO] [stdout] 127 | _ => panic!("unaccounted for error type"), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `kind` is never used [INFO] [stdout] --> purple_blox/src/pool.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 117 | impl PoolInitialisationError { [INFO] [stdout] | ---------------------------- method in this implementation [INFO] [stdout] 118 | pub fn kind(&self) -> &PoolInitialisationErrorKind { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/lib.rs:28:35 [INFO] [stdout] | [INFO] [stdout] 28 | .for_each(|x|pool.execute(||handle_connection(x))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/pool.rs:40:47 [INFO] [stdout] | [INFO] [stdout] 40 | .for_each(|i|workers.push(Worker::new(i, Arc::clone(&rx)))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/pool.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn execute(&self, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | / self.pipeline [INFO] [stdout] 58 | | .send(Message::Continue(Box::new(f))) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/pool.rs:76:26 [INFO] [stdout] | [INFO] [stdout] 76 | .for_each(|x|x.join().unwrap()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/pool.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 83 | fn new(id: usize, inbox: Arc>>) -> Self { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Self(Some(thread)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> purple_blox/src/pool.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 126 | PoolInitialisationErrorKind::ZeroThreads => "pools cannot be initialised with no threads", [INFO] [stdout] | ---------------------------------------- matches all the relevant values [INFO] [stdout] 127 | _ => panic!("unaccounted for error type"), [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `purple_blox` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `kind` is never used [INFO] [stdout] --> purple_blox/src/pool.rs:118:12 [INFO] [stdout] | [INFO] [stdout] 117 | impl PoolInitialisationError { [INFO] [stdout] | ---------------------------- method in this implementation [INFO] [stdout] 118 | pub fn kind(&self) -> &PoolInitialisationErrorKind { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/lib.rs:28:35 [INFO] [stdout] | [INFO] [stdout] 28 | .for_each(|x|pool.execute(||handle_connection(x))) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/pool.rs:40:47 [INFO] [stdout] | [INFO] [stdout] 40 | .for_each(|i|workers.push(Worker::new(i, Arc::clone(&rx)))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/pool.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn execute(&self, f: F) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | / self.pipeline [INFO] [stdout] 58 | | .send(Message::Continue(Box::new(f))) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/pool.rs:76:26 [INFO] [stdout] | [INFO] [stdout] 76 | .for_each(|x|x.join().unwrap()); [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> purple_blox/src/pool.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 83 | fn new(id: usize, inbox: Arc>>) -> Self { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Self(Some(thread)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `purple_blox` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e1738e1fb04866913d2e2f18c69ced1954845a648046ddb3e80cc8b8539f209c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1738e1fb04866913d2e2f18c69ced1954845a648046ddb3e80cc8b8539f209c", kill_on_drop: false }` [INFO] [stdout] e1738e1fb04866913d2e2f18c69ced1954845a648046ddb3e80cc8b8539f209c