[INFO] cloning repository https://github.com/DirtyHairy/rustlings [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DirtyHairy/rustlings" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDirtyHairy%2Frustlings", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDirtyHairy%2Frustlings'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b7ee728bea9abd5c736c956301862121c2c5ac6b [INFO] checking DirtyHairy/rustlings/b7ee728bea9abd5c736c956301862121c2c5ac6b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDirtyHairy%2Frustlings" "/workspace/builds/worker-6-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DirtyHairy/rustlings on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DirtyHairy/rustlings [INFO] finished tweaking git repo https://github.com/DirtyHairy/rustlings [INFO] tweaked toml for git repo https://github.com/DirtyHairy/rustlings written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DirtyHairy/rustlings already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0577fa1e302d9dfb398b7a73eab08f996ebab2549c60172f32cd37ad77316615 [INFO] running `Command { std: "docker" "start" "-a" "0577fa1e302d9dfb398b7a73eab08f996ebab2549c60172f32cd37ad77316615", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0577fa1e302d9dfb398b7a73eab08f996ebab2549c60172f32cd37ad77316615", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0577fa1e302d9dfb398b7a73eab08f996ebab2549c60172f32cd37ad77316615", kill_on_drop: false }` [INFO] [stdout] 0577fa1e302d9dfb398b7a73eab08f996ebab2549c60172f32cd37ad77316615 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42b1c8b59782f3dd66d467374a75774bdaffc3332f9c70c24d5d2e7419dbcad1 [INFO] running `Command { std: "docker" "start" "-a" "42b1c8b59782f3dd66d467374a75774bdaffc3332f9c70c24d5d2e7419dbcad1", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling version-compare v0.1.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling io-lifetimes v1.0.3 [INFO] [stderr] Compiling rustix v0.36.5 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Compiling anyhow v1.0.68 [INFO] [stderr] Checking os_str_bytes v6.4.1 [INFO] [stderr] Compiling sdl2 v0.35.2 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking clap_lex v0.3.0 [INFO] [stderr] Compiling sdl2-sys v0.35.2 [INFO] [stderr] Checking is-terminal v0.4.2 [INFO] [stderr] Checking clap v4.0.32 [INFO] [stderr] Checking rustlings v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `header` is never read [INFO] [stdout] --> src/game_data/file/encoding/datfile.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Section { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 14 | pub header: Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_y` is never used [INFO] [stdout] --> src/game_data/level.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 40 | pub trait LevelStructure { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 43 | fn get_y(&self) -> i32; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `object_info` and `terrain_info` are never read [INFO] [stdout] --> src/game_data/tile_set.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct TileSet { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 45 | pub object_info: [ObjectInfo; OBJECTS_PER_TILESET], [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 46 | pub terrain_info: [TerrainInfo; TILES_PER_TILESET], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TileSet` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/tilesets.rs:37:36 [INFO] [stdout] | [INFO] [stdout] 37 | .and_then(|sprite| SDLSprite::from_sprite(&sprite, &palette, &texture_creator).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/tilesets.rs:43:36 [INFO] [stdout] | [INFO] [stdout] 43 | .and_then(|bitmap| SDLSprite::from_bitmap(&bitmap, &palette, &texture_creator).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sdl_display.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut texture = texture_creator.create_texture( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(SDLSprite { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | width: sprite.width, [INFO] [stdout] 65 | | height: sprite.height, [INFO] [stdout] 66 | | texture, [INFO] [stdout] 67 | | frame_count: sprite.frames.len(), [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sdl_display.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 76 | let mut texture = texture_creator.create_texture( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(SDLSprite { [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | width: bitmap.width, [INFO] [stdout] 112 | | height: bitmap.height, [INFO] [stdout] 113 | | texture, [INFO] [stdout] 114 | | frame_count: 1, [INFO] [stdout] 115 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustlings` (bin "rustlings" test) due to 5 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `header` is never read [INFO] [stdout] --> src/game_data/file/encoding/datfile.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Section { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 14 | pub header: Header, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_y` is never used [INFO] [stdout] --> src/game_data/level.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 40 | pub trait LevelStructure { [INFO] [stdout] | -------------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 43 | fn get_y(&self) -> i32; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `object_info` and `terrain_info` are never read [INFO] [stdout] --> src/game_data/tile_set.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 44 | pub struct TileSet { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 45 | pub object_info: [ObjectInfo; OBJECTS_PER_TILESET], [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 46 | pub terrain_info: [TerrainInfo; TILES_PER_TILESET], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TileSet` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/tilesets.rs:37:36 [INFO] [stdout] | [INFO] [stdout] 37 | .and_then(|sprite| SDLSprite::from_sprite(&sprite, &palette, &texture_creator).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cmd/tilesets.rs:43:36 [INFO] [stdout] | [INFO] [stdout] 43 | .and_then(|bitmap| SDLSprite::from_bitmap(&bitmap, &palette, &texture_creator).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sdl_display.rs:63:12 [INFO] [stdout] | [INFO] [stdout] 19 | let mut texture = texture_creator.create_texture( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | Ok(SDLSprite { [INFO] [stdout] | ____________^ [INFO] [stdout] 64 | | width: sprite.width, [INFO] [stdout] 65 | | height: sprite.height, [INFO] [stdout] 66 | | texture, [INFO] [stdout] 67 | | frame_count: sprite.frames.len(), [INFO] [stdout] 68 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sdl_display.rs:110:12 [INFO] [stdout] | [INFO] [stdout] 76 | let mut texture = texture_creator.create_texture( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 110 | Ok(SDLSprite { [INFO] [stdout] | ____________^ [INFO] [stdout] 111 | | width: bitmap.width, [INFO] [stdout] 112 | | height: bitmap.height, [INFO] [stdout] 113 | | texture, [INFO] [stdout] 114 | | frame_count: 1, [INFO] [stdout] 115 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rustlings` (bin "rustlings") due to 5 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "42b1c8b59782f3dd66d467374a75774bdaffc3332f9c70c24d5d2e7419dbcad1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42b1c8b59782f3dd66d467374a75774bdaffc3332f9c70c24d5d2e7419dbcad1", kill_on_drop: false }` [INFO] [stdout] 42b1c8b59782f3dd66d467374a75774bdaffc3332f9c70c24d5d2e7419dbcad1