[INFO] cloning repository https://github.com/Dhruvmehta18/rate-limiter-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Dhruvmehta18/rate-limiter-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDhruvmehta18%2Frate-limiter-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDhruvmehta18%2Frate-limiter-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b6c5566247b98f96ce46fb8631e06d18747e3715 [INFO] checking Dhruvmehta18/rate-limiter-rs/b6c5566247b98f96ce46fb8631e06d18747e3715 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDhruvmehta18%2Frate-limiter-rs" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Dhruvmehta18/rate-limiter-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Dhruvmehta18/rate-limiter-rs [INFO] finished tweaking git repo https://github.com/Dhruvmehta18/rate-limiter-rs [INFO] tweaked toml for git repo https://github.com/Dhruvmehta18/rate-limiter-rs written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Dhruvmehta18/rate-limiter-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d190f9c3fccadbd4fd1648c074eb2299c0bad2dd54800a42ab49fa467d1e9b40 [INFO] running `Command { std: "docker" "start" "-a" "d190f9c3fccadbd4fd1648c074eb2299c0bad2dd54800a42ab49fa467d1e9b40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d190f9c3fccadbd4fd1648c074eb2299c0bad2dd54800a42ab49fa467d1e9b40", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d190f9c3fccadbd4fd1648c074eb2299c0bad2dd54800a42ab49fa467d1e9b40", kill_on_drop: false }` [INFO] [stdout] d190f9c3fccadbd4fd1648c074eb2299c0bad2dd54800a42ab49fa467d1e9b40 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9c6fb134fe90e89269e44ecd03a0859e281b9a11ea3e6021967cefc7af2bb343 [INFO] running `Command { std: "docker" "start" "-a" "9c6fb134fe90e89269e44ecd03a0859e281b9a11ea3e6021967cefc7af2bb343", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking atomic-waker v1.1.2 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.6 [INFO] [stderr] Checking rate-limiter v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::convert::Infallible` [INFO] [stdout] --> src/fixed_window.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::convert::Infallible; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/fixed_window.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 7 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hyper::body::Frame` [INFO] [stdout] --> src/fixed_window.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use hyper::body::Frame; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/token_bucket.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/leak_bucket.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mutex` [INFO] [stdout] --> src/leak_bucket.rs:3:22 [INFO] [stdout] | [INFO] [stdout] 3 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/leak_bucket.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/sliding_window_log.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `interval` [INFO] [stdout] --> src/sliding_window_log.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | use tokio::time::{Instant, interval}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SystemTime` and `UNIX_EPOCH` [INFO] [stdout] --> src/sliding_window_counter.rs:4:27 [INFO] [stdout] | [INFO] [stdout] 4 | use std::time::{Duration, SystemTime, UNIX_EPOCH}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/sliding_window_counter.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::convert::Infallible` [INFO] [stdout] --> src/fixed_window.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use std::convert::Infallible; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/fixed_window.rs:7:19 [INFO] [stdout] | [INFO] [stdout] 7 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `hyper::body::Frame` [INFO] [stdout] --> src/fixed_window.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 13 | use hyper::body::Frame; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/token_bucket.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::HashMap` [INFO] [stdout] --> src/leak_bucket.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::collections::HashMap; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mutex` [INFO] [stdout] --> src/leak_bucket.rs:3:22 [INFO] [stdout] | [INFO] [stdout] 3 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/leak_bucket.rs:11:19 [INFO] [stdout] | [INFO] [stdout] 11 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/sliding_window_log.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `interval` [INFO] [stdout] --> src/sliding_window_log.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | use tokio::time::{Instant, interval}; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `SystemTime` and `UNIX_EPOCH` [INFO] [stdout] --> src/sliding_window_counter.rs:4:27 [INFO] [stdout] | [INFO] [stdout] 4 | use std::time::{Duration, SystemTime, UNIX_EPOCH}; [INFO] [stdout] | ^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Body` [INFO] [stdout] --> src/sliding_window_counter.rs:10:19 [INFO] [stdout] | [INFO] [stdout] 10 | use hyper::body::{Body, Bytes}; [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `client_ip_str` [INFO] [stdout] --> src/sliding_window_log.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | let client_ip_str = client_ip [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_client_ip_str` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | _ => { [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 22 | RateLimitingStrategy::FixedWindow => { [INFO] [stdout] | --------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 27 | RateLimitingStrategy::SlidingWindowLog => { [INFO] [stdout] | -------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 31 | RateLimitingStrategy::TokenBucket => { [INFO] [stdout] | --------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 36 | RateLimitingStrategy::LeakyBucket => { [INFO] [stdout] | --------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 44 | _ => { [INFO] [stdout] | ^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `FixedWindow`, `SlidingWindowLog`, `TokenBucket`, and `LeakyBucket` are never constructed [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | enum RateLimitingStrategy { [INFO] [stdout] | -------------------- variants in this enum [INFO] [stdout] 10 | FixedWindow, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 11 | SlidingWindowLog, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | TokenBucket, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 13 | LeakyBucket, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/logger_http.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl Logger { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 8 | pub fn new(inner: S) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixed_window.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | / Full::new(chunk.into()) [INFO] [stdout] 29 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixed_window.rs:116:79 [INFO] [stdout] | [INFO] [stdout] 110 | let token_bucket = Arc::clone(&token_bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone(), client_ip.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token_bucket.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 29 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | / Full::new(chunk.into()) [INFO] [stdout] 31 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token_bucket.rs:127:79 [INFO] [stdout] | [INFO] [stdout] 121 | let token_bucket = Arc::clone(&token_bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone(), client_ip.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/leak_bucket.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 69 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | / Full::new(chunk.into()) [INFO] [stdout] 71 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/leak_bucket.rs:133:79 [INFO] [stdout] | [INFO] [stdout] 128 | let token_bucket = Arc::clone(&bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sliding_window_log.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 59 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | / Full::new(chunk.into()) [INFO] [stdout] 61 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sliding_window_log.rs:134:79 [INFO] [stdout] | [INFO] [stdout] 128 | let token_bucket = Arc::clone(&token_bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone(), client_ip.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sliding_window_counter.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 89 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | / Full::new(chunk.into()) [INFO] [stdout] 91 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sliding_window_counter.rs:164:79 [INFO] [stdout] | [INFO] [stdout] 158 | let token_bucket = Arc::clone(&token_bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone(), client_ip.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rate-limiter` (bin "rate-limiter" test) due to 11 previous errors; 15 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `client_ip_str` [INFO] [stdout] --> src/sliding_window_log.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | let client_ip_str = client_ip [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_client_ip_str` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unreachable pattern [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | _ => { [INFO] [stdout] | ^ no value can reach this [INFO] [stdout] | [INFO] [stdout] note: multiple earlier patterns match some of the same values [INFO] [stdout] --> src/main.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 22 | RateLimitingStrategy::FixedWindow => { [INFO] [stdout] | --------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 27 | RateLimitingStrategy::SlidingWindowLog => { [INFO] [stdout] | -------------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 31 | RateLimitingStrategy::TokenBucket => { [INFO] [stdout] | --------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 36 | RateLimitingStrategy::LeakyBucket => { [INFO] [stdout] | --------------------------------- matches some of the same values [INFO] [stdout] ... [INFO] [stdout] 44 | _ => { [INFO] [stdout] | ^ ...and 1 other patterns collectively make this unreachable [INFO] [stdout] = note: `#[warn(unreachable_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `FixedWindow`, `SlidingWindowLog`, `TokenBucket`, and `LeakyBucket` are never constructed [INFO] [stdout] --> src/main.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 9 | enum RateLimitingStrategy { [INFO] [stdout] | -------------------- variants in this enum [INFO] [stdout] 10 | FixedWindow, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 11 | SlidingWindowLog, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 12 | TokenBucket, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 13 | LeakyBucket, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/logger_http.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 7 | impl Logger { [INFO] [stdout] | ----------------- associated function in this implementation [INFO] [stdout] 8 | pub fn new(inner: S) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixed_window.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 27 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | / Full::new(chunk.into()) [INFO] [stdout] 29 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fixed_window.rs:116:79 [INFO] [stdout] | [INFO] [stdout] 110 | let token_bucket = Arc::clone(&token_bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone(), client_ip.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token_bucket.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 29 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | / Full::new(chunk.into()) [INFO] [stdout] 31 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/token_bucket.rs:127:79 [INFO] [stdout] | [INFO] [stdout] 121 | let token_bucket = Arc::clone(&token_bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone(), client_ip.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/leak_bucket.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 69 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | / Full::new(chunk.into()) [INFO] [stdout] 71 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/leak_bucket.rs:133:79 [INFO] [stdout] | [INFO] [stdout] 128 | let token_bucket = Arc::clone(&bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sliding_window_log.rs:60:5 [INFO] [stdout] | [INFO] [stdout] 59 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | / Full::new(chunk.into()) [INFO] [stdout] 61 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sliding_window_log.rs:134:79 [INFO] [stdout] | [INFO] [stdout] 128 | let token_bucket = Arc::clone(&token_bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone(), client_ip.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sliding_window_counter.rs:90:5 [INFO] [stdout] | [INFO] [stdout] 89 | fn full>(chunk: T) -> BoxBody { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | / Full::new(chunk.into()) [INFO] [stdout] 91 | | .map_err(|never| match never {}) [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sliding_window_counter.rs:164:79 [INFO] [stdout] | [INFO] [stdout] 158 | let token_bucket = Arc::clone(&token_bucket); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | .serve_connection(io, service_fn(move |request| echo(request, token_bucket.clone(), client_ip.clone()))) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors; 15 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rate-limiter` (bin "rate-limiter") due to 11 previous errors; 15 warnings emitted [INFO] running `Command { std: "docker" "inspect" "9c6fb134fe90e89269e44ecd03a0859e281b9a11ea3e6021967cefc7af2bb343", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c6fb134fe90e89269e44ecd03a0859e281b9a11ea3e6021967cefc7af2bb343", kill_on_drop: false }` [INFO] [stdout] 9c6fb134fe90e89269e44ecd03a0859e281b9a11ea3e6021967cefc7af2bb343