[INFO] updating cached repository https://github.com/DerZade/meh-utils-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1f9594e478dd64d3ed522b6993a1311272cef7ee [INFO] checking DerZade/meh-utils-rust/1f9594e478dd64d3ed522b6993a1311272cef7ee against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDerZade%2Fmeh-utils-rust" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DerZade/meh-utils-rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DerZade/meh-utils-rust [INFO] finished tweaking git repo https://github.com/DerZade/meh-utils-rust [INFO] tweaked toml for git repo https://github.com/DerZade/meh-utils-rust written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DerZade/meh-utils-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3024ecd1a8062e8602d51ec56a811a2728de1ec4cd1a1089d756175cb97a924a [INFO] running `Command { std: "docker" "start" "-a" "3024ecd1a8062e8602d51ec56a811a2728de1ec4cd1a1089d756175cb97a924a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3024ecd1a8062e8602d51ec56a811a2728de1ec4cd1a1089d756175cb97a924a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3024ecd1a8062e8602d51ec56a811a2728de1ec4cd1a1089d756175cb97a924a", kill_on_drop: false }` [INFO] [stdout] 3024ecd1a8062e8602d51ec56a811a2728de1ec4cd1a1089d756175cb97a924a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f2b2413d8506842069676d1a236c15191aecffbf50f4e16c91eb78007bea22e [INFO] running `Command { std: "docker" "start" "-a" "0f2b2413d8506842069676d1a236c15191aecffbf50f4e16c91eb78007bea22e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.109 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling proc-macro2 v1.0.34 [INFO] [stderr] Compiling crossbeam-epoch v0.9.5 [INFO] [stderr] Compiling syn v1.0.84 [INFO] [stderr] Compiling rayon-core v1.9.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling rayon v1.5.1 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling crc32fast v1.3.0 [INFO] [stderr] Compiling serde_derive v1.0.132 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling num-iter v0.1.42 [INFO] [stderr] Compiling num-rational v0.3.2 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling serde v1.0.132 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking weezl v0.1.5 [INFO] [stderr] Checking deflate v0.8.6 [INFO] [stderr] Compiling nom v7.1.0 [INFO] [stderr] Checking miniz_oxide v0.3.7 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Compiling anyhow v1.0.52 [INFO] [stderr] Compiling serde_json v1.0.73 [INFO] [stderr] Checking gif v0.11.3 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking png v0.16.8 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking bytemuck v1.7.3 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking clap v3.0.0-rc.8 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking tiff v0.6.1 [INFO] [stderr] Checking image v0.23.14 [INFO] [stderr] Checking meh-utils v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `left`, `bottom`, `cell_size`, and `no_data_value` are never read [INFO] [stdout] --> src/dem/raster.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct DEMRaster { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | left: f32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 12 | bottom: f32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | cell_size: f32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 14 | no_data_value: f32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DEMRaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `x`, `y`, and `get_data` are never used [INFO] [stdout] --> src/dem/raster.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl DEMRaster { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 50 | pub fn x(&self, column: usize) -> f32 { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn y(&self, row: usize) -> f32 { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn get_data(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dem/parser.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 107 | move |input: I| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | / terminated::<_, _, _, DEMParserError, _, _>( [INFO] [stdout] 109 | | separated_pair(tag_no_case(name), space1, parser), [INFO] [stdout] 110 | | line_ending, [INFO] [stdout] 111 | | )(input) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metajson.rs:48:11 [INFO] [stdout] | [INFO] [stdout] 45 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | match serde_json::from_reader(reader) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:31:11 [INFO] [stdout] | [INFO] [stdout] 26 | let file = File::create(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | match encoder.encode(&img.to_bytes(), dim.0, dim.1, img.color()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/tile_error.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(col: u32, row: u32, original_error: impl Into) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | original_error: original_error.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `meh-utils` (bin "meh-utils") due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `left`, `bottom`, `cell_size`, and `no_data_value` are never read [INFO] [stdout] --> src/dem/raster.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct DEMRaster { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | left: f32, [INFO] [stdout] | ^^^^ [INFO] [stdout] 12 | bottom: f32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 13 | cell_size: f32, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 14 | no_data_value: f32, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DEMRaster` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `x`, `y`, and `get_data` are never used [INFO] [stdout] --> src/dem/raster.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 18 | impl DEMRaster { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 50 | pub fn x(&self, column: usize) -> f32 { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 54 | pub fn y(&self, row: usize) -> f32 { [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 63 | pub fn get_data(&self) -> &Vec { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/preview.rs:80:27 [INFO] [stdout] | [INFO] [stdout] 80 | .map(|r| {r.unwrap().file_name().to_str().unwrap_or("").to_owned()}) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dem/parser.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 107 | move |input: I| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | / terminated::<_, _, _, DEMParserError, _, _>( [INFO] [stdout] 109 | | separated_pair(tag_no_case(name), space1, parser), [INFO] [stdout] 110 | | line_ending, [INFO] [stdout] 111 | | )(input) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metajson.rs:48:11 [INFO] [stdout] | [INFO] [stdout] 45 | let file = File::open(path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let reader = BufReader::new(file); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | match serde_json::from_reader(reader) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/mod.rs:31:11 [INFO] [stdout] | [INFO] [stdout] 26 | let file = File::create(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | match encoder.encode(&img.to_bytes(), dim.0, dim.1, img.color()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils/tile_error.rs:18:29 [INFO] [stdout] | [INFO] [stdout] 14 | pub fn new(col: u32, row: u32, original_error: impl Into) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | original_error: original_error.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `meh-utils` (bin "meh-utils" test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0f2b2413d8506842069676d1a236c15191aecffbf50f4e16c91eb78007bea22e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f2b2413d8506842069676d1a236c15191aecffbf50f4e16c91eb78007bea22e", kill_on_drop: false }` [INFO] [stdout] 0f2b2413d8506842069676d1a236c15191aecffbf50f4e16c91eb78007bea22e