[INFO] cloning repository https://github.com/Demian101/halo2-learn [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Demian101/halo2-learn" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDemian101%2Fhalo2-learn", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDemian101%2Fhalo2-learn'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9a063cdea625e2d00b321f892a5d71484deeeffd [INFO] checking Demian101/halo2-learn/9a063cdea625e2d00b321f892a5d71484deeeffd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDemian101%2Fhalo2-learn" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Demian101/halo2-learn on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Demian101/halo2-learn [INFO] finished tweaking git repo https://github.com/Demian101/halo2-learn [INFO] tweaked toml for git repo https://github.com/Demian101/halo2-learn written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Demian101/halo2-learn already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7669cf9e46982ed7091bacd3acb36143e865ec429e6adeab86e5b05415d11eb7 [INFO] running `Command { std: "docker" "start" "-a" "7669cf9e46982ed7091bacd3acb36143e865ec429e6adeab86e5b05415d11eb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7669cf9e46982ed7091bacd3acb36143e865ec429e6adeab86e5b05415d11eb7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7669cf9e46982ed7091bacd3acb36143e865ec429e6adeab86e5b05415d11eb7", kill_on_drop: false }` [INFO] [stdout] 7669cf9e46982ed7091bacd3acb36143e865ec429e6adeab86e5b05415d11eb7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3dbd005bbe84ca01d7e15485b7495279f5628cf5cd64334ad0990d292df0ce96 [INFO] running `Command { std: "docker" "start" "-a" "3dbd005bbe84ca01d7e15485b7495279f5628cf5cd64334ad0990d292df0ce96", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking spin v0.5.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.8 [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.8 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.96 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking subtle v2.4.1 [INFO] [stderr] Checking arrayvec v0.7.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking arrayref v0.3.6 [INFO] [stderr] Checking wyz v0.5.0 [INFO] [stderr] Checking blake2b_simd v1.0.0 [INFO] [stderr] Checking crossbeam-channel v0.5.4 [INFO] [stderr] Checking bitvec v1.0.0 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking ff v0.13.0 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking pasta_curves v0.5.1 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Compiling tracing-attributes v0.1.22 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking halo2_proofs v0.3.0 (https://github.com/zcash/halo2.git#f9838c12) [INFO] [stderr] Checking fibonacci v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/fibonacci/example1.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/fibonacci/example2.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example1.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example1b.rs:4:10 [INFO] [stdout] | [INFO] [stdout] 4 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AssignedCell` [INFO] [stdout] --> src/range_check/example1b.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | AssignedCell, // a value Value together with its global location as a Cell with region_index, row_offset, and column [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example2.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example2/table.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Assigned` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | Advice, Assigned, Circuit, Column, ConstraintSystem, Constraints, Error, Expression, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/fibonacci/example1.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `circuit::Value` [INFO] [stdout] --> src/fibonacci/example1.rs:193:24 [INFO] [stdout] | [INFO] [stdout] 193 | use halo2_proofs::{circuit::Value, dev::MockProver, pasta::Fp}; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/fibonacci/example2.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example1.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example1b.rs:4:10 [INFO] [stdout] | [INFO] [stdout] 4 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AssignedCell` [INFO] [stdout] --> src/range_check/example1b.rs:10:9 [INFO] [stdout] | [INFO] [stdout] 10 | AssignedCell, // a value Value together with its global location as a Cell with region_index, row_offset, and column [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Circuit` [INFO] [stdout] --> src/range_check/example1b.rs:176:22 [INFO] [stdout] | [INFO] [stdout] 176 | plonk::{Any, Circuit}, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example2.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example2/table.rs:7:10 [INFO] [stdout] | [INFO] [stdout] 7 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Assigned` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | Advice, Assigned, Circuit, Column, ConstraintSystem, Constraints, Error, Expression, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:3:10 [INFO] [stdout] | [INFO] [stdout] 3 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Any`, `Circuit`, `FailureLocation`, `VerifyFailure`, and `circuit::floor_planner::V1` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 218 | circuit::floor_planner::V1, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 219 | dev::{FailureLocation, MockProver, VerifyFailure}, [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] 220 | pasta::Fp, [INFO] [stdout] 221 | plonk::{Any, Circuit}, [INFO] [stdout] | ^^^ ^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example3/table.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/is_zero.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example3.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/fibonacci/example3.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | for value in 0..RANGE { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | let mut value = config.assign_value(layouter.namespace(|| "Assign all values"), self.value); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/range_check/decompose_range_check.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | let mut value = config.assign_value(layouter.namespace(|| "Assign all values"), self.value); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ACell` is never constructed [INFO] [stdout] --> src/fibonacci/example2.rs:6:8 [INFO] [stdout] | [INFO] [stdout] 6 | struct ACell(AssignedCell); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FiboConfig` is never constructed [INFO] [stdout] --> src/fibonacci/example2.rs:9:8 [INFO] [stdout] | [INFO] [stdout] 9 | struct FiboConfig { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `FiboChip` is never constructed [INFO] [stdout] --> src/fibonacci/example2.rs:16:8 [INFO] [stdout] | [INFO] [stdout] 16 | struct FiboChip { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `construct`, `configure`, `assign`, and `expose_public` are never used [INFO] [stdout] --> src/fibonacci/example2.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 21 | impl FiboChip { [INFO] [stdout] | ------------------------------- associated items in this implementation [INFO] [stdout] 22 | pub fn construct(config: FiboConfig) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 29 | pub fn configure( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 64 | pub fn assign( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 117 | pub fn expose_public( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeConstrained` is never constructed [INFO] [stdout] --> src/range_check/example1.rs:18:8 [INFO] [stdout] | [INFO] [stdout] 18 | struct RangeConstrained(AssignedCell, F>); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeCheckConfig` is never constructed [INFO] [stdout] --> src/range_check/example1.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | struct RangeCheckConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `configure` and `assign` are never used [INFO] [stdout] --> src/range_check/example1.rs:28:12 [INFO] [stdout] | [INFO] [stdout] 27 | impl RangeCheckConfig { [INFO] [stdout] | ------------------------------------------------------------------ associated items in this implementation [INFO] [stdout] 28 | pub fn configure(meta: &mut ConstraintSystem, value: Column) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub fn assign( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeConstrained` is never constructed [INFO] [stdout] --> src/range_check/example2.rs:24:8 [INFO] [stdout] | [INFO] [stdout] 24 | struct RangeConstrained(AssignedCell, F>); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeCheckConfig` is never constructed [INFO] [stdout] --> src/range_check/example2.rs:27:8 [INFO] [stdout] | [INFO] [stdout] 27 | struct RangeCheckConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `configure`, `assign_simple`, and `assign_lookup` are never used [INFO] [stdout] --> src/range_check/example2.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 37 | / impl [INFO] [stdout] 38 | | RangeCheckConfig [INFO] [stdout] | |____________________________________________- associated items in this implementation [INFO] [stdout] ... [INFO] [stdout] 41 | pub fn configure(meta: &mut ConstraintSystem, value: Column) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 95 | pub fn assign_simple( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 120 | pub fn assign_lookup( [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeTableConfig` is never constructed [INFO] [stdout] --> src/range_check/example2/table.rs:17:19 [INFO] [stdout] | [INFO] [stdout] 17 | pub(super) struct RangeTableConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `configure` and `load` are never used [INFO] [stdout] --> src/range_check/example2/table.rs:24:19 [INFO] [stdout] | [INFO] [stdout] 23 | impl RangeTableConfig { [INFO] [stdout] | ------------------------------------------------------------------ associated items in this implementation [INFO] [stdout] 24 | pub(super) fn configure(meta: &mut ConstraintSystem) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 36 | pub(super) fn load(&self, layouter: &mut impl Layouter) -> Result<(), Error> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeConstrained` is never constructed [INFO] [stdout] --> src/range_check/example3.rs:30:8 [INFO] [stdout] | [INFO] [stdout] 30 | struct RangeConstrained { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeCheckConfig` is never constructed [INFO] [stdout] --> src/range_check/example3.rs:37:8 [INFO] [stdout] | [INFO] [stdout] 37 | struct RangeCheckConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `configure` and `assign` are never used [INFO] [stdout] --> src/range_check/example3.rs:49:12 [INFO] [stdout] | [INFO] [stdout] 47 | impl RangeCheckConfig { [INFO] [stdout] | --------------------------------------------------------------------------------------------------- associated items in this implementation [INFO] [stdout] 48 | // REMEMBER THAT THE CONFIGURATION HAPPEN AT KEYGEN TIME [INFO] [stdout] 49 | pub fn configure( [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 102 | pub fn assign( [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeTableConfig` is never constructed [INFO] [stdout] --> src/range_check/example3/table.rs:12:19 [INFO] [stdout] | [INFO] [stdout] 12 | pub(super) struct RangeTableConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated items `configure` and `load` are never used [INFO] [stdout] --> src/range_check/example3/table.rs:19:19 [INFO] [stdout] | [INFO] [stdout] 18 | impl RangeTableConfig { [INFO] [stdout] | --------------------------------------------------------------------------------------------------- associated items in this implementation [INFO] [stdout] 19 | pub(super) fn configure(meta: &mut ConstraintSystem) -> Self { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 35 | pub(super) fn load(&self, layouter: &mut impl Layouter) -> Result<(), Error> { [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeConstrained` is never constructed [INFO] [stdout] --> src/range_check/decompose_range_check.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | struct RangeConstrained(AssignedCell); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `multiplier` is never used [INFO] [stdout] --> src/range_check/decompose_range_check.rs:108:27 [INFO] [stdout] | [INFO] [stdout] 108 | const multiplier: usize = 1 << NUM_BITS; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fibonacci/example3.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 43 | |meta| meta.query_advice(a, Rotation::cur()) - meta.query_advice(b, Rotation::cur()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fibonacci/example3.rs:43:60 [INFO] [stdout] | [INFO] [stdout] 43 | |meta| meta.query_advice(a, Rotation::cur()) - meta.query_advice(b, Rotation::cur()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1.rs:49:43 [INFO] [stdout] | [INFO] [stdout] 36 | let q = meta.query_selector(q_range_check); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let value = meta.query_advice(value, Rotation::cur()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Constraints::with_selector(q, [("range check", range_check(RANGE, value))]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1.rs:43:33 [INFO] [stdout] | [INFO] [stdout] 41 | let range_check = |range: usize, value: Expression| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | assert!(range > 0); [INFO] [stdout] 43 | (1..range).fold(value.clone(), |expr, i| { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 43 | (1..range).fold(value.clone(), |expr, i| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | expr * (Expression::Constant(F::from(i as u64)) - value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1b.rs:118:43 [INFO] [stdout] | [INFO] [stdout] 108 | let q = virtual_cells.query_selector(q_range_check); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let value = virtual_cells.query_advice(advice_column, Rotation::cur()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let rc_polynomial = (1..RANGE).fold(value.clone(), |expr, i| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Constraints::with_selector(q, [("range check", rc_polynomial)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1b.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 114 | let rc_polynomial = (1..RANGE).fold(value.clone(), |expr, i| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | expr * (Expression::Constant(F::from(i as u64)) - value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example2.rs:77:43 [INFO] [stdout] | [INFO] [stdout] 59 | let q = meta.query_selector(q_range_check); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let value = meta.query_advice(value, Rotation::cur()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Constraints::with_selector(q, [("range check", range_check(RANGE, value))]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example2.rs:71:33 [INFO] [stdout] | [INFO] [stdout] 69 | let range_check = |range: usize, value: Expression| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | assert!(range > 0); [INFO] [stdout] 71 | (1..range).fold(value.clone(), |expr, i| { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example2.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 71 | (1..range).fold(value.clone(), |expr, i| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | expr * (Expression::Constant(F::from(i as u64)) - value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/decompose_range_check.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 86 | let q = meta.query_selector(q_decomposed); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let value = meta.query_advice(value, Rotation::cur()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let mut decomposed_values = vec![]; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / [( [INFO] [stdout] 121 | | "range check", [INFO] [stdout] 122 | | decomposed_check(decomposed_parts, value, decomposed_values), [INFO] [stdout] 123 | | )], [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/decompose_range_check.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 101 | value: Expression, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | decomposed_values: Vec>| { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | / (0..decomposed_parts).fold( [INFO] [stdout] 110 | | Expression::Constant(F::from(0 as u64)), [INFO] [stdout] 111 | | |expr, i| { [INFO] [stdout] 112 | | expr + decomposed_values[i].clone() [INFO] [stdout] 113 | | * Expression::Constant(F::from(1_u64 << (NUM_BITS * i))) [INFO] [stdout] 114 | | }, [INFO] [stdout] 115 | | ) - value [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `multiplier` should have an upper case name [INFO] [stdout] --> src/range_check/decompose_range_check.rs:108:27 [INFO] [stdout] | [INFO] [stdout] 108 | const multiplier: usize = 1 << NUM_BITS; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `MULTIPLIER` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/decompose_range_check.rs:112:36 [INFO] [stdout] | [INFO] [stdout] 111 | |expr, i| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | expr + decomposed_values[i].clone() [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 113 | | * Expression::Constant(F::from(1_u64 << (NUM_BITS * i))) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `bitCount` should have a snake case name [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | let mut bitCount = 0; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `bit_count` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `currPow2` should have a snake case name [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 47 | let mut currPow2 = 1; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `curr_pow2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `currentBits` should have a snake case name [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | let mut currentBits = 0; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `current_bits` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 40 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fibonacci` (lib) due to 14 previous errors; 40 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/is_zero.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example3.rs:1:10 [INFO] [stdout] | [INFO] [stdout] 1 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/fibonacci/example3.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Field` [INFO] [stdout] --> src/range_check/example3/table.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | use ff::{Field, PrimeField}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:50:21 [INFO] [stdout] | [INFO] [stdout] 50 | for value in 0..RANGE { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `value` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:210:17 [INFO] [stdout] | [INFO] [stdout] 210 | let mut value = config.assign_value(layouter.namespace(|| "Assign all values"), self.value); [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_value` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/range_check/decompose_range_check.rs:210:13 [INFO] [stdout] | [INFO] [stdout] 210 | let mut value = config.assign_value(layouter.namespace(|| "Assign all values"), self.value); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:231:13 [INFO] [stdout] | [INFO] [stdout] 231 | for i in 0..RANGE { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/range_check/decompose_range_check.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | Err(e) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `num_bits` and `assigned_cell` are never read [INFO] [stdout] --> src/range_check/example3.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 30 | struct RangeConstrained { [INFO] [stdout] | ---------------- fields in this struct [INFO] [stdout] 31 | num_bits: AssignedCell, F>, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 32 | assigned_cell: AssignedCell, F>, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RangeConstrained` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `RangeConstrained` is never constructed [INFO] [stdout] --> src/range_check/decompose_range_check.rs:44:8 [INFO] [stdout] | [INFO] [stdout] 44 | struct RangeConstrained(AssignedCell); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `multiplier` is never used [INFO] [stdout] --> src/range_check/decompose_range_check.rs:108:27 [INFO] [stdout] | [INFO] [stdout] 108 | const multiplier: usize = 1 << NUM_BITS; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fibonacci/example3.rs:43:20 [INFO] [stdout] | [INFO] [stdout] 43 | |meta| meta.query_advice(a, Rotation::cur()) - meta.query_advice(b, Rotation::cur()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fibonacci/example3.rs:43:60 [INFO] [stdout] | [INFO] [stdout] 43 | |meta| meta.query_advice(a, Rotation::cur()) - meta.query_advice(b, Rotation::cur()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1.rs:49:43 [INFO] [stdout] | [INFO] [stdout] 36 | let q = meta.query_selector(q_range_check); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | let value = meta.query_advice(value, Rotation::cur()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | Constraints::with_selector(q, [("range check", range_check(RANGE, value))]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1.rs:43:33 [INFO] [stdout] | [INFO] [stdout] 41 | let range_check = |range: usize, value: Expression| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | assert!(range > 0); [INFO] [stdout] 43 | (1..range).fold(value.clone(), |expr, i| { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 43 | (1..range).fold(value.clone(), |expr, i| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | expr * (Expression::Constant(F::from(i as u64)) - value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1b.rs:118:43 [INFO] [stdout] | [INFO] [stdout] 108 | let q = virtual_cells.query_selector(q_range_check); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | let value = virtual_cells.query_advice(advice_column, Rotation::cur()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 114 | let rc_polynomial = (1..RANGE).fold(value.clone(), |expr, i| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | Constraints::with_selector(q, [("range check", rc_polynomial)]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example1b.rs:115:24 [INFO] [stdout] | [INFO] [stdout] 114 | let rc_polynomial = (1..RANGE).fold(value.clone(), |expr, i| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | expr * (Expression::Constant(F::from(i as u64)) - value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example2.rs:77:43 [INFO] [stdout] | [INFO] [stdout] 59 | let q = meta.query_selector(q_range_check); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let value = meta.query_advice(value, Rotation::cur()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | Constraints::with_selector(q, [("range check", range_check(RANGE, value))]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example2.rs:71:33 [INFO] [stdout] | [INFO] [stdout] 69 | let range_check = |range: usize, value: Expression| { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | assert!(range > 0); [INFO] [stdout] 71 | (1..range).fold(value.clone(), |expr, i| { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/example2.rs:72:28 [INFO] [stdout] | [INFO] [stdout] 71 | (1..range).fold(value.clone(), |expr, i| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | expr * (Expression::Constant(F::from(i as u64)) - value.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/decompose_range_check.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 86 | let q = meta.query_selector(q_decomposed); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let value = meta.query_advice(value, Rotation::cur()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | let mut decomposed_values = vec![]; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | / [( [INFO] [stdout] 121 | | "range check", [INFO] [stdout] 122 | | decomposed_check(decomposed_parts, value, decomposed_values), [INFO] [stdout] 123 | | )], [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/decompose_range_check.rs:109:21 [INFO] [stdout] | [INFO] [stdout] 101 | value: Expression, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | decomposed_values: Vec>| { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | / (0..decomposed_parts).fold( [INFO] [stdout] 110 | | Expression::Constant(F::from(0 as u64)), [INFO] [stdout] 111 | | |expr, i| { [INFO] [stdout] 112 | | expr + decomposed_values[i].clone() [INFO] [stdout] 113 | | * Expression::Constant(F::from(1_u64 << (NUM_BITS * i))) [INFO] [stdout] 114 | | }, [INFO] [stdout] 115 | | ) - value [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `multiplier` should have an upper case name [INFO] [stdout] --> src/range_check/decompose_range_check.rs:108:27 [INFO] [stdout] | [INFO] [stdout] 108 | const multiplier: usize = 1 << NUM_BITS; [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper case: `MULTIPLIER` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/range_check/decompose_range_check.rs:112:36 [INFO] [stdout] | [INFO] [stdout] 111 | |expr, i| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | expr + decomposed_values[i].clone() [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 113 | | * Expression::Constant(F::from(1_u64 << (NUM_BITS * i))) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `bitCount` should have a snake case name [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:46:25 [INFO] [stdout] | [INFO] [stdout] 46 | let mut bitCount = 0; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `bit_count` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `currPow2` should have a snake case name [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 47 | let mut currPow2 = 1; [INFO] [stdout] | ^^^^^^^^ help: convert the identifier to snake case: `curr_pow2` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `currentBits` should have a snake case name [INFO] [stdout] --> src/range_check/decompose_range_check/table.rs:48:25 [INFO] [stdout] | [INFO] [stdout] 48 | let mut currentBits = 0; [INFO] [stdout] | ^^^^^^^^^^^ help: convert the identifier to snake case: `current_bits` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 29 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `fibonacci` (lib test) due to 14 previous errors; 29 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3dbd005bbe84ca01d7e15485b7495279f5628cf5cd64334ad0990d292df0ce96", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3dbd005bbe84ca01d7e15485b7495279f5628cf5cd64334ad0990d292df0ce96", kill_on_drop: false }` [INFO] [stdout] 3dbd005bbe84ca01d7e15485b7495279f5628cf5cd64334ad0990d292df0ce96