[INFO] cloning repository https://github.com/Defernus/farkle [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Defernus/farkle" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDefernus%2Ffarkle", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDefernus%2Ffarkle'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0c87e334c632f57aebaf9fa11014e773ee30b683 [INFO] checking Defernus/farkle/0c87e334c632f57aebaf9fa11014e773ee30b683 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDefernus%2Ffarkle" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Defernus/farkle on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Defernus/farkle [INFO] finished tweaking git repo https://github.com/Defernus/farkle [INFO] tweaked toml for git repo https://github.com/Defernus/farkle written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Defernus/farkle already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7af01cd693e7b73d0e98027339ba0a23d42a9f1046724b767bfcbff0f9c7af87 [INFO] running `Command { std: "docker" "start" "-a" "7af01cd693e7b73d0e98027339ba0a23d42a9f1046724b767bfcbff0f9c7af87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7af01cd693e7b73d0e98027339ba0a23d42a9f1046724b767bfcbff0f9c7af87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7af01cd693e7b73d0e98027339ba0a23d42a9f1046724b767bfcbff0f9c7af87", kill_on_drop: false }` [INFO] [stdout] 7af01cd693e7b73d0e98027339ba0a23d42a9f1046724b767bfcbff0f9c7af87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7354006463e6805371a67dce644a331f11ae56a2c5ca803b5b67d8519e859ae5 [INFO] running `Command { std: "docker" "start" "-a" "7354006463e6805371a67dce644a331f11ae56a2c5ca803b5b67d8519e859ae5", kill_on_drop: false }` [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Compiling miniquad v0.4.0 [INFO] [stderr] Checking bytemuck v1.15.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking ttf-parser v0.15.2 [INFO] [stderr] Checking glam v0.21.3 [INFO] [stderr] Checking quad-rand v0.2.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking bumpalo v3.15.4 [INFO] [stderr] Compiling macroquad_macro v0.1.7 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking png v0.17.13 [INFO] [stderr] Checking fontdue v0.7.3 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Checking macroquad v0.4.5 [INFO] [stderr] Checking farkle v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/farkle/dice.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 25 | fn from(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Arc::new(inner).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/farkle/game.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new(players: Vec) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 15 | | turn: Turn::new(players[0].dice(), 0), [INFO] [stdout] 16 | | players, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/farkle/player.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new(id: &str, dice: Vec) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | id: id.to_string(), [INFO] [stdout] 17 | | score: 0, [INFO] [stdout] 18 | | dice, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `farkle` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/farkle/dice.rs:26:9 [INFO] [stdout] | [INFO] [stdout] 25 | fn from(inner: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Arc::new(inner).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/farkle/game.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn new(players: Vec) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 15 | | turn: Turn::new(players[0].dice(), 0), [INFO] [stdout] 16 | | players, [INFO] [stdout] 17 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/farkle/player.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new(id: &str, dice: Vec) -> Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 16 | | id: id.to_string(), [INFO] [stdout] 17 | | score: 0, [INFO] [stdout] 18 | | dice, [INFO] [stdout] 19 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `farkle` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "7354006463e6805371a67dce644a331f11ae56a2c5ca803b5b67d8519e859ae5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7354006463e6805371a67dce644a331f11ae56a2c5ca803b5b67d8519e859ae5", kill_on_drop: false }` [INFO] [stdout] 7354006463e6805371a67dce644a331f11ae56a2c5ca803b5b67d8519e859ae5