[INFO] cloning repository https://github.com/DeepViewML/deepviewrt-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DeepViewML/deepviewrt-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeepViewML%2Fdeepviewrt-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeepViewML%2Fdeepviewrt-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 49e01634650cf5374a3b74f02b75788a07acd8d7 [INFO] checking DeepViewML/deepviewrt-rs/49e01634650cf5374a3b74f02b75788a07acd8d7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDeepViewML%2Fdeepviewrt-rs" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DeepViewML/deepviewrt-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DeepViewML/deepviewrt-rs [INFO] finished tweaking git repo https://github.com/DeepViewML/deepviewrt-rs [INFO] tweaked toml for git repo https://github.com/DeepViewML/deepviewrt-rs written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DeepViewML/deepviewrt-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5943ff4f49d2383ae006e22c4c56463dd927005b7db60c9490948b6a13e31817 [INFO] running `Command { std: "docker" "start" "-a" "5943ff4f49d2383ae006e22c4c56463dd927005b7db60c9490948b6a13e31817", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5943ff4f49d2383ae006e22c4c56463dd927005b7db60c9490948b6a13e31817", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5943ff4f49d2383ae006e22c4c56463dd927005b7db60c9490948b6a13e31817", kill_on_drop: false }` [INFO] [stdout] 5943ff4f49d2383ae006e22c4c56463dd927005b7db60c9490948b6a13e31817 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ad75d46c21fc6dd09b6d1fdb208697615e2343069455141bc7d7dbd6d46a2b6 [INFO] running `Command { std: "docker" "start" "-a" "0ad75d46c21fc6dd09b6d1fdb208697615e2343069455141bc7d7dbd6d46a2b6", kill_on_drop: false }` [INFO] [stderr] Compiling deepviewrt-sys v0.0.0 (/opt/rustwide/workdir/deepviewrt-sys) [INFO] [stderr] Checking deepviewrt v0.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(engine: Engine, memory_size: usize, cache_size: usize) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let tensors_ref: Vec<(i32, Tensor)> = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let tensors = RefCell::new(tensors_ref); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(Context { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | owned: true, [INFO] [stdout] 42 | | ptr: ret, [INFO] [stdout] 43 | | engine: Cell::new(Some(engine)), [INFO] [stdout] ... | [INFO] [stdout] 46 | | tensors, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returned pointer of `as_ptr` call is never null, so checking it for null will always return false [INFO] [stdout] --> src/context.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | if !self.model.as_ptr().is_null() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(useless_ptr_null_checks)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 229 | let tensors_ref: Vec<(i32, Tensor)> = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let tensors = RefCell::new(tensors_ref); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | [INFO] [stdout] 232 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | owned: false, [INFO] [stdout] 234 | | ptr, [INFO] [stdout] 235 | | engine: Cell::new(None), [INFO] [stdout] ... | [INFO] [stdout] 238 | | tensors, [INFO] [stdout] 239 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deepviewrt` (lib) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:40:12 [INFO] [stdout] | [INFO] [stdout] 23 | pub fn new(engine: Engine, memory_size: usize, cache_size: usize) -> Result { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let tensors_ref: Vec<(i32, Tensor)> = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let tensors = RefCell::new(tensors_ref); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | Ok(Context { [INFO] [stdout] | ____________^ [INFO] [stdout] 41 | | owned: true, [INFO] [stdout] 42 | | ptr: ret, [INFO] [stdout] 43 | | engine: Cell::new(Some(engine)), [INFO] [stdout] ... | [INFO] [stdout] 46 | | tensors, [INFO] [stdout] 47 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returned pointer of `as_ptr` call is never null, so checking it for null will always return false [INFO] [stdout] --> src/context.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | if !self.model.as_ptr().is_null() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(useless_ptr_null_checks)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:232:12 [INFO] [stdout] | [INFO] [stdout] 229 | let tensors_ref: Vec<(i32, Tensor)> = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | let tensors = RefCell::new(tensors_ref); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | [INFO] [stdout] 232 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 233 | | owned: false, [INFO] [stdout] 234 | | ptr, [INFO] [stdout] 235 | | engine: Cell::new(None), [INFO] [stdout] ... | [INFO] [stdout] 238 | | tensors, [INFO] [stdout] 239 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `deepviewrt` (lib test) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0ad75d46c21fc6dd09b6d1fdb208697615e2343069455141bc7d7dbd6d46a2b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ad75d46c21fc6dd09b6d1fdb208697615e2343069455141bc7d7dbd6d46a2b6", kill_on_drop: false }` [INFO] [stdout] 0ad75d46c21fc6dd09b6d1fdb208697615e2343069455141bc7d7dbd6d46a2b6