[INFO] cloning repository https://github.com/DavidVentura/snapcast-client [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DavidVentura/snapcast-client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidVentura%2Fsnapcast-client", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidVentura%2Fsnapcast-client'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f6bcaaaf038ed0b8cf3d97d06a6c87c8eb7ca587 [INFO] checking DavidVentura/snapcast-client/f6bcaaaf038ed0b8cf3d97d06a6c87c8eb7ca587 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidVentura%2Fsnapcast-client" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DavidVentura/snapcast-client on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DavidVentura/snapcast-client [INFO] finished tweaking git repo https://github.com/DavidVentura/snapcast-client [INFO] tweaked toml for git repo https://github.com/DavidVentura/snapcast-client written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DavidVentura/snapcast-client already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: lib.src [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://github.com/DavidVentura/claxon.git` [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] [stderr] Adding claxon v0.4.3 (https://github.com/DavidVentura/claxon.git?branch=borrow-api#7cb02684) [INFO] [stderr] Adding endian-type v0.1.2 (latest: v0.2.0) [INFO] [stderr] Adding nibble_vec v0.1.0 [INFO] [stderr] Adding radix_trie v0.2.1 [INFO] [stderr] Adding simple-dns v0.7.1 (latest: v0.8.0) [INFO] [stderr] Adding simple-mdns v0.6.2 [INFO] [stderr] Adding smallvec v1.13.2 [INFO] [stderr] Adding socket2 v0.5.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e7ce915591eec511a34e1c8e7630d57d7fe68f54bdf339f9ce4df10a1d9f5913 [INFO] running `Command { std: "docker" "start" "-a" "e7ce915591eec511a34e1c8e7630d57d7fe68f54bdf339f9ce4df10a1d9f5913", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e7ce915591eec511a34e1c8e7630d57d7fe68f54bdf339f9ce4df10a1d9f5913", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e7ce915591eec511a34e1c8e7630d57d7fe68f54bdf339f9ce4df10a1d9f5913", kill_on_drop: false }` [INFO] [stdout] e7ce915591eec511a34e1c8e7630d57d7fe68f54bdf339f9ce4df10a1d9f5913 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dd182fcf85dd50c4711c7d1ba5302469fb653eaea755ef0e2fc8a6eaba76602b [INFO] running `Command { std: "docker" "start" "-a" "dd182fcf85dd50c4711c7d1ba5302469fb653eaea755ef0e2fc8a6eaba76602b", kill_on_drop: false }` [INFO] [stderr] warning: unused manifest key: lib.src [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling anyhow v1.0.81 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking circular-buffer v0.1.6 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Checking simple-dns v0.7.1 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking simple-mdns v0.6.2 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Compiling enum_dispatch v0.3.12 [INFO] [stderr] Checking clap v4.5.2 [INFO] [stderr] Checking snapcast-client v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `dec_buf` is never read [INFO] [stdout] --> src/decoder.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 75 | pub struct FlacDecoder { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 76 | dec_buf: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 39 | fn new(conn: TcpStream) -> anyhow::Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let latency_buf = CircularBuffer::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(ConnectedClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | conn, [INFO] [stdout] 52 | | time_base, [INFO] [stdout] 53 | | latency_buf, [INFO] [stdout] ... | [INFO] [stdout] 69 | | //data_buf: Box::new(CircularBuffer::new()), [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playback/tcp.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(addr: A, rate: usize) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let s = TcpStream::connect(addr)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(Tcp { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | s, [INFO] [stdout] 39 | | sample_rate: rate as u16, [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snapcast-client` (lib test) due to 3 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `dec_buf` is never read [INFO] [stdout] --> src/decoder.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 75 | pub struct FlacDecoder { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 76 | dec_buf: Vec, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 39 | fn new(conn: TcpStream) -> anyhow::Result { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let latency_buf = CircularBuffer::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | Ok(ConnectedClient { [INFO] [stdout] | ____________^ [INFO] [stdout] 51 | | conn, [INFO] [stdout] 52 | | time_base, [INFO] [stdout] 53 | | latency_buf, [INFO] [stdout] ... | [INFO] [stdout] 69 | | //data_buf: Box::new(CircularBuffer::new()), [INFO] [stdout] 70 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playback/tcp.rs:37:12 [INFO] [stdout] | [INFO] [stdout] 35 | pub fn new(addr: A, rate: usize) -> anyhow::Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | let s = TcpStream::connect(addr)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Ok(Tcp { [INFO] [stdout] | ____________^ [INFO] [stdout] 38 | | s, [INFO] [stdout] 39 | | sample_rate: rate as u16, [INFO] [stdout] 40 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `snapcast-client` (lib) due to 3 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "dd182fcf85dd50c4711c7d1ba5302469fb653eaea755ef0e2fc8a6eaba76602b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dd182fcf85dd50c4711c7d1ba5302469fb653eaea755ef0e2fc8a6eaba76602b", kill_on_drop: false }` [INFO] [stdout] dd182fcf85dd50c4711c7d1ba5302469fb653eaea755ef0e2fc8a6eaba76602b