[INFO] cloning repository https://github.com/DavidHVernon/dirp [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DavidHVernon/dirp" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidHVernon%2Fdirp", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidHVernon%2Fdirp'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7f2d1dae6bd3ecadf9fde099ba5b74d470cc5019 [INFO] checking DavidHVernon/dirp/7f2d1dae6bd3ecadf9fde099ba5b74d470cc5019 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDavidHVernon%2Fdirp" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DavidHVernon/dirp on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DavidHVernon/dirp [INFO] finished tweaking git repo https://github.com/DavidHVernon/dirp [INFO] tweaked toml for git repo https://github.com/DavidHVernon/dirp written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DavidHVernon/dirp already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2300b3924c5b7a54a44f89cae3da1f8d78b64fa1b4fae371d874d5107b2d216 [INFO] running `Command { std: "docker" "start" "-a" "e2300b3924c5b7a54a44f89cae3da1f8d78b64fa1b4fae371d874d5107b2d216", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2300b3924c5b7a54a44f89cae3da1f8d78b64fa1b4fae371d874d5107b2d216", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2300b3924c5b7a54a44f89cae3da1f8d78b64fa1b4fae371d874d5107b2d216", kill_on_drop: false }` [INFO] [stdout] e2300b3924c5b7a54a44f89cae3da1f8d78b64fa1b4fae371d874d5107b2d216 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ac5dec4bbbc78a7e6c252498ad049a77dd334dc6542b321b377bd1f9ee7946c3 [INFO] running `Command { std: "docker" "start" "-a" "ac5dec4bbbc78a7e6c252498ad049a77dd334dc6542b321b377bd1f9ee7946c3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling parking_lot_core v0.9.7 [INFO] [stderr] Compiling signal-hook v0.3.15 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling io-lifetimes v1.0.9 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Compiling rustix v0.36.11 [INFO] [stderr] Compiling crossbeam-utils v0.8.15 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling lock_api v0.4.9 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking iana-time-zone v0.1.53 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking crossbeam-channel v0.5.7 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking zeroize v1.5.7 [INFO] [stderr] Checking home v0.5.4 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.6 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking inotify v0.9.6 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking console v0.15.5 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking filetime v0.2.20 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking notify v5.1.0 [INFO] [stderr] Checking chrono v0.4.23 [INFO] [stderr] Checking tui v0.19.0 [INFO] [stderr] Checking timer v0.2.0 [INFO] [stderr] Checking trash v3.0.1 [INFO] [stderr] Checking tempfile v3.4.0 [INFO] [stderr] Checking dialoguer v0.10.3 [INFO] [stderr] Checking dirp v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/utils.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | if let Ok(path) = PathBuf::from_str(&file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/utils.rs:138:15 [INFO] [stdout] | [INFO] [stdout] 138 | } else if let Ok(path) = PathBuf::from_str(file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | StdIoError(std::io::Error), [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 181 | StdIoError(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:183:31 [INFO] [stdout] | [INFO] [stdout] 183 | SendErrorDirpStateMessage(std::sync::mpsc::SendError), [INFO] [stdout] | ------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 183 | SendErrorDirpStateMessage(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:184:26 [INFO] [stdout] | [INFO] [stdout] 184 | SendErrorUserMessage(std::sync::mpsc::SendError), [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 184 | SendErrorUserMessage(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | TrashError(trash::Error), [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 185 | TrashError(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dirp_state.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 16 | user_sender: Sender, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | dirp_state_sender: Sender, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | dirp_state_receiver: Receiver, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ) -> JoinHandle<()> { [INFO] [stdout] 20 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 21 | | if let Err(error) = [INFO] [stdout] 22 | | dirp_state_loop(path, user_sender, dirp_state_sender, dirp_state_receiver) [INFO] [stdout] 23 | | { [INFO] [stdout] 24 | | panic!("dirp_state_loop error: {:#?}", error); [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dirp` (bin "dirp" test) due to 2 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/utils.rs:127:8 [INFO] [stdout] | [INFO] [stdout] 127 | if let Ok(path) = PathBuf::from_str(&file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/utils.rs:138:15 [INFO] [stdout] | [INFO] [stdout] 138 | } else if let Ok(path) = PathBuf::from_str(file_path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:181:16 [INFO] [stdout] | [INFO] [stdout] 181 | StdIoError(std::io::Error), [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 181 | StdIoError(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:183:31 [INFO] [stdout] | [INFO] [stdout] 183 | SendErrorDirpStateMessage(std::sync::mpsc::SendError), [INFO] [stdout] | ------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 183 | SendErrorDirpStateMessage(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:184:26 [INFO] [stdout] | [INFO] [stdout] 184 | SendErrorUserMessage(std::sync::mpsc::SendError), [INFO] [stdout] | -------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 184 | SendErrorUserMessage(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/types.rs:185:16 [INFO] [stdout] | [INFO] [stdout] 185 | TrashError(trash::Error), [INFO] [stdout] | ---------- ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `DirpError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 185 | TrashError(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/dirp_state.rs:20:19 [INFO] [stdout] | [INFO] [stdout] 16 | user_sender: Sender, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | dirp_state_sender: Sender, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 18 | dirp_state_receiver: Receiver, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | ) -> JoinHandle<()> { [INFO] [stdout] 20 | thread::spawn(move || { [INFO] [stdout] | ___________________^ [INFO] [stdout] 21 | | if let Err(error) = [INFO] [stdout] 22 | | dirp_state_loop(path, user_sender, dirp_state_sender, dirp_state_receiver) [INFO] [stdout] 23 | | { [INFO] [stdout] 24 | | panic!("dirp_state_loop error: {:#?}", error); [INFO] [stdout] 25 | | } [INFO] [stdout] 26 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dirp` (bin "dirp") due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "ac5dec4bbbc78a7e6c252498ad049a77dd334dc6542b321b377bd1f9ee7946c3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ac5dec4bbbc78a7e6c252498ad049a77dd334dc6542b321b377bd1f9ee7946c3", kill_on_drop: false }` [INFO] [stdout] ac5dec4bbbc78a7e6c252498ad049a77dd334dc6542b321b377bd1f9ee7946c3