[INFO] cloning repository https://github.com/DataDog/rust-license-tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DataDog/rust-license-tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDataDog%2Frust-license-tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDataDog%2Frust-license-tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] bf4b92c1dacbefb277945bdf9eb9105d06c276f0 [INFO] checking DataDog/rust-license-tool/bf4b92c1dacbefb277945bdf9eb9105d06c276f0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDataDog%2Frust-license-tool" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DataDog/rust-license-tool on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DataDog/rust-license-tool [INFO] finished tweaking git repo https://github.com/DataDog/rust-license-tool [INFO] tweaked toml for git repo https://github.com/DataDog/rust-license-tool written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DataDog/rust-license-tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2d2dc7b4dd9b48489b1f39d36b8463e86ed05447c79e08341652a758bb07dbfc [INFO] running `Command { std: "docker" "start" "-a" "2d2dc7b4dd9b48489b1f39d36b8463e86ed05447c79e08341652a758bb07dbfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2d2dc7b4dd9b48489b1f39d36b8463e86ed05447c79e08341652a758bb07dbfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2d2dc7b4dd9b48489b1f39d36b8463e86ed05447c79e08341652a758bb07dbfc", kill_on_drop: false }` [INFO] [stdout] 2d2dc7b4dd9b48489b1f39d36b8463e86ed05447c79e08341652a758bb07dbfc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6c2de8ba05248e8c137e1dff56513fddd12b87e87eb1527ff27f28d23976300e [INFO] running `Command { std: "docker" "start" "-a" "6c2de8ba05248e8c137e1dff56513fddd12b87e87eb1527ff27f28d23976300e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.74 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Checking memchr v2.6.3 [INFO] [stderr] Checking equivalent v1.0.0 [INFO] [stderr] Compiling camino v1.1.4 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling thiserror v1.0.40 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling semver v1.0.17 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking aho-corasick v1.0.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.46 [INFO] [stderr] Checking regex-automata v0.4.4 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.40 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking cargo-platform v0.1.2 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking dd-rust-license-tool v1.0.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 152 | let out = File::create(&temp_filename) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | fs::rename(&temp_filename, DEST_FILENAME) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 213 | fn lookup_deps(package_ids: HashSet, packages: Vec) -> Vec { [INFO] [stdout] | ------------------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let mut packages: HashMap<_, _> = packages [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | / package_ids [INFO] [stdout] 219 | | .into_iter() [INFO] [stdout] 220 | | .map(|id| packages.remove(&id).expect("Missing package {id:?}")) [INFO] [stdout] 221 | | .filter(|package| package.source.is_some()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:220:19 [INFO] [stdout] | [INFO] [stdout] 220 | .map(|id| packages.remove(&id).expect("Missing package {id:?}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:362:5 [INFO] [stdout] | [INFO] [stdout] 357 | fn output_table(records: Vec, writer: impl Write) -> Result<()> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | let mut csv = csv::Writer::from_writer(writer); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | csv.flush().map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 152 | let out = File::create(&temp_filename) [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | fs::rename(&temp_filename, DEST_FILENAME) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:218:5 [INFO] [stdout] | [INFO] [stdout] 213 | fn lookup_deps(package_ids: HashSet, packages: Vec) -> Vec { [INFO] [stdout] | ------------------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 214 | let mut packages: HashMap<_, _> = packages [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | / package_ids [INFO] [stdout] 219 | | .into_iter() [INFO] [stdout] 220 | | .map(|id| packages.remove(&id).expect("Missing package {id:?}")) [INFO] [stdout] 221 | | .filter(|package| package.source.is_some()) [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:220:19 [INFO] [stdout] | [INFO] [stdout] 220 | .map(|id| packages.remove(&id).expect("Missing package {id:?}")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:362:5 [INFO] [stdout] | [INFO] [stdout] 357 | fn output_table(records: Vec, writer: impl Write) -> Result<()> { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 358 | let mut csv = csv::Writer::from_writer(writer); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 362 | csv.flush().map_err(Into::into) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dd-rust-license-tool` (bin "dd-rust-license-tool" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `dd-rust-license-tool` (bin "dd-rust-license-tool") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "6c2de8ba05248e8c137e1dff56513fddd12b87e87eb1527ff27f28d23976300e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6c2de8ba05248e8c137e1dff56513fddd12b87e87eb1527ff27f28d23976300e", kill_on_drop: false }` [INFO] [stdout] 6c2de8ba05248e8c137e1dff56513fddd12b87e87eb1527ff27f28d23976300e