[INFO] cloning repository https://github.com/DatAsianBoi123/nt_client [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DatAsianBoi123/nt_client" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDatAsianBoi123%2Fnt_client", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDatAsianBoi123%2Fnt_client'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 230a896a9cfb91aaa27aef2714a83c66e61e4227 [INFO] checking DatAsianBoi123/nt_client/230a896a9cfb91aaa27aef2714a83c66e61e4227 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDatAsianBoi123%2Fnt_client" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DatAsianBoi123/nt_client on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DatAsianBoi123/nt_client [INFO] finished tweaking git repo https://github.com/DatAsianBoi123/nt_client [INFO] tweaked toml for git repo https://github.com/DatAsianBoi123/nt_client written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DatAsianBoi123/nt_client already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d0a0ec77c19f63fb9a5e4e4af27de80c898734435f6eb5bd18b76f1398ab8b73 [INFO] running `Command { std: "docker" "start" "-a" "d0a0ec77c19f63fb9a5e4e4af27de80c898734435f6eb5bd18b76f1398ab8b73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d0a0ec77c19f63fb9a5e4e4af27de80c898734435f6eb5bd18b76f1398ab8b73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d0a0ec77c19f63fb9a5e4e4af27de80c898734435f6eb5bd18b76f1398ab8b73", kill_on_drop: false }` [INFO] [stdout] d0a0ec77c19f63fb9a5e4e4af27de80c898734435f6eb5bd18b76f1398ab8b73 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e7c64767904a055c542d7ea25a1af90e11c7b72e156fb335c678b2d20918aeb [INFO] running `Command { std: "docker" "start" "-a" "2e7c64767904a055c542d7ea25a1af90e11c7b72e156fb335c678b2d20918aeb", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking rmp v0.8.14 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-stream-impl v0.3.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking async-stream v0.3.5 [INFO] [stderr] Checking tokio v1.39.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking tokio-tungstenite v0.23.1 [INFO] [stderr] Checking tokio-test v0.4.4 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking rmp-serde v1.3.0 [INFO] [stderr] Checking rmpv v1.3.0 [INFO] [stderr] Checking nt_client v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variant `SetProperties` is never constructed [INFO] [stdout] --> src/data.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) enum ServerboundTextData { [INFO] [stdout] | ------------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 23 | SetProperties(SetProperties), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ServerboundTextData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/data.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | Properties(PropertiesData), [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ClientboundTextData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 71 | Properties(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `ack` are never read [INFO] [stdout] --> src/data.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 90 | pub(crate) struct PropertiesData { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 91 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 92 | pub ack: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PropertiesData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:38 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn topic(&self, name: impl ToString) -> Topic { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Topic::new(name.to_string(), self.time(), self.announced_topics.clone(), self.send_ws.0.clone(), self.recv_ws.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:51 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn topic(&self, name: impl ToString) -> Topic { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Topic::new(name.to_string(), self.time(), self.announced_topics.clone(), self.send_ws.0.clone(), self.recv_ws.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:82 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn topic(&self, name: impl ToString) -> Topic { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Topic::new(name.to_string(), self.time(), self.announced_topics.clone(), self.send_ws.0.clone(), self.recv_ws.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:106 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn topic(&self, name: impl ToString) -> Topic { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Topic::new(name.to_string(), self.time(), self.announced_topics.clone(), self.send_ws.0.clone(), self.recv_ws.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:162:22 [INFO] [stdout] | [INFO] [stdout] 157 | pong_recv: Arc, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | ws_sender: NTServerSender, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 163 | | let mut interval = interval(ping_interval); [INFO] [stdout] 164 | | interval.tick().await; [INFO] [stdout] 165 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:22 [INFO] [stdout] | [INFO] [stdout] 178 | time: Arc>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | ws_sender: NTServerSender, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | mut time_recv: mpsc::Receiver<(Duration, Duration)>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | ) -> JoinHandle> { [INFO] [stdout] 182 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 183 | | let mut interval = interval(update_time_interval); [INFO] [stdout] 184 | | loop { [INFO] [stdout] 185 | | interval.tick().await; [INFO] [stdout] ... | [INFO] [stdout] 212 | | } [INFO] [stdout] 213 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 217 | mut server_recv: NTServerReceiver, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | mut write: SplitSink>, Message>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ) -> JoinHandle> { [INFO] [stdout] 220 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 221 | | while let Ok(message) = server_recv.recv().await { [INFO] [stdout] 222 | | let packet = match &*message { [INFO] [stdout] 223 | | ServerboundMessage::Text(json) => serde_json::to_string(&[json]).map_err(|err| err.into()).map(Message::Text), [INFO] [stdout] ... | [INFO] [stdout] 235 | | Ok(()) [INFO] [stdout] 236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:246:22 [INFO] [stdout] | [INFO] [stdout] 240 | read: SplitStream>>, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | update_time_sender: mpsc::Sender<(Duration, Duration)>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | pong_send: Arc, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | announced_topics: Arc>>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | client_sender: NTClientSender, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | ) -> JoinHandle> { [INFO] [stdout] 246 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 247 | | read.err_into().try_for_each(|message| async { [INFO] [stdout] 248 | | let message = match message { [INFO] [stdout] 249 | | Message::Binary(binary) => { [INFO] [stdout] ... | [INFO] [stdout] 296 | | }).await [INFO] [stdout] 297 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:296:16 [INFO] [stdout] | [INFO] [stdout] 240 | read: SplitStream>>, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | update_time_sender: mpsc::Sender<(Duration, Duration)>, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | pong_send: Arc, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | announced_topics: Arc>>, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | client_sender: NTClientSender, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | }).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/type.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 113 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | iter.into_iter().collect::>().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 240 | / transparent!( [INFO] [stdout] 241 | | /// Raw binary data. [INFO] [stdout] 242 | | #[derive(Clone, Debug)] [INFO] [stdout] 243 | | RawData: vec u8 [INFO] [stdout] 244 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `transparent` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/type.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 113 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | iter.into_iter().collect::>().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 245 | / transparent!( [INFO] [stdout] 246 | | /// Raw RPC data. [INFO] [stdout] 247 | | #[derive(Clone, Debug)] [INFO] [stdout] 248 | | Rpc: vec u8 [INFO] [stdout] 249 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `transparent` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/type.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 113 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | iter.into_iter().collect::>().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 250 | / transparent!( [INFO] [stdout] 251 | | /// Raw protobuf data. [INFO] [stdout] 252 | | #[derive(Clone, Debug)] [INFO] [stdout] 253 | | Protobuf: vec u8 [INFO] [stdout] 254 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `transparent` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subscribe.rs:119:27 [INFO] [stdout] | [INFO] [stdout] 117 | let announced_topics = self.announced_topics.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | async move { [INFO] [stdout] 119 | (*id, announced_topics.read().await[id].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `SetProperties` is never constructed [INFO] [stdout] --> src/data.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 20 | pub(crate) enum ServerboundTextData { [INFO] [stdout] | ------------------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 23 | SetProperties(SetProperties), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ServerboundTextData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/data.rs:71:16 [INFO] [stdout] | [INFO] [stdout] 71 | Properties(PropertiesData), [INFO] [stdout] | ---------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ClientboundTextData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 71 | Properties(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `name` and `ack` are never read [INFO] [stdout] --> src/data.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 90 | pub(crate) struct PropertiesData { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] 91 | pub name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 92 | pub ack: Option, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PropertiesData` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:38 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn topic(&self, name: impl ToString) -> Topic { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Topic::new(name.to_string(), self.time(), self.announced_topics.clone(), self.send_ws.0.clone(), self.recv_ws.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:51 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn topic(&self, name: impl ToString) -> Topic { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Topic::new(name.to_string(), self.time(), self.announced_topics.clone(), self.send_ws.0.clone(), self.recv_ws.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:82 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn topic(&self, name: impl ToString) -> Topic { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Topic::new(name.to_string(), self.time(), self.announced_topics.clone(), self.send_ws.0.clone(), self.recv_ws.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:121:106 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn topic(&self, name: impl ToString) -> Topic { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Topic::new(name.to_string(), self.time(), self.announced_topics.clone(), self.send_ws.0.clone(), self.recv_ws.0.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:162:22 [INFO] [stdout] | [INFO] [stdout] 157 | pong_recv: Arc, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | ws_sender: NTServerSender, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 163 | | let mut interval = interval(ping_interval); [INFO] [stdout] 164 | | interval.tick().await; [INFO] [stdout] 165 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 172 | | } [INFO] [stdout] 173 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:22 [INFO] [stdout] | [INFO] [stdout] 178 | time: Arc>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | ws_sender: NTServerSender, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | mut time_recv: mpsc::Receiver<(Duration, Duration)>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 181 | ) -> JoinHandle> { [INFO] [stdout] 182 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 183 | | let mut interval = interval(update_time_interval); [INFO] [stdout] 184 | | loop { [INFO] [stdout] 185 | | interval.tick().await; [INFO] [stdout] ... | [INFO] [stdout] 212 | | } [INFO] [stdout] 213 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 217 | mut server_recv: NTServerReceiver, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 218 | mut write: SplitSink>, Message>, [INFO] [stdout] | ------------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | ) -> JoinHandle> { [INFO] [stdout] 220 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 221 | | while let Ok(message) = server_recv.recv().await { [INFO] [stdout] 222 | | let packet = match &*message { [INFO] [stdout] 223 | | ServerboundMessage::Text(json) => serde_json::to_string(&[json]).map_err(|err| err.into()).map(Message::Text), [INFO] [stdout] ... | [INFO] [stdout] 235 | | Ok(()) [INFO] [stdout] 236 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:246:22 [INFO] [stdout] | [INFO] [stdout] 240 | read: SplitStream>>, [INFO] [stdout] | ------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | update_time_sender: mpsc::Sender<(Duration, Duration)>, [INFO] [stdout] | ------------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | pong_send: Arc, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | announced_topics: Arc>>, [INFO] [stdout] | ----------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | client_sender: NTClientSender, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 245 | ) -> JoinHandle> { [INFO] [stdout] 246 | tokio::spawn(async move { [INFO] [stdout] | ______________________^ [INFO] [stdout] 247 | | read.err_into().try_for_each(|message| async { [INFO] [stdout] 248 | | let message = match message { [INFO] [stdout] 249 | | Message::Binary(binary) => { [INFO] [stdout] ... | [INFO] [stdout] 296 | | }).await [INFO] [stdout] 297 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:296:16 [INFO] [stdout] | [INFO] [stdout] 240 | read: SplitStream>>, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | update_time_sender: mpsc::Sender<(Duration, Duration)>, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | pong_send: Arc, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 243 | announced_topics: Arc>>, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 244 | client_sender: NTClientSender, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | }).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/type.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 113 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | iter.into_iter().collect::>().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 240 | / transparent!( [INFO] [stdout] 241 | | /// Raw binary data. [INFO] [stdout] 242 | | #[derive(Clone, Debug)] [INFO] [stdout] 243 | | RawData: vec u8 [INFO] [stdout] 244 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `transparent` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/type.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 113 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | iter.into_iter().collect::>().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 245 | / transparent!( [INFO] [stdout] 246 | | /// Raw RPC data. [INFO] [stdout] 247 | | #[derive(Clone, Debug)] [INFO] [stdout] 248 | | Rpc: vec u8 [INFO] [stdout] 249 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `transparent` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/data/type.rs:114:17 [INFO] [stdout] | [INFO] [stdout] 113 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | iter.into_iter().collect::>().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 250 | / transparent!( [INFO] [stdout] 251 | | /// Raw protobuf data. [INFO] [stdout] 252 | | #[derive(Clone, Debug)] [INFO] [stdout] 253 | | Protobuf: vec u8 [INFO] [stdout] 254 | | ); [INFO] [stdout] | |_- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `transparent` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/subscribe.rs:119:27 [INFO] [stdout] | [INFO] [stdout] 117 | let announced_topics = self.announced_topics.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | async move { [INFO] [stdout] 119 | (*id, announced_topics.read().await[id].clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nt_client` (lib) due to 14 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 13 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nt_client` (lib test) due to 14 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "2e7c64767904a055c542d7ea25a1af90e11c7b72e156fb335c678b2d20918aeb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e7c64767904a055c542d7ea25a1af90e11c7b72e156fb335c678b2d20918aeb", kill_on_drop: false }` [INFO] [stdout] 2e7c64767904a055c542d7ea25a1af90e11c7b72e156fb335c678b2d20918aeb