[INFO] updating cached repository https://github.com/DasBlackfur/goldmine-mc [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "-c" "remote.origin.fetch=refs/heads/*:refs/heads/*" "fetch" "origin" "--force" "--prune", kill_on_drop: false }` [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7e55ec3f761feea625ec37076759376d87246e6a [INFO] checking DasBlackfur/goldmine-mc/7e55ec3f761feea625ec37076759376d87246e6a against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDasBlackfur%2Fgoldmine-mc" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DasBlackfur/goldmine-mc on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DasBlackfur/goldmine-mc [INFO] finished tweaking git repo https://github.com/DasBlackfur/goldmine-mc [INFO] tweaked toml for git repo https://github.com/DasBlackfur/goldmine-mc written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DasBlackfur/goldmine-mc already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 999c0e451cebc8d60217aece47b9838c9309915aef90b19727a5c57c9f1c4084 [INFO] running `Command { std: "docker" "start" "-a" "999c0e451cebc8d60217aece47b9838c9309915aef90b19727a5c57c9f1c4084", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "999c0e451cebc8d60217aece47b9838c9309915aef90b19727a5c57c9f1c4084", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "999c0e451cebc8d60217aece47b9838c9309915aef90b19727a5c57c9f1c4084", kill_on_drop: false }` [INFO] [stdout] 999c0e451cebc8d60217aece47b9838c9309915aef90b19727a5c57c9f1c4084 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 074d83828e6be1b355492b45cf95ba87cc5171db1ad1e3425d72e36c25cd6e41 [INFO] running `Command { std: "docker" "start" "-a" "074d83828e6be1b355492b45cf95ba87cc5171db1ad1e3425d72e36c25cd6e41", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling cc v1.0.95 [INFO] [stderr] Compiling either v1.11.0 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling serde v1.0.198 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling luau0-src v0.8.6+luau622 [INFO] [stderr] Compiling lua-src v546.0.2 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking libloading v0.8.3 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Compiling which v6.0.1 [INFO] [stderr] Compiling luajit-src v210.5.7+d06beb0 [INFO] [stderr] Compiling mlua-sys v0.5.2 [INFO] [stderr] Compiling serde_derive v1.0.198 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling declio_derive v0.2.0 [INFO] [stderr] Checking declio v0.2.0 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking erased-serde v0.4.4 [INFO] [stderr] Checking serde_json v1.0.116 [INFO] [stderr] Checking mlua v0.9.7 [INFO] [stderr] Checking goldmine-lib v0.1.0 (/opt/rustwide/workdir/goldmine-lib) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> goldmine-lib/src/modded/module.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 14 | registries: Arc>>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | ) -> Result { [INFO] [stdout] 16 | let gm_module = lua.create_table()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | let registry_handle = registries.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let register_mod = lua.create_function(move |lua, lua_mod: Table| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(lua.create_registry_value(gm_module)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> goldmine-lib/src/modded/module.rs:92:15 [INFO] [stdout] | [INFO] [stdout] 81 | let registry_handle = registries.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let get_func = lua.create_function(move |lua, arg: String| { [INFO] [stdout] 83 | let registries_lock = registry_handle.lock(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let registries_handle = registries_lock.borrow(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | match registry.get(&arg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> goldmine-lib/src/modded/module.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 98 | let registry_handle = registries.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let values_func = lua.create_function(move |lua, ()| { [INFO] [stdout] 100 | let registries_lock = registry_handle.lock(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let registries_handle = registries_lock.borrow_mut(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Ok(registry [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | .values() [INFO] [stdout] 111 | | .map(|key| lua.registry_value(key).unwrap()) [INFO] [stdout] 112 | | .collect::>()) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> goldmine-lib/src/modded/module.rs:111:24 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|key| lua.registry_value(key).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goldmine-lib` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> goldmine-lib/src/modded/module.rs:34:8 [INFO] [stdout] | [INFO] [stdout] 14 | registries: Arc>>, [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 15 | ) -> Result { [INFO] [stdout] 16 | let gm_module = lua.create_table()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | [INFO] [stdout] 18 | let registry_handle = registries.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let register_mod = lua.create_function(move |lua, lua_mod: Table| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(lua.create_registry_value(gm_module)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> goldmine-lib/src/modded/module.rs:92:15 [INFO] [stdout] | [INFO] [stdout] 81 | let registry_handle = registries.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let get_func = lua.create_function(move |lua, arg: String| { [INFO] [stdout] 83 | let registries_lock = registry_handle.lock(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | let registries_handle = registries_lock.borrow(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | match registry.get(&arg) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> goldmine-lib/src/modded/module.rs:109:12 [INFO] [stdout] | [INFO] [stdout] 98 | let registry_handle = registries.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | let values_func = lua.create_function(move |lua, ()| { [INFO] [stdout] 100 | let registries_lock = registry_handle.lock(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let registries_handle = registries_lock.borrow_mut(); [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | Ok(registry [INFO] [stdout] | ____________^ [INFO] [stdout] 110 | | .values() [INFO] [stdout] 111 | | .map(|key| lua.registry_value(key).unwrap()) [INFO] [stdout] 112 | | .collect::>()) [INFO] [stdout] | |____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> goldmine-lib/src/modded/module.rs:111:24 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|key| lua.registry_value(key).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `goldmine-lib` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "074d83828e6be1b355492b45cf95ba87cc5171db1ad1e3425d72e36c25cd6e41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "074d83828e6be1b355492b45cf95ba87cc5171db1ad1e3425d72e36c25cd6e41", kill_on_drop: false }` [INFO] [stdout] 074d83828e6be1b355492b45cf95ba87cc5171db1ad1e3425d72e36c25cd6e41