[INFO] cloning repository https://github.com/DaniloDjokic/rust_synth [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DaniloDjokic/rust_synth" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaniloDjokic%2Frust_synth", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaniloDjokic%2Frust_synth'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] afb4b952f3fc5206254c1785fe544613d0d2bc4e [INFO] checking DaniloDjokic/rust_synth/afb4b952f3fc5206254c1785fe544613d0d2bc4e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaniloDjokic%2Frust_synth" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DaniloDjokic/rust_synth on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DaniloDjokic/rust_synth [INFO] finished tweaking git repo https://github.com/DaniloDjokic/rust_synth [INFO] tweaked toml for git repo https://github.com/DaniloDjokic/rust_synth written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DaniloDjokic/rust_synth already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28ba09cb68d75a589850152671021c61c4a58fbe302b9c202f4895c303eda81a [INFO] running `Command { std: "docker" "start" "-a" "28ba09cb68d75a589850152671021c61c4a58fbe302b9c202f4895c303eda81a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28ba09cb68d75a589850152671021c61c4a58fbe302b9c202f4895c303eda81a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28ba09cb68d75a589850152671021c61c4a58fbe302b9c202f4895c303eda81a", kill_on_drop: false }` [INFO] [stdout] 28ba09cb68d75a589850152671021c61c4a58fbe302b9c202f4895c303eda81a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f9b67dd46689f25a978ec11bda4943fbc6a664025393217459992c2c4656f7f [INFO] running `Command { std: "docker" "start" "-a" "1f9b67dd46689f25a978ec11bda4943fbc6a664025393217459992c2c4656f7f", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling serde v1.0.192 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking winnow v0.5.15 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Compiling cpal v0.15.2 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling x11 v2.21.0 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking mio v0.8.9 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking alsa v0.7.1 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.4 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking rdev v0.5.3 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking rust_synth v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variants `Square`, `Triangle`, `AnalogSaw`, and `DigitalSaw` are never constructed [INFO] [stdout] --> src/sample_generator/oscilator.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub enum Oscilator { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 17 | Sine, [INFO] [stdout] 18 | Square, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 19 | Triangle, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 20 | AnalogSaw(u32), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 21 | DigitalSaw, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/sample_generator/instrument/epiano.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl EPiano { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 15 | pub fn new(channel: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_base_frequency` is never used [INFO] [stdout] --> src/sample_generator/note.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Note { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn get_base_frequency(&self) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sample_generator.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 26 | performance_info_tx: Sender, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | note_info_tx: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | instruments: Vec>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | listener: InputListener, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | input_receiver: Receiver, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | sequencer: Option [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> Self { [INFO] [stdout] 33 | let note_collection = ActiveNotes::new(clock.proc_clock()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | proc_clock: clock.proc_clock(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sample_generator.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 26 | performance_info_tx: Sender, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | note_info_tx: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | instruments: Vec>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | listener: InputListener, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | input_receiver: Receiver, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | sequencer: Option [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> Self { [INFO] [stdout] 33 | let note_collection = ActiveNotes::new(clock.proc_clock()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | real_time_clock: clock.real_time_clock(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/input_listener.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn start_listen(self, clock: Arc>) -> JoinHandle<()> { [INFO] [stdout] | ---- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 29 | | let (tx, rx) = mpsc::channel(); [INFO] [stdout] 30 | | io_listener::io_listen(tx, clock); [INFO] [stdout] 31 | | self.handle_events(rx); [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_synth` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variants `Square`, `Triangle`, `AnalogSaw`, and `DigitalSaw` are never constructed [INFO] [stdout] --> src/sample_generator/oscilator.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub enum Oscilator { [INFO] [stdout] | --------- variants in this enum [INFO] [stdout] 17 | Sine, [INFO] [stdout] 18 | Square, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 19 | Triangle, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 20 | AnalogSaw(u32), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 21 | DigitalSaw, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/sample_generator/instrument/epiano.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 14 | impl EPiano { [INFO] [stdout] | ----------- associated function in this implementation [INFO] [stdout] 15 | pub fn new(channel: usize) -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_base_frequency` is never used [INFO] [stdout] --> src/sample_generator/note.rs:35:12 [INFO] [stdout] | [INFO] [stdout] 13 | impl Note { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 35 | pub fn get_base_frequency(&self) -> f32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sample_generator.rs:37:25 [INFO] [stdout] | [INFO] [stdout] 26 | performance_info_tx: Sender, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | note_info_tx: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | instruments: Vec>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | listener: InputListener, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | input_receiver: Receiver, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | sequencer: Option [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> Self { [INFO] [stdout] 33 | let note_collection = ActiveNotes::new(clock.proc_clock()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | proc_clock: clock.proc_clock(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sample_generator.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 26 | performance_info_tx: Sender, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | note_info_tx: Sender, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | instruments: Vec>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | listener: InputListener, [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | input_receiver: Receiver, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | sequencer: Option [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 32 | ) -> Self { [INFO] [stdout] 33 | let note_collection = ActiveNotes::new(clock.proc_clock()); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | real_time_clock: clock.real_time_clock(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input/input_listener.rs:28:23 [INFO] [stdout] | [INFO] [stdout] 27 | pub fn start_listen(self, clock: Arc>) -> JoinHandle<()> { [INFO] [stdout] | ---- ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 29 | | let (tx, rx) = mpsc::channel(); [INFO] [stdout] 30 | | io_listener::io_listen(tx, clock); [INFO] [stdout] 31 | | self.handle_events(rx); [INFO] [stdout] 32 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rust_synth` (lib) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1f9b67dd46689f25a978ec11bda4943fbc6a664025393217459992c2c4656f7f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f9b67dd46689f25a978ec11bda4943fbc6a664025393217459992c2c4656f7f", kill_on_drop: false }` [INFO] [stdout] 1f9b67dd46689f25a978ec11bda4943fbc6a664025393217459992c2c4656f7f