[INFO] cloning repository https://github.com/Daniel-Aaron-Bloom/Simple-Transaction-Manager [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Daniel-Aaron-Bloom/Simple-Transaction-Manager" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaniel-Aaron-Bloom%2FSimple-Transaction-Manager", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaniel-Aaron-Bloom%2FSimple-Transaction-Manager'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 06b89b5e4990e468a09af39f5f5901c96d3b0423 [INFO] checking Daniel-Aaron-Bloom/Simple-Transaction-Manager/06b89b5e4990e468a09af39f5f5901c96d3b0423 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDaniel-Aaron-Bloom%2FSimple-Transaction-Manager" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Daniel-Aaron-Bloom/Simple-Transaction-Manager on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Daniel-Aaron-Bloom/Simple-Transaction-Manager [INFO] finished tweaking git repo https://github.com/Daniel-Aaron-Bloom/Simple-Transaction-Manager [INFO] tweaked toml for git repo https://github.com/Daniel-Aaron-Bloom/Simple-Transaction-Manager written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Daniel-Aaron-Bloom/Simple-Transaction-Manager already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4bcdf2788c3670a72057b791ffc3a91fe3576b0a5e059153b9edd1c49ab58a16 [INFO] running `Command { std: "docker" "start" "-a" "4bcdf2788c3670a72057b791ffc3a91fe3576b0a5e059153b9edd1c49ab58a16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4bcdf2788c3670a72057b791ffc3a91fe3576b0a5e059153b9edd1c49ab58a16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4bcdf2788c3670a72057b791ffc3a91fe3576b0a5e059153b9edd1c49ab58a16", kill_on_drop: false }` [INFO] [stdout] 4bcdf2788c3670a72057b791ffc3a91fe3576b0a5e059153b9edd1c49ab58a16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0d8256257112a8c361eac5ba6eeaa2031765145251204ad690a55d4706e247e0 [INFO] running `Command { std: "docker" "start" "-a" "0d8256257112a8c361eac5ba6eeaa2031765145251204ad690a55d4706e247e0", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Checking futures-core v0.3.12 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling libc v0.2.84 [INFO] [stderr] Checking futures-sink v0.3.12 [INFO] [stderr] Checking futures-task v0.3.12 [INFO] [stderr] Checking futures-channel v0.3.12 [INFO] [stderr] Checking futures-io v0.3.12 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling event-listener v2.5.1 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling async-mutex v1.4.0 [INFO] [stderr] Compiling cached_proc_macro_types v0.1.0 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking rand_core v0.6.1 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling futures-macro v0.3.12 [INFO] [stderr] Compiling async-trait v0.1.42 [INFO] [stderr] Checking futures-util v0.3.12 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling cached_proc_macro v0.6.0 [INFO] [stderr] Checking futures-executor v0.3.12 [INFO] [stderr] Checking futures v0.3.12 [INFO] [stderr] Checking cached v0.23.0 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking csv v1.1.5 [INFO] [stderr] Checking simple_transaction_manager v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/decimal.rs:198:10 [INFO] [stdout] | [INFO] [stdout] 198 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/decimal.rs:198:10 [INFO] [stdout] | [INFO] [stdout] 198 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/client.rs:167:9 [INFO] [stdout] | [INFO] [stdout] 167 | c.chargeback_deposit(Decimal::zero()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 167 | let _ = c.chargeback_deposit(Decimal::zero()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 22 | #[derive(Serialize, Deserialize, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 111 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ) -> io::Result>> { [INFO] [stdout] 113 | Ok(ReaderBuilder::new() [INFO] [stdout] | ________^ [INFO] [stdout] 114 | | .trim(Trim::All) [INFO] [stdout] 115 | | .from_path(path)? [INFO] [stdout] 116 | | .into_deserialize()) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn read_from_csv_reader(rdr: R) -> impl Iterator> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | / ReaderBuilder::new() [INFO] [stdout] 122 | | .trim(Trim::All) [INFO] [stdout] 123 | | .from_reader(rdr) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:22:21 [INFO] [stdout] | [INFO] [stdout] 22 | #[derive(Serialize, Deserialize, Debug, PartialEq, Eq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:113:8 [INFO] [stdout] | [INFO] [stdout] 111 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | ) -> io::Result>> { [INFO] [stdout] 113 | Ok(ReaderBuilder::new() [INFO] [stdout] | ________^ [INFO] [stdout] 114 | | .trim(Trim::All) [INFO] [stdout] 115 | | .from_path(path)? [INFO] [stdout] 116 | | .into_deserialize()) [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transaction.rs:121:5 [INFO] [stdout] | [INFO] [stdout] 120 | pub fn read_from_csv_reader(rdr: R) -> impl Iterator> { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | / ReaderBuilder::new() [INFO] [stdout] 122 | | .trim(Trim::All) [INFO] [stdout] 123 | | .from_reader(rdr) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple_transaction_manager` (bin "simple_transaction_manager" test) due to 4 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `simple_transaction_manager` (bin "simple_transaction_manager") due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "0d8256257112a8c361eac5ba6eeaa2031765145251204ad690a55d4706e247e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0d8256257112a8c361eac5ba6eeaa2031765145251204ad690a55d4706e247e0", kill_on_drop: false }` [INFO] [stdout] 0d8256257112a8c361eac5ba6eeaa2031765145251204ad690a55d4706e247e0