[INFO] cloning repository https://github.com/DanConwayDev/ngit-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DanConwayDev/ngit-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDanConwayDev%2Fngit-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDanConwayDev%2Fngit-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 36763dc0d821425e088adefd16dc7c4bf3b30f3b [INFO] checking DanConwayDev/ngit-cli/36763dc0d821425e088adefd16dc7c4bf3b30f3b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDanConwayDev%2Fngit-cli" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DanConwayDev/ngit-cli on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DanConwayDev/ngit-cli [INFO] finished tweaking git repo https://github.com/DanConwayDev/ngit-cli [INFO] tweaked toml for git repo https://github.com/DanConwayDev/ngit-cli written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DanConwayDev/ngit-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c4f488bfbec7b5e4d624846f3800dd74a189a3a579fe90725615405dca8bc072 [INFO] running `Command { std: "docker" "start" "-a" "c4f488bfbec7b5e4d624846f3800dd74a189a3a579fe90725615405dca8bc072", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c4f488bfbec7b5e4d624846f3800dd74a189a3a579fe90725615405dca8bc072", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c4f488bfbec7b5e4d624846f3800dd74a189a3a579fe90725615405dca8bc072", kill_on_drop: false }` [INFO] [stdout] c4f488bfbec7b5e4d624846f3800dd74a189a3a579fe90725615405dca8bc072 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8a1cb201fef8aed395c5024368ca7fc7863c0d7c53ce6102b5e483795ca4b623 [INFO] running `Command { std: "docker" "start" "-a" "8a1cb201fef8aed395c5024368ca7fc7863c0d7c53ce6102b5e483795ca4b623", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.80 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking rustls-pki-types v1.4.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Compiling rustls v0.22.3 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking opaque-debug v0.3.1 [INFO] [stderr] Checking webpki-roots v0.26.1 [INFO] [stderr] Compiling serde_json v1.0.115 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking base64 v0.22.0 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Checking hex-conservative v0.1.1 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Compiling bitcoin v0.31.2 [INFO] [stderr] Compiling rustls v0.23.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking bech32 v0.10.0-beta [INFO] [stderr] Checking bitcoin_hashes v0.11.0 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Checking negentropy v0.3.1 [INFO] [stderr] Compiling jobserver v0.1.30 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking concurrent-queue v2.4.0 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling cc v1.0.94 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking event-listener v4.0.3 [INFO] [stderr] Checking event-listener v5.3.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Checking futures-lite v2.3.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Checking event-listener-strategy v0.4.0 [INFO] [stderr] Compiling syn v2.0.59 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking lru v0.12.3 [INFO] [stderr] Checking event-listener-strategy v0.5.1 [INFO] [stderr] Checking piper v0.2.1 [INFO] [stderr] Checking async-lock v3.3.0 [INFO] [stderr] Checking async-channel v2.2.1 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Compiling regex v1.10.4 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking parking_lot_core v0.9.9 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking poly1305 v0.8.0 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Compiling libz-sys v1.1.16 [INFO] [stderr] Compiling libssh2-sys v0.3.0 [INFO] [stderr] Compiling libgit2-sys v0.16.2+1.7.2 [INFO] [stderr] Checking chacha20 v0.9.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking rustix v0.37.27 [INFO] [stderr] Checking chacha20poly1305 v0.10.1 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking xdg-home v1.1.0 [INFO] [stderr] Checking num-iter v0.1.44 [INFO] [stderr] Checking num-complex v0.4.5 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking async-executor v1.11.0 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking block-padding v0.2.1 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking block-modes v0.8.1 [INFO] [stderr] Checking dialoguer v0.10.4 [INFO] [stderr] Checking num v0.4.2 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking nanorand v0.7.0 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking comma v1.0.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking linux-keyutils v0.2.4 [INFO] [stderr] Checking nix v0.27.1 [INFO] [stderr] Checking terminal-prompt v0.2.3 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking predicates v2.1.5 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling enumflags2_derive v0.7.9 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling async-recursion v1.1.0 [INFO] [stderr] Checking rustls-webpki v0.102.2 [INFO] [stderr] Compiling random-number-macro-impl v0.1.7 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Compiling serde_repr v0.1.19 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking random-number v0.1.8 [INFO] [stderr] Checking random-pick v1.2.16 [INFO] [stderr] Checking passwords v3.1.16 [INFO] [stderr] Compiling mockall_derive v0.11.4 [INFO] [stderr] Compiling serial_test_derive v2.0.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking thiserror v1.0.58 [INFO] [stderr] Checking flume v0.10.14 [INFO] [stderr] Checking rexpect v0.5.0 (https://github.com/rust-cli/rexpect.git?rev=9eb61dd#9eb61dd4) [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling duplicate v1.0.0 [INFO] [stderr] Checking atomic-destructor v0.2.0 [INFO] [stderr] Checking blocking v1.5.1 [INFO] [stderr] Checking rexpect v0.5.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tungstenite v0.23.0 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking serial_test v2.0.0 [INFO] [stderr] Checking mockall v0.11.4 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper v1.3.0 [INFO] [stderr] Checking tokio-rustls v0.25.0 [INFO] [stderr] Checking tokio-socks v0.5.1 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking async-utility v0.2.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking bip39 v2.0.0 [INFO] [stderr] Checking enumflags2 v0.7.9 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking tokio-tungstenite v0.23.0 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking tungstenite v0.20.1 [INFO] [stderr] Checking async-wsocket v0.7.1 [INFO] [stderr] Checking git2 v0.18.3 [INFO] [stderr] Checking tokio-tungstenite v0.20.1 [INFO] [stderr] Checking hyper-rustls v0.26.0 [INFO] [stderr] Checking simple-websockets v0.1.6 (https://github.com/DanConwayDev/simple-websockets?branch=auto-release-port#f53d7662) [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Checking reqwest v0.12.3 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking lnurl-pay v0.5.0 [INFO] [stderr] Checking auth-git2 v0.5.4 [INFO] [stderr] Checking nostr v0.34.1 [INFO] [stderr] Checking secret-service v3.0.1 [INFO] [stderr] Checking keyring v2.3.2 [INFO] [stderr] Checking nostr-database v0.34.0 [INFO] [stderr] Checking nostr-zapper v0.34.0 [INFO] [stderr] Checking nostr-relay-pool v0.34.0 [INFO] [stderr] Checking nostr-sqlite v0.34.0 [INFO] [stderr] Checking nwc v0.34.1 [INFO] [stderr] Checking nostr-signer v0.34.0 [INFO] [stderr] Checking nostr-sdk v0.34.0 [INFO] [stderr] Checking test_utils v0.1.0 (/opt/rustwide/workdir/test_utils) [INFO] [stderr] Checking ngit v1.4.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | Lazy::new(|| nostr::Keys::from_str(TEST_KEY_1_NSEC).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:39:36 [INFO] [stdout] | [INFO] [stdout] 39 | Lazy::new(|| NostrSigner::Keys(nostr::Keys::from_str(TEST_KEY_1_NSEC).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | Lazy::new(|| nostr::Keys::from_str(TEST_KEY_2_NSEC).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 36 | Lazy::new(|| nostr::Keys::from_str(TEST_KEY_1_NSEC).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:39:36 [INFO] [stdout] | [INFO] [stdout] 39 | Lazy::new(|| NostrSigner::Keys(nostr::Keys::from_str(TEST_KEY_1_NSEC).unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 116 | Lazy::new(|| nostr::Keys::from_str(TEST_KEY_2_NSEC).unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:708:30 [INFO] [stdout] | [INFO] [stdout] 702 | pub fn new(args: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 708 | rexpect_session: rexpect_with(args, 4000).expect("rexpect to spawn new process"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:718:30 [INFO] [stdout] | [INFO] [stdout] 712 | pub fn new_from_dir(dir: &PathBuf, args: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 718 | rexpect_session: rexpect_with_from_dir(dir, args, 4000) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 719 | | .expect("rexpect to spawn new process"), [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:729:30 [INFO] [stdout] | [INFO] [stdout] 723 | pub fn new_with_timeout_from_dir(timeout_ms: u64, dir: &PathBuf, args: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 729 | rexpect_session: rexpect_with_from_dir(dir, args, timeout_ms) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 730 | | .expect("rexpect to spawn new process"), [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:749:30 [INFO] [stdout] | [INFO] [stdout] 743 | pub fn new_git_with_remote_helper_from_dir(dir: &PathBuf, args: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 749 | rexpect_session: git_with_remote_helper_rexpect_with_from_dir(dir, args, 4000) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 750 | | .expect("rexpect to spawn new process"), [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:708:30 [INFO] [stdout] | [INFO] [stdout] 702 | pub fn new(args: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 708 | rexpect_session: rexpect_with(args, 4000).expect("rexpect to spawn new process"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:718:30 [INFO] [stdout] | [INFO] [stdout] 712 | pub fn new_from_dir(dir: &PathBuf, args: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 718 | rexpect_session: rexpect_with_from_dir(dir, args, 4000) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 719 | | .expect("rexpect to spawn new process"), [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:729:30 [INFO] [stdout] | [INFO] [stdout] 723 | pub fn new_with_timeout_from_dir(timeout_ms: u64, dir: &PathBuf, args: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 729 | rexpect_session: rexpect_with_from_dir(dir, args, timeout_ms) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 730 | | .expect("rexpect to spawn new process"), [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:749:30 [INFO] [stdout] | [INFO] [stdout] 743 | pub fn new_git_with_remote_helper_from_dir(dir: &PathBuf, args: I) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 749 | rexpect_session: git_with_remote_helper_rexpect_with_from_dir(dir, args, 4000) [INFO] [stdout] | ______________________________^ [INFO] [stdout] 750 | | .expect("rexpect to spawn new process"), [INFO] [stdout] | |_______________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:1043:5 [INFO] [stdout] | [INFO] [stdout] 1004 | args: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1036 | let mut cmd = std::process::Command::new("git"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1043 | / rexpect::session::spawn_with_options( [INFO] [stdout] 1044 | | cmd, [INFO] [stdout] 1045 | | Options { [INFO] [stdout] 1046 | | timeout_ms: Some(timeout_ms), [INFO] [stdout] 1047 | | strip_ansi_escape_codes: true, [INFO] [stdout] 1048 | | }, [INFO] [stdout] 1049 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:1356:8 [INFO] [stdout] | [INFO] [stdout] 1331 | let (_, test_repo) = create_proposals_and_repo_with_proposal_pulled_and_checkedout(1)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1335 | let second_originating_repo = GitTestRepo::default(); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1356 | Ok((second_originating_repo, test_repo)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:1412:8 [INFO] [stdout] | [INFO] [stdout] 1391 | let (originating_repo, test_repo) = [INFO] [stdout] | ---------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1398 | let mut p = CliTester::new_from_dir( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1412 | Ok((originating_repo, test_repo)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 48 | let git_repo = git2::Repository::init_opts( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | dir: path, [INFO] [stdout] 59 | | git_repo, [INFO] [stdout] 60 | | delete_dir_on_drop: true, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 68 | let git_repo = git2::Repository::open(path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | dir: path.clone(), [INFO] [stdout] 71 | | git_repo, [INFO] [stdout] 72 | | delete_dir_on_drop: true, [INFO] [stdout] 73 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:1043:5 [INFO] [stdout] | [INFO] [stdout] 1004 | args: I, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1036 | let mut cmd = std::process::Command::new("git"); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1043 | / rexpect::session::spawn_with_options( [INFO] [stdout] 1044 | | cmd, [INFO] [stdout] 1045 | | Options { [INFO] [stdout] 1046 | | timeout_ms: Some(timeout_ms), [INFO] [stdout] 1047 | | strip_ansi_escape_codes: true, [INFO] [stdout] 1048 | | }, [INFO] [stdout] 1049 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 93 | let git_repo = git2::Repository::open(path.clone())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | dir: path, [INFO] [stdout] 99 | | git_repo, [INFO] [stdout] 100 | | delete_dir_on_drop: true, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 107 | let git_repo = git2::Repository::init_opts( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let tmp_repo = Self::duplicate(existing_repo)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | // add bare as a remote and push branches [INFO] [stdout] 117 | let mut remote = tmp_repo.git_repo.remote("tmp", path.to_str().unwrap())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 133 | | dir: path, [INFO] [stdout] 134 | | git_repo, [INFO] [stdout] 135 | | delete_dir_on_drop: true, [INFO] [stdout] 136 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:1356:8 [INFO] [stdout] | [INFO] [stdout] 1331 | let (_, test_repo) = create_proposals_and_repo_with_proposal_pulled_and_checkedout(1)?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1335 | let second_originating_repo = GitTestRepo::default(); [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1356 | Ok((second_originating_repo, test_repo)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 141 | let git_repo = git2::Repository::clone(existing_repo.dir.to_str().unwrap(), path.clone())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 143 | | dir: path, [INFO] [stdout] 144 | | git_repo, [INFO] [stdout] 145 | | delete_dir_on_drop: true, [INFO] [stdout] 146 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:269:12 [INFO] [stdout] | [INFO] [stdout] 265 | let branch = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | Ok(branch.into_reference().peel_to_commit()?.id()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/relay.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 28 | let event_hub = simple_websockets::launch(port) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | clients: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/lib.rs:1412:8 [INFO] [stdout] | [INFO] [stdout] 1391 | let (originating_repo, test_repo) = [INFO] [stdout] | ---------------- --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1398 | let mut p = CliTester::new_from_dir( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1412 | Ok((originating_repo, test_repo)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 48 | let git_repo = git2::Repository::init_opts( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | dir: path, [INFO] [stdout] 59 | | git_repo, [INFO] [stdout] 60 | | delete_dir_on_drop: true, [INFO] [stdout] 61 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:69:12 [INFO] [stdout] | [INFO] [stdout] 68 | let git_repo = git2::Repository::open(path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 70 | | dir: path.clone(), [INFO] [stdout] 71 | | git_repo, [INFO] [stdout] 72 | | delete_dir_on_drop: true, [INFO] [stdout] 73 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 93 | let git_repo = git2::Repository::open(path.clone())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | dir: path, [INFO] [stdout] 99 | | git_repo, [INFO] [stdout] 100 | | delete_dir_on_drop: true, [INFO] [stdout] 101 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 107 | let git_repo = git2::Repository::init_opts( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let tmp_repo = Self::duplicate(existing_repo)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | // add bare as a remote and push branches [INFO] [stdout] 117 | let mut remote = tmp_repo.git_repo.remote("tmp", path.to_str().unwrap())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 133 | | dir: path, [INFO] [stdout] 134 | | git_repo, [INFO] [stdout] 135 | | delete_dir_on_drop: true, [INFO] [stdout] 136 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:142:12 [INFO] [stdout] | [INFO] [stdout] 141 | let git_repo = git2::Repository::clone(existing_repo.dir.to_str().unwrap(), path.clone())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 143 | | dir: path, [INFO] [stdout] 144 | | git_repo, [INFO] [stdout] 145 | | delete_dir_on_drop: true, [INFO] [stdout] 146 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/git.rs:269:12 [INFO] [stdout] | [INFO] [stdout] 265 | let branch = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | Ok(branch.into_reference().peel_to_commit()?.id()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> test_utils/src/relay.rs:35:22 [INFO] [stdout] | [INFO] [stdout] 28 | let event_hub = simple_websockets::launch(port) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 35 | clients: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `test_utils` (lib) due to 18 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `test_utils` (lib test) due to 18 previous errors [INFO] [stdout] warning: associated items `new` and `get_more_fallback_relays` are never used [INFO] [stdout] --> src/client.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 57 | pub trait Connect { [INFO] [stdout] | ------- associated items in this trait [INFO] [stdout] 58 | fn default() -> Self; [INFO] [stdout] 59 | fn new(opts: Params) -> Self; [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 64 | fn get_more_fallback_relays(&self) -> &Vec; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `get_commit_or_tip_of_reference` is never used [INFO] [stdout] --> src/git.rs:47:8 [INFO] [stdout] | [INFO] [stdout] 37 | pub trait RepoActions { [INFO] [stdout] | ----------- method in this trait [INFO] [stdout] ... [INFO] [stdout] 47 | fn get_commit_or_tip_of_reference(&self, reference: &str) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `identifier` and `state` are never read [INFO] [stdout] --> src/repo_state.rs:7:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub struct RepoState { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 7 | pub identifier: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 8 | pub state: HashMap, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `description` is never read [INFO] [stdout] --> src/sub_commands/send.rs:786:9 [INFO] [stdout] | [INFO] [stdout] 784 | pub struct CoverLetter { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 785 | pub title: String, [INFO] [stdout] 786 | pub description: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 141 | fn new(opts: Params) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Client { [INFO] [stdout] 143 | client: nostr_sdk::ClientBuilder::new() [INFO] [stdout] | _____________________^ [INFO] [stdout] 144 | | .opts(Options::new().relay_limits(RelayLimits::disable())) [INFO] [stdout] 145 | | .signer(&opts.keys.unwrap_or(nostr::Keys::generate())) [INFO] [stdout] 146 | | // .database( [INFO] [stdout] 147 | | // SQLiteDatabase::open(get_dirs()?.cache_dir().join("nostr-cache.sqlite")). [INFO] [stdout] 148 | | // await?, ) [INFO] [stdout] 149 | | .build(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:156:57 [INFO] [stdout] | [INFO] [stdout] 156 | async fn set_signer(&mut self, signer: NostrSigner) { [INFO] [stdout] | ____________________________________-------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | | self.client.set_signer(Some(signer)).await; [INFO] [stdout] 158 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:226:36 [INFO] [stdout] | [INFO] [stdout] 225 | filters: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | ) -> Result> { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 227 | | let (relay_results, _) = self [INFO] [stdout] 228 | | .get_events_per_relay( [INFO] [stdout] 229 | | relays.iter().map(|r| Url::parse(r).unwrap()).collect(), [INFO] [stdout] ... | [INFO] [stdout] 234 | | Ok(get_dedup_events(relay_results)) [INFO] [stdout] 235 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:242:66 [INFO] [stdout] | [INFO] [stdout] 240 | filters: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | progress_reporter: MultiProgress, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | ) -> Result<(Vec>>, MultiProgress)> { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 243 | | // add relays [INFO] [stdout] 244 | | for relay in &relays { [INFO] [stdout] 245 | | self.client [INFO] [stdout] ... | [INFO] [stdout] 307 | | Ok((relay_results, progress_reporter)) [INFO] [stdout] 308 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:258:51 [INFO] [stdout] | [INFO] [stdout] 258 | .map(|r| (relays_map.get(r).unwrap(), filters.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:272:23 [INFO] [stdout] | [INFO] [stdout] 259 | .map(|(relay, filters)| async { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | let pb = if std::env::var("NGITTEST").is_err() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let pb = progress_reporter.add( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | match get_events_of(relay, filters, &pb).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:420:27 [INFO] [stdout] | [INFO] [stdout] 393 | .map(|request| async { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let pb = if std::env::var("NGITTEST").is_err() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | let pb = progress_reporter.add( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | match self.fetch_all_from_relay(git_repo_path, request, &pb).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:488:30 [INFO] [stdout] | [INFO] [stdout] 486 | request: FetchRequest, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | pb: &Option, [INFO] [stdout] 488 | ) -> Result { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 489 | | let mut fresh_coordinates: HashSet = HashSet::new(); [INFO] [stdout] 490 | | for (c, _) in request.repo_coordinates_without_relays.clone() { [INFO] [stdout] 491 | | fresh_coordinates.insert(c); [INFO] [stdout] ... | [INFO] [stdout] 586 | | Ok(report) [INFO] [stdout] 587 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:1350:5 [INFO] [stdout] | [INFO] [stdout] 1349 | pub fn get_filter_contributor_profiles(contributors: HashSet) -> nostr::Filter { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1350 | / nostr::Filter::default() [INFO] [stdout] 1351 | | .kinds(vec![Kind::Metadata, Kind::RelayList]) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:222:25 [INFO] [stdout] | [INFO] [stdout] 211 | let branch = if let Ok(branch) = self [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | Ok(oid_to_sha1(&branch.into_reference().peel_to_commit()?.id())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:342:22 [INFO] [stdout] | [INFO] [stdout] 342 | .map(|r| r.unwrap().shorthand().unwrap().to_string()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:826:5 [INFO] [stdout] | [INFO] [stdout] 826 | / git2::Signature::new( [INFO] [stdout] 827 | | v[1].as_str(), [INFO] [stdout] 828 | | v[2].as_str(), [INFO] [stdout] 829 | | &git2::Time::new( [INFO] [stdout] ... | [INFO] [stdout] 833 | | ), [INFO] [stdout] 834 | | ) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo_ref.rs:445:5 [INFO] [stdout] | [INFO] [stdout] 428 | let file = if path.exists() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 445 | / serde_yaml::to_writer( [INFO] [stdout] 446 | | file, [INFO] [stdout] 447 | | &RepoConfigYaml { [INFO] [stdout] 448 | | identifier: Some(identifier), [INFO] [stdout] ... | [INFO] [stdout] 451 | | }, [INFO] [stdout] 452 | | ) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/list.rs:267:28 [INFO] [stdout] | [INFO] [stdout] 267 | .any(|n| n.eq(&cover_letter.get_branch_name().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/pull.rs:54:37 [INFO] [stdout] | [INFO] [stdout] 54 | .is_ok_and(|cl| cl.get_branch_name().is_ok_and(|s| s.eq(&branch_name))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/push.rs:71:37 [INFO] [stdout] | [INFO] [stdout] 71 | .is_ok_and(|cl| cl.get_branch_name().is_ok_and(|s| s.eq(&branch_name))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/send.rs:477:34 [INFO] [stdout] | [INFO] [stdout] 477 | .map(|h| summarise_commit_for_selection(git_repo, h).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/send.rs:1110:11 [INFO] [stdout] | [INFO] [stdout] 1110 | match git_repo.get_commits_ahead_behind(&to_tip, &from_tip) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ngit` (bin "ngit") due to 19 previous errors; 4 warnings emitted [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git_remote_helper.rs:561:21 [INFO] [stdout] | [INFO] [stdout] 561 | .any(|oid| !git_repo.does_commit_exist(oid).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:143:21 [INFO] [stdout] | [INFO] [stdout] 141 | fn new(opts: Params) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 142 | Client { [INFO] [stdout] 143 | client: nostr_sdk::ClientBuilder::new() [INFO] [stdout] | _____________________^ [INFO] [stdout] 144 | | .opts(Options::new().relay_limits(RelayLimits::disable())) [INFO] [stdout] 145 | | .signer(&opts.keys.unwrap_or(nostr::Keys::generate())) [INFO] [stdout] 146 | | // .database( [INFO] [stdout] 147 | | // SQLiteDatabase::open(get_dirs()?.cache_dir().join("nostr-cache.sqlite")). [INFO] [stdout] 148 | | // await?, ) [INFO] [stdout] 149 | | .build(), [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:156:57 [INFO] [stdout] | [INFO] [stdout] 156 | async fn set_signer(&mut self, signer: NostrSigner) { [INFO] [stdout] | ____________________________________-------------------__^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | | self.client.set_signer(Some(signer)).await; [INFO] [stdout] 158 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:226:36 [INFO] [stdout] | [INFO] [stdout] 225 | filters: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 226 | ) -> Result> { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 227 | | let (relay_results, _) = self [INFO] [stdout] 228 | | .get_events_per_relay( [INFO] [stdout] 229 | | relays.iter().map(|r| Url::parse(r).unwrap()).collect(), [INFO] [stdout] ... | [INFO] [stdout] 234 | | Ok(get_dedup_events(relay_results)) [INFO] [stdout] 235 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:242:66 [INFO] [stdout] | [INFO] [stdout] 240 | filters: Vec, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | progress_reporter: MultiProgress, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | ) -> Result<(Vec>>, MultiProgress)> { [INFO] [stdout] | __________________________________________________________________^ [INFO] [stdout] 243 | | // add relays [INFO] [stdout] 244 | | for relay in &relays { [INFO] [stdout] 245 | | self.client [INFO] [stdout] ... | [INFO] [stdout] 307 | | Ok((relay_results, progress_reporter)) [INFO] [stdout] 308 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:258:51 [INFO] [stdout] | [INFO] [stdout] 258 | .map(|r| (relays_map.get(r).unwrap(), filters.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:272:23 [INFO] [stdout] | [INFO] [stdout] 259 | .map(|(relay, filters)| async { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 260 | let pb = if std::env::var("NGITTEST").is_err() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | let pb = progress_reporter.add( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | match get_events_of(relay, filters, &pb).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:420:27 [INFO] [stdout] | [INFO] [stdout] 393 | .map(|request| async { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 401 | let pb = if std::env::var("NGITTEST").is_err() { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 402 | let pb = progress_reporter.add( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 420 | match self.fetch_all_from_relay(git_repo_path, request, &pb).await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:488:30 [INFO] [stdout] | [INFO] [stdout] 486 | request: FetchRequest, [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 487 | pb: &Option, [INFO] [stdout] 488 | ) -> Result { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 489 | | let mut fresh_coordinates: HashSet = HashSet::new(); [INFO] [stdout] 490 | | for (c, _) in request.repo_coordinates_without_relays.clone() { [INFO] [stdout] 491 | | fresh_coordinates.insert(c); [INFO] [stdout] ... | [INFO] [stdout] 586 | | Ok(report) [INFO] [stdout] 587 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:1350:5 [INFO] [stdout] | [INFO] [stdout] 1349 | pub fn get_filter_contributor_profiles(contributors: HashSet) -> nostr::Filter { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1350 | / nostr::Filter::default() [INFO] [stdout] 1351 | | .kinds(vec![Kind::Metadata, Kind::RelayList]) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:222:25 [INFO] [stdout] | [INFO] [stdout] 211 | let branch = if let Ok(branch) = self [INFO] [stdout] | ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | Ok(oid_to_sha1(&branch.into_reference().peel_to_commit()?.id())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:342:22 [INFO] [stdout] | [INFO] [stdout] 342 | .map(|r| r.unwrap().shorthand().unwrap().to_string()) [INFO] [stdout] | - ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:826:5 [INFO] [stdout] | [INFO] [stdout] 826 | / git2::Signature::new( [INFO] [stdout] 827 | | v[1].as_str(), [INFO] [stdout] 828 | | v[2].as_str(), [INFO] [stdout] 829 | | &git2::Time::new( [INFO] [stdout] ... | [INFO] [stdout] 833 | | ), [INFO] [stdout] 834 | | ) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/repo_ref.rs:445:5 [INFO] [stdout] | [INFO] [stdout] 428 | let file = if path.exists() { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 445 | / serde_yaml::to_writer( [INFO] [stdout] 446 | | file, [INFO] [stdout] 447 | | &RepoConfigYaml { [INFO] [stdout] 448 | | identifier: Some(identifier), [INFO] [stdout] ... | [INFO] [stdout] 451 | | }, [INFO] [stdout] 452 | | ) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/list.rs:267:28 [INFO] [stdout] | [INFO] [stdout] 267 | .any(|n| n.eq(&cover_letter.get_branch_name().unwrap())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/pull.rs:54:37 [INFO] [stdout] | [INFO] [stdout] 54 | .is_ok_and(|cl| cl.get_branch_name().is_ok_and(|s| s.eq(&branch_name))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/push.rs:71:37 [INFO] [stdout] | [INFO] [stdout] 71 | .is_ok_and(|cl| cl.get_branch_name().is_ok_and(|s| s.eq(&branch_name))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/send.rs:477:34 [INFO] [stdout] | [INFO] [stdout] 477 | .map(|h| summarise_commit_for_selection(git_repo, h).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sub_commands/send.rs:1110:11 [INFO] [stdout] | [INFO] [stdout] 1110 | match git_repo.get_commits_ahead_behind(&to_tip, &from_tip) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 19 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ngit` (bin "git-remote-nostr") due to 20 previous errors [INFO] running `Command { std: "docker" "inspect" "8a1cb201fef8aed395c5024368ca7fc7863c0d7c53ce6102b5e483795ca4b623", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a1cb201fef8aed395c5024368ca7fc7863c0d7c53ce6102b5e483795ca4b623", kill_on_drop: false }` [INFO] [stdout] 8a1cb201fef8aed395c5024368ca7fc7863c0d7c53ce6102b5e483795ca4b623