[INFO] cloning repository https://github.com/DR-BoneZ/borker-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DR-BoneZ/borker-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDR-BoneZ%2Fborker-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDR-BoneZ%2Fborker-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6adb0c7bad01cda7583f638000da90835f9ffc72 [INFO] checking DR-BoneZ/borker-rs/6adb0c7bad01cda7583f638000da90835f9ffc72 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDR-BoneZ%2Fborker-rs" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DR-BoneZ/borker-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DR-BoneZ/borker-rs [INFO] finished tweaking git repo https://github.com/DR-BoneZ/borker-rs [INFO] tweaked toml for git repo https://github.com/DR-BoneZ/borker-rs written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DR-BoneZ/borker-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c331fb0fbdd9cc3e258b6b8c5afc719ba5ca31b6e5b63572b266ed70c4909c16 [INFO] running `Command { std: "docker" "start" "-a" "c331fb0fbdd9cc3e258b6b8c5afc719ba5ca31b6e5b63572b266ed70c4909c16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c331fb0fbdd9cc3e258b6b8c5afc719ba5ca31b6e5b63572b266ed70c4909c16", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c331fb0fbdd9cc3e258b6b8c5afc719ba5ca31b6e5b63572b266ed70c4909c16", kill_on_drop: false }` [INFO] [stdout] c331fb0fbdd9cc3e258b6b8c5afc719ba5ca31b6e5b63572b266ed70c4909c16 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5a7012993e443dda238caa1b66985db430e01672a92f512b523a4de2066f12d3 [INFO] running `Command { std: "docker" "start" "-a" "5a7012993e443dda238caa1b66985db430e01672a92f512b523a4de2066f12d3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.60 [INFO] [stderr] Compiling proc-macro2 v1.0.17 [INFO] [stderr] Compiling syn v1.0.29 [INFO] [stderr] Compiling serde v1.0.111 [INFO] [stderr] Compiling cc v1.0.26 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.63 [INFO] [stderr] Compiling bumpalo v3.3.0 [INFO] [stderr] Compiling lazy_static v1.3.0 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Compiling log v0.4.6 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Checking generic-array v0.12.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.63 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking block-padding v0.1.3 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Checking opaque-debug v0.2.2 [INFO] [stderr] Compiling num-bigint v0.2.2 [INFO] [stderr] Compiling crunchy v0.2.2 [INFO] [stderr] Compiling wee_alloc v0.4.5 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking bech32 v0.5.0 [INFO] [stderr] Checking memory_units v0.4.0 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking arrayref v0.3.5 [INFO] [stderr] Checking subtle v2.2.3 [INFO] [stderr] Checking half v1.3.0 [INFO] [stderr] Checking digest v0.8.0 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking base58 v0.1.0 [INFO] [stderr] Checking bitcoin-bech32 v0.8.1 [INFO] [stderr] Checking hex v0.4.2 [INFO] [stderr] Checking hmac v0.7.1 [INFO] [stderr] Checking hmac-drbg v0.2.0 [INFO] [stderr] Compiling backtrace-sys v0.1.30 [INFO] [stderr] Compiling secp256k1 v0.12.2 [INFO] [stderr] Checking block-buffer v0.7.0 [INFO] [stderr] Checking bitcoin_hashes v0.3.2 [INFO] [stderr] Checking pbkdf2 v0.3.0 [INFO] [stderr] Checking getrandom v0.1.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking sha2 v0.8.2 [INFO] [stderr] Checking ripemd160 v0.8.0 [INFO] [stderr] Compiling quote v1.0.6 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking backtrace v0.3.3 [INFO] [stderr] Checking libsecp256k1 v0.3.5 [INFO] [stderr] Checking serde_json v1.0.53 [INFO] [stderr] Checking serde_bytes v0.11.4 [INFO] [stderr] Checking bigdecimal v0.1.2 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking chrono v0.4.11 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.63 [INFO] [stderr] Compiling synstructure v0.12.3 [INFO] [stderr] Checking bitcoin v0.17.1 [INFO] [stderr] Compiling serde_derive v1.0.111 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.63 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.63 [INFO] [stderr] Checking console_error_panic_hook v0.1.6 [INFO] [stderr] Checking js-sys v0.3.40 [INFO] [stderr] Checking borker-rs v0.1.30 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / ($x).map_err(|e| { [INFO] [stdout] 19 | | let e = failure::Error::from(e); [INFO] [stdout] 20 | | format_js_err!("{}: {}\n{}", line!(), e, e.backtrace()) [INFO] [stdout] 21 | | })? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | Ok(js_try!(JsValue::from_serde(&borker_txs))) [INFO] [stdout] | ----------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `js_try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn new(words: Option>) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | console_error_panic_hook::set_once(); [INFO] [stdout] 95 | Ok(match words { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | Some(w) => JsWallet { [INFO] [stdout] 97 | | inner: js_try!(Wallet::from_words(&js_try!(w [INFO] [stdout] 98 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 104 | | }, [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:30 [INFO] [stdout] | [INFO] [stdout] 99 | .map(|a| a.into_serde::().map_err(Error::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 112 | .map(|a| JsValue::from_serde(a).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / ($x).map_err(|e| { [INFO] [stdout] 19 | | let e = failure::Error::from(e); [INFO] [stdout] 20 | | format_js_err!("{}: {}\n{}", line!(), e, e.backtrace()) [INFO] [stdout] 21 | | })? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | data: JsValue, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | inputs: JsValue, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | recipient: JsValue, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | mentions: JsValue, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | Ok(js_try!(JsValue::from_serde(&txs))) [INFO] [stdout] | ---------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `js_try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 361 | let mut res = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | res.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/protocol.rs:453:27 [INFO] [stdout] | [INFO] [stdout] 453 | .map(|a| a.clone().to_owned()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/protocol.rs:471:27 [INFO] [stdout] | [INFO] [stdout] 471 | .map(|a| a.clone().to_owned()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/protocol.rs:488:27 [INFO] [stdout] | [INFO] [stdout] 488 | .map(|a| a.clone().to_owned()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/protocol.rs:504:27 [INFO] [stdout] | [INFO] [stdout] 504 | .map(|a| a.clone().to_owned()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/mod.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 133 | Ok(Self::from_idxs(idxs)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/mod.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 181 | let parent = match w.parent { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(Wallet { entropy, parent }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/child.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 200 | let mpriv = match w.mpriv { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let children: Vec> = w [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let hardened_children: Vec> = w [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(ChildWallet { [INFO] [stdout] | ____________^ [INFO] [stdout] 229 | | seed, [INFO] [stdout] 230 | | mpriv, [INFO] [stdout] 231 | | mpub, [INFO] [stdout] ... | [INFO] [stdout] 234 | | nonce: w.nonce, [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/child.rs:273:17 [INFO] [stdout] | [INFO] [stdout] 272 | .flat_map(|tx| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | / tx.output [INFO] [stdout] 274 | | .clone() [INFO] [stdout] 275 | | .into_iter() [INFO] [stdout] 276 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 285 | | ) [INFO] [stdout] 286 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/child.rs:322:29 [INFO] [stdout] | [INFO] [stdout] 320 | .map(|a| TxIn { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | previous_output: a.0, [INFO] [stdout] 322 | script_sig: bitcoin::Script::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/child.rs:350:20 [INFO] [stdout] | [INFO] [stdout] 336 | .map(|(i, vin)| -> Result<_, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let sighash = tx.signature_hash(i, &script, 0x01).into_inner(); [INFO] [stdout] 338 | let (sig, _) = secp256k1::sign(&secp256k1::Message::parse(&sighash), self.mpriv()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let script_sig = bitcoin::Script::from( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | Ok(TxIn { [INFO] [stdout] | ____________________^ [INFO] [stdout] 351 | | previous_output: vin.previous_output, [INFO] [stdout] 352 | | script_sig, [INFO] [stdout] 353 | | sequence: vin.sequence, [INFO] [stdout] 354 | | witness: vin.witness, [INFO] [stdout] 355 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `borker-rs` (lib test) due to 14 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / ($x).map_err(|e| { [INFO] [stdout] 19 | | let e = failure::Error::from(e); [INFO] [stdout] 20 | | format_js_err!("{}: {}\n{}", line!(), e, e.backtrace()) [INFO] [stdout] 21 | | })? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 80 | Ok(js_try!(JsValue::from_serde(&borker_txs))) [INFO] [stdout] | ----------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `js_try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 93 | pub fn new(words: Option>) -> Result { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | console_error_panic_hook::set_once(); [INFO] [stdout] 95 | Ok(match words { [INFO] [stdout] | ____________^ [INFO] [stdout] 96 | | Some(w) => JsWallet { [INFO] [stdout] 97 | | inner: js_try!(Wallet::from_words(&js_try!(w [INFO] [stdout] 98 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 104 | | }, [INFO] [stdout] 105 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:99:30 [INFO] [stdout] | [INFO] [stdout] 99 | .map(|a| a.into_serde::().map_err(Error::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:112:22 [INFO] [stdout] | [INFO] [stdout] 112 | .map(|a| JsValue::from_serde(a).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:18:9 [INFO] [stdout] | [INFO] [stdout] 18 | / ($x).map_err(|e| { [INFO] [stdout] 19 | | let e = failure::Error::from(e); [INFO] [stdout] 20 | | format_js_err!("{}: {}\n{}", line!(), e, e.backtrace()) [INFO] [stdout] 21 | | })? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] ::: src/lib.rs:161:9 [INFO] [stdout] | [INFO] [stdout] 161 | data: JsValue, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 162 | inputs: JsValue, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 163 | recipient: JsValue, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 164 | mentions: JsValue, [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | Ok(js_try!(JsValue::from_serde(&txs))) [INFO] [stdout] | ---------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `js_try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:24:28 [INFO] [stdout] | [INFO] [stdout] 24 | #[derive(Debug, Serialize, Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/protocol.rs:391:5 [INFO] [stdout] | [INFO] [stdout] 361 | let mut res = HashSet::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 391 | res.into_iter().collect() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/protocol.rs:453:27 [INFO] [stdout] | [INFO] [stdout] 453 | .map(|a| a.clone().to_owned()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/protocol.rs:471:27 [INFO] [stdout] | [INFO] [stdout] 471 | .map(|a| a.clone().to_owned()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/protocol.rs:488:27 [INFO] [stdout] | [INFO] [stdout] 488 | .map(|a| a.clone().to_owned()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/protocol.rs:504:27 [INFO] [stdout] | [INFO] [stdout] 504 | .map(|a| a.clone().to_owned()) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/mod.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 133 | Ok(Self::from_idxs(idxs)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/mod.rs:186:12 [INFO] [stdout] | [INFO] [stdout] 181 | let parent = match w.parent { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | Ok(Wallet { entropy, parent }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/child.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 200 | let mpriv = match w.mpriv { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let children: Vec> = w [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 219 | let hardened_children: Vec> = w [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(ChildWallet { [INFO] [stdout] | ____________^ [INFO] [stdout] 229 | | seed, [INFO] [stdout] 230 | | mpriv, [INFO] [stdout] 231 | | mpub, [INFO] [stdout] ... | [INFO] [stdout] 234 | | nonce: w.nonce, [INFO] [stdout] 235 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/child.rs:273:17 [INFO] [stdout] | [INFO] [stdout] 272 | .flat_map(|tx| { [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 273 | / tx.output [INFO] [stdout] 274 | | .clone() [INFO] [stdout] 275 | | .into_iter() [INFO] [stdout] 276 | | .enumerate() [INFO] [stdout] ... | [INFO] [stdout] 285 | | ) [INFO] [stdout] 286 | | }) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/child.rs:322:29 [INFO] [stdout] | [INFO] [stdout] 320 | .map(|a| TxIn { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 321 | previous_output: a.0, [INFO] [stdout] 322 | script_sig: bitcoin::Script::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wallet/child.rs:350:20 [INFO] [stdout] | [INFO] [stdout] 336 | .map(|(i, vin)| -> Result<_, Error> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | let sighash = tx.signature_hash(i, &script, 0x01).into_inner(); [INFO] [stdout] 338 | let (sig, _) = secp256k1::sign(&secp256k1::Message::parse(&sighash), self.mpriv()); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 341 | let script_sig = bitcoin::Script::from( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 350 | Ok(TxIn { [INFO] [stdout] | ____________________^ [INFO] [stdout] 351 | | previous_output: vin.previous_output, [INFO] [stdout] 352 | | script_sig, [INFO] [stdout] 353 | | sequence: vin.sequence, [INFO] [stdout] 354 | | witness: vin.witness, [INFO] [stdout] 355 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `borker-rs` (lib) due to 14 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5a7012993e443dda238caa1b66985db430e01672a92f512b523a4de2066f12d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5a7012993e443dda238caa1b66985db430e01672a92f512b523a4de2066f12d3", kill_on_drop: false }` [INFO] [stdout] 5a7012993e443dda238caa1b66985db430e01672a92f512b523a4de2066f12d3