[INFO] cloning repository https://github.com/DHMike57/soundsense-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DHMike57/soundsense-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDHMike57%2Fsoundsense-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDHMike57%2Fsoundsense-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7fde89bbcdafa5a413e0d70a958c0edf7ef36221 [INFO] checking DHMike57/soundsense-rs/7fde89bbcdafa5a413e0d70a958c0edf7ef36221 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDHMike57%2Fsoundsense-rs" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DHMike57/soundsense-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DHMike57/soundsense-rs [INFO] finished tweaking git repo https://github.com/DHMike57/soundsense-rs [INFO] tweaked toml for git repo https://github.com/DHMike57/soundsense-rs written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DHMike57/soundsense-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 09f0760fc9adba4c6c08cecb4fa6eb8abb0d9420b13dd64da995b8c7024af3d7 [INFO] running `Command { std: "docker" "start" "-a" "09f0760fc9adba4c6c08cecb4fa6eb8abb0d9420b13dd64da995b8c7024af3d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "09f0760fc9adba4c6c08cecb4fa6eb8abb0d9420b13dd64da995b8c7024af3d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "09f0760fc9adba4c6c08cecb4fa6eb8abb0d9420b13dd64da995b8c7024af3d7", kill_on_drop: false }` [INFO] [stdout] 09f0760fc9adba4c6c08cecb4fa6eb8abb0d9420b13dd64da995b8c7024af3d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a6965ae00475fb987025082ab95b697e92cbfe9d6ed764d1cf679109589f515c [INFO] running `Command { std: "docker" "start" "-a" "a6965ae00475fb987025082ab95b697e92cbfe9d6ed764d1cf679109589f515c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.9 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling serde v1.0.105 [INFO] [stderr] Compiling version-compare v0.0.10 [INFO] [stderr] Compiling strum v0.18.0 [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling webkit2gtk-sys v0.12.0 [INFO] [stderr] Compiling memoffset v0.5.4 [INFO] [stderr] Compiling alsa-sys v0.1.2 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling macro-utils v0.1.3 [INFO] [stderr] Compiling num-traits v0.2.11 [INFO] [stderr] Compiling cpal v0.11.0 [INFO] [stderr] Compiling minifier v0.0.36 [INFO] [stderr] Checking ogg v0.7.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking tinyvec v0.3.3 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking hound v3.4.0 [INFO] [stderr] Checking claxon v0.4.2 [INFO] [stderr] Checking humantime v1.3.0 [INFO] [stderr] Checking urlencoding v1.3.3 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking boxfnonce v0.1.1 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking quick-xml v0.17.2 [INFO] [stderr] Checking lewton v0.10.1 [INFO] [stderr] Checking webbrowser v0.5.2 [INFO] [stderr] Compiling minimp3-sys v0.3.2 [INFO] [stderr] Compiling tinyfiledialogs v3.3.9 [INFO] [stderr] Compiling webview-sys v0.6.2 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking javascriptcore-rs-sys v0.2.0 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking dirs v2.0.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking minimp3 v0.3.5 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking regex v1.3.6 [INFO] [stderr] Checking env_logger v0.7.1 [INFO] [stderr] Compiling toml v0.5.6 [INFO] [stderr] Compiling winres v0.1.11 [INFO] [stderr] Compiling thiserror-impl v1.0.13 [INFO] [stderr] Compiling strum_macros v0.18.0 [INFO] [stderr] Compiling educe v0.4.2 [INFO] [stderr] Compiling html-minifier v1.2.1 [INFO] [stderr] Compiling thiserror v1.0.13 [INFO] [stderr] Compiling soundsense-rs v1.5.2 (/opt/rustwide/workdir) [INFO] [stderr] Compiling system-deps v1.3.2 [INFO] [stderr] Checking rodio v0.11.0 [INFO] [stderr] Compiling glib-sys v0.10.1 [INFO] [stderr] Compiling gobject-sys v0.10.0 [INFO] [stderr] Compiling gio-sys v0.10.1 [INFO] [stderr] Compiling gdk-pixbuf-sys v0.10.0 [INFO] [stderr] Compiling cairo-sys-rs v0.10.0 [INFO] [stderr] Compiling pango-sys v0.10.0 [INFO] [stderr] Compiling atk-sys v0.10.0 [INFO] [stderr] Compiling gdk-sys v0.10.0 [INFO] [stderr] Compiling soup-sys v0.10.0 [INFO] [stderr] Compiling gtk-sys v0.10.0 [INFO] [stderr] Checking web-view v0.7.3 [INFO] [stdout] warning: fields `weight` and `delay` are never read [INFO] [stdout] --> src/sound.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 49 | pub struct SoundFile { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 53 | pub weight: f32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub delay: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SoundFile` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `random_balance` is never read [INFO] [stdout] --> src/sound.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 103 | pub struct SoundEntry { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 124 | pub random_balance: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | env::current_exe().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | / Regex::new("gamelog=(.+)").unwrap() [INFO] [stdout] 94 | | .captures(&config_txt) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | / Regex::new("soundpack=(.+)").unwrap() [INFO] [stdout] 120 | | .captures(&config_txt) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 145 | / Regex::new("ignore=(.+)").unwrap() [INFO] [stdout] 146 | | .captures(&config_txt) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_manager.rs:389:17 [INFO] [stdout] | [INFO] [stdout] 389 | std::env::current_exe().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(device: &Device, name: &str, total_volume: VolumeLock, total_is_paused: IsPausedLock) -> Self { [INFO] [stdout] | ------------------------ ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let local_volume = VolumeLock::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let local_is_paused = IsPausedLock::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Self { [INFO] [stdout] 29 | looping : LoopPlayer::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 30 | | device, [INFO] [stdout] 31 | | local_volume.clone(), [INFO] [stdout] 32 | | total_volume.clone(), [INFO] [stdout] 33 | | local_is_paused.clone(), [INFO] [stdout] 34 | | total_is_paused.clone(), [INFO] [stdout] 35 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(device: &Device, name: &str, total_volume: VolumeLock, total_is_paused: IsPausedLock) -> Self { [INFO] [stdout] | ------------------------ ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let local_volume = VolumeLock::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let local_is_paused = IsPausedLock::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | one_shots : OneshotPlayer::new( [INFO] [stdout] | _________________________^ [INFO] [stdout] 37 | | local_volume.clone(), [INFO] [stdout] 38 | | total_volume, [INFO] [stdout] 39 | | local_is_paused.clone(), [INFO] [stdout] 40 | | total_is_paused, [INFO] [stdout] 41 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | stopped: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | paused: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | skipped: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | volume: VolumeLock::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | sleep_until_end: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/oneshot_player.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 34 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | paused: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `weight` and `delay` are never read [INFO] [stdout] --> src/sound.rs:53:9 [INFO] [stdout] | [INFO] [stdout] 49 | pub struct SoundFile { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 53 | pub weight: f32, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 59 | pub delay: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SoundFile` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `random_balance` is never read [INFO] [stdout] --> src/sound.rs:124:9 [INFO] [stdout] | [INFO] [stdout] 103 | pub struct SoundEntry { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 124 | pub random_balance: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:68:17 [INFO] [stdout] | [INFO] [stdout] 68 | env::current_exe().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:93:25 [INFO] [stdout] | [INFO] [stdout] 93 | / Regex::new("gamelog=(.+)").unwrap() [INFO] [stdout] 94 | | .captures(&config_txt) [INFO] [stdout] | |__________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:119:21 [INFO] [stdout] | [INFO] [stdout] 119 | / Regex::new("soundpack=(.+)").unwrap() [INFO] [stdout] 120 | | .captures(&config_txt) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:145:21 [INFO] [stdout] | [INFO] [stdout] 145 | / Regex::new("ignore=(.+)").unwrap() [INFO] [stdout] 146 | | .captures(&config_txt) [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_manager.rs:389:17 [INFO] [stdout] | [INFO] [stdout] 389 | std::env::current_exe().ok() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(device: &Device, name: &str, total_volume: VolumeLock, total_is_paused: IsPausedLock) -> Self { [INFO] [stdout] | ------------------------ ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let local_volume = VolumeLock::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let local_is_paused = IsPausedLock::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | Self { [INFO] [stdout] 29 | looping : LoopPlayer::new( [INFO] [stdout] | _______________________^ [INFO] [stdout] 30 | | device, [INFO] [stdout] 31 | | local_volume.clone(), [INFO] [stdout] 32 | | total_volume.clone(), [INFO] [stdout] 33 | | local_is_paused.clone(), [INFO] [stdout] 34 | | total_is_paused.clone(), [INFO] [stdout] 35 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel.rs:36:25 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new(device: &Device, name: &str, total_volume: VolumeLock, total_is_paused: IsPausedLock) -> Self { [INFO] [stdout] | ------------------------ ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | let local_volume = VolumeLock::new(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | let local_is_paused = IsPausedLock::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | one_shots : OneshotPlayer::new( [INFO] [stdout] | _________________________^ [INFO] [stdout] 37 | | local_volume.clone(), [INFO] [stdout] 38 | | total_volume, [INFO] [stdout] 39 | | local_is_paused.clone(), [INFO] [stdout] 40 | | total_is_paused, [INFO] [stdout] 41 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | stopped: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:53:21 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | paused: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | skipped: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:55:21 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | volume: VolumeLock::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/loop_player.rs:56:30 [INFO] [stdout] | [INFO] [stdout] 39 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | ) -> Self { [INFO] [stdout] 44 | let (queue_tx, queue_rx) = queue::queue(true); [INFO] [stdout] | -------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | sleep_until_end: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sound/sound_channel/oneshot_player.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 34 | local_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | total_volume: VolumeLock, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | local_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | total_is_paused: IsPausedLock, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | paused: Arc::new(AtomicBool::new(false)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `soundsense-rs` (bin "soundsense-rs") due to 14 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `soundsense-rs` (bin "soundsense-rs" test) due to 14 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a6965ae00475fb987025082ab95b697e92cbfe9d6ed764d1cf679109589f515c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a6965ae00475fb987025082ab95b697e92cbfe9d6ed764d1cf679109589f515c", kill_on_drop: false }` [INFO] [stdout] a6965ae00475fb987025082ab95b697e92cbfe9d6ed764d1cf679109589f515c