[INFO] cloning repository https://github.com/DCNick3/hac-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DCNick3/hac-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDCNick3%2Fhac-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDCNick3%2Fhac-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] acdb809b2c1868c12d3cc4fe6689dc52607aeb79 [INFO] checking DCNick3/hac-rs/acdb809b2c1868c12d3cc4fe6689dc52607aeb79 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDCNick3%2Fhac-rs" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DCNick3/hac-rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DCNick3/hac-rs [INFO] finished tweaking git repo https://github.com/DCNick3/hac-rs [INFO] tweaked toml for git repo https://github.com/DCNick3/hac-rs written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DCNick3/hac-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f7516e3ce56597561a1fd792f88c584e9b26b484158b3a6570b42156b5eb88c1 [INFO] running `Command { std: "docker" "start" "-a" "f7516e3ce56597561a1fd792f88c584e9b26b484158b3a6570b42156b5eb88c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f7516e3ce56597561a1fd792f88c584e9b26b484158b3a6570b42156b5eb88c1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7516e3ce56597561a1fd792f88c584e9b26b484158b3a6570b42156b5eb88c1", kill_on_drop: false }` [INFO] [stdout] f7516e3ce56597561a1fd792f88c584e9b26b484158b3a6570b42156b5eb88c1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6190764ad45e3d89fc5dffa3b407e0a44fcddb60dd0a99e253154c8f2c9c6a47 [INFO] running `Command { std: "docker" "start" "-a" "6190764ad45e3d89fc5dffa3b407e0a44fcddb60dd0a99e253154c8f2c9c6a47", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling unicode-ident v1.0.6 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling typenum v1.16.0 [INFO] [stderr] Compiling syn v1.0.107 [INFO] [stderr] Checking once_cell v1.17.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.20+deprecated [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling serde_derive v1.0.152 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling zstd-safe v6.0.5+zstd.1.5.4 [INFO] [stderr] Checking tracing-core v0.1.30 [INFO] [stderr] Compiling binrw_derive v0.11.2 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Compiling serde v1.0.152 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling either v1.8.0 [INFO] [stderr] Compiling mini-moka v0.10.1 [INFO] [stderr] Checking hashbrown v0.13.2 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Compiling binrw v0.11.2 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking triomphe v0.1.9 [INFO] [stderr] Checking bytemuck v1.12.3 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking tagptr v0.2.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking replace_with v0.1.7 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling camino v1.1.2 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking tracing-log v0.1.3 [INFO] [stderr] Checking sharded-slab v0.1.4 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Compiling jobserver v0.1.26 [INFO] [stderr] Compiling getrandom v0.2.8 [INFO] [stderr] Checking cipher v0.4.3 [INFO] [stderr] Checking digest v0.10.6 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Compiling cc v1.0.78 [INFO] [stderr] Checking clap_builder v4.3.11 [INFO] [stderr] Checking sha2 v0.10.6 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Compiling const-random-macro v0.1.15 [INFO] [stderr] Checking aes v0.8.2 [INFO] [stderr] Checking xts-mode v0.5.1 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking dashmap v5.4.0 [INFO] [stderr] Checking const-random v0.1.15 [INFO] [stderr] Checking dlv-list v0.5.0 [INFO] [stderr] Checking ordered-multimap v0.6.0 [INFO] [stderr] Checking rust-ini v0.19.0 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking tracing-subscriber v0.3.16 [INFO] [stderr] Compiling zstd-sys v2.0.8+zstd.1.5.5 [INFO] [stderr] Compiling clap_derive v4.3.2 [INFO] [stderr] Compiling snafu-derive v0.7.4 [INFO] [stderr] Compiling enum-map-derive v0.11.0 [INFO] [stderr] Checking enum-map v2.4.2 [INFO] [stderr] Checking clap v4.3.11 [INFO] [stderr] Checking snafu v0.7.4 [INFO] [stderr] Checking zstd v0.12.3+zstd.1.5.2 [INFO] [stderr] Checking hac v0.1.0 (/opt/rustwide/workdir/crates/hac) [INFO] [stdout] warning: method `is_patch_section` is never used [INFO] [stdout] --> crates/hac/src/formats/nca/structs.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 254 | impl NcaFsHeader { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] 255 | pub fn is_patch_section(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DenyStorage` is never constructed [INFO] [stdout] --> crates/hac/src/storage/deny_storage.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct DenyStorage { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/crypto/keyset.rs:144:22 [INFO] [stdout] | [INFO] [stdout] 144 | .map(|p| std::fs::read_to_string(p).context(IoSnafu)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused implementer of `Iterator` that must be used [INFO] [stdout] --> crates/hac/src/filesystem/mod.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 76 | self.inner.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/mod.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(key_set: &KeySet, storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let body = match NczBodyStorage::try_new(storage).context(NczSnafu)? { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Either::Left(ncz_storage) => Body::Ncz(ncz_storage.shared()), [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Either::Right(storage) => Body::Nca(storage.shared()), [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | body, [INFO] [stdout] 147 | | headers, [INFO] [stdout] 148 | | content_key, [INFO] [stdout] 149 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/filesystem.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new_romfs(storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(Self::Romfs(RomFileSystem::new(storage)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/filesystem.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new_pfs(storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(Self::Pfs(PartitionFileSystem::new(storage)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/mod.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 125 | mut reader: BufReader>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let storage = reader.into_inner().into_inner().shared(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let mut block_storages = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let uncompressed_storage = ConcatStorageN::new(block_storages); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | [INFO] [stdout] 188 | Ok(NczBodyStorage::Block(make_cache( [INFO] [stdout] | ____________^ [INFO] [stdout] 189 | | uncompressed_storage, [INFO] [stdout] 190 | | 1024 * 1024, [INFO] [stdout] 191 | | 64, [INFO] [stdout] 192 | | Duration::from_secs(2), [INFO] [stdout] 193 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/mod.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 197 | mut reader: BufReader>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let storage = reader.into_inner().into_inner(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let compressed_storage = storage [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let uncompressed_storage = StreamingZstdStorage::new(compressed_storage, uncompressed_size) [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Ok(NczBodyStorage::Streaming(make_cache( [INFO] [stdout] | ____________^ [INFO] [stdout] 219 | | uncompressed_storage, [INFO] [stdout] 220 | | 512 * 1024, [INFO] [stdout] 221 | | 128, [INFO] [stdout] 222 | | Duration::from_secs(2), [INFO] [stdout] 223 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/mod.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 229 | pub fn try_new(storage: S) -> Result, S>, NczError> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let mut reader = storage.buf_read(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | / if &block_magic == NCZ_BLOCK_MAGIC { [INFO] [stdout] 262 | | Self::make_block(reader, header, total_size) [INFO] [stdout] 263 | | } else { [INFO] [stdout] 264 | | Self::make_stream(reader, header, total_size) [INFO] [stdout] 265 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/streaming_zstd_storage.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 88 | fn reset_zstd_io(io: RawZstdIo) -> RawZstdIo { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let mut io = io.finish(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | zstd::Decoder::with_buffer(io).expect("Failed to create a new Zstd stream") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/streaming_zstd_storage.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new(storage: S, uncompressed_size: u64) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let io = zstd::Decoder::with_buffer(BufReader::new(StorageIo::new(storage))) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | .expect("Failed to create a new Zstd stream"); [INFO] [stdout] 114 | let io = FakeSeek::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let storage = RoIoStorage::new_with_size(io, uncompressed_size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | Ok(Self { storage }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/verification_storage/mod.rs:83:8 [INFO] [stdout] | [INFO] [stdout] 73 | base_storage: SharedStorage, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | hash_storage: B, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let data_storage = BlockAdapterStorage::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Ok(LinearAdapterStorage::new( [INFO] [stdout] | ________^ [INFO] [stdout] 84 | | IntegrityVerificationLevelStorage::new( [INFO] [stdout] 85 | | data_storage, [INFO] [stdout] 86 | | hash_storage, [INFO] [stdout] ... | [INFO] [stdout] 89 | | ), [INFO] [stdout] 90 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/verification_storage/mod.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 152 | storage: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(Self::Level2(make_level2_storage( [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | storage.shared(), [INFO] [stdout] 165 | | master_hash, [INFO] [stdout] 166 | | [ [INFO] [stdout] ... | [INFO] [stdout] 178 | | params, [INFO] [stdout] 179 | | )?)) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/verification_storage/mod.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 183 | storage: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(match level_count { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | 1 => Self::Level1(make_level1_storage( [INFO] [stdout] 203 | | storage.shared(), [INFO] [stdout] 204 | | master_hash, [INFO] [stdout] ... | [INFO] [stdout] 240 | | l => panic!("Invalid level count {}", l), [INFO] [stdout] 241 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/pfs/mod.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let mut io = storage.buf_read(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let files = file_entries [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let storage = io.into_inner().into_inner().shared(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | storage, [INFO] [stdout] 123 | | files, [INFO] [stdout] 124 | | header_size, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_patch_section` is never used [INFO] [stdout] --> crates/hac/src/formats/nca/structs.rs:255:12 [INFO] [stdout] | [INFO] [stdout] 254 | impl NcaFsHeader { [INFO] [stdout] | ---------------- method in this implementation [INFO] [stdout] 255 | pub fn is_patch_section(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/pfs/mod.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 189 | let storage = self.fs.storage.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | storage.slice(offset, size).context(PfsOpenSnafu) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DenyStorage` is never constructed [INFO] [stdout] --> crates/hac/src/storage/deny_storage.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct DenyStorage { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/pfs/open_file.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn from_path(path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let storage = crate::storage::FileRoStorage::open(path).context(StorageSnafu)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Self::new(storage).context(PfsParseSnafu) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/romfs/mod.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new(storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let storage = storage.shared(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let mut io = storage.clone().buf_read(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let dir_hash_table = storage [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let dir_meta_table = storage [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let file_hash_table = storage [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let file_meta_table = storage [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 138 | | storage, [INFO] [stdout] 139 | | table, [INFO] [stdout] 140 | | data_offset: header.data_offset, [INFO] [stdout] 141 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/romfs/mod.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 211 | let storage = self.fs.storage.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | SliceStorage::new(storage, offset, size).context(RomfsOpenSnafu) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/crypto/keyset.rs:144:22 [INFO] [stdout] | [INFO] [stdout] 144 | .map(|p| std::fs::read_to_string(p).context(IoSnafu)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/mod.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 108 | fn buf_read(self) -> BufReader> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | BufReader::new(self.io()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/mod.rs:135:23 [INFO] [stdout] | [INFO] [stdout] 134 | fn save_to_file(&self, path: impl AsRef) -> Result<(), StorageError> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | self.copy_to(&FileRwStorage::create(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/block_slice_storage.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(storage: S, block_offset: u64, size: u64) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | storage, [INFO] [stdout] 36 | | block_offset, [INFO] [stdout] 37 | | size, [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused implementer of `Iterator` that must be used [INFO] [stdout] --> crates/hac/src/filesystem/mod.rs:76:25 [INFO] [stdout] | [INFO] [stdout] 76 | self.inner.pop().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: iterators are lazy and do nothing unless consumed [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/io_storage.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(mut io: Io) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Self::new_with_size(io, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/io_storage.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new_with_size(io: Io, size: u64) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | io: Mutex::new(io), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/io_storage.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(mut io: Io) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Ok(Self(Mutex::new(RwIoStorageInner { io, size }))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/shared_storage.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(storage: S) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Self { [INFO] [stdout] 13 | storage: Arc::new(storage), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/slice_storage.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(storage: S, offset: u64, size: u64) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | storage, [INFO] [stdout] 33 | | offset, [INFO] [stdout] 34 | | size, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/switch_fs/mod.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 43 | let nca_set = nca_set_from_fs(&key_set, fs).context(NcaSetParseSnafu)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | nca_set, [INFO] [stdout] 49 | | title_set, [INFO] [stdout] 50 | | application_set, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/switch_fs/content_set/program.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 39 | let fs = nca [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | ApplicationControlProperty::read(&mut std::io::Cursor::new(control)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/switch_fs/tickets.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 23 | .try_for_each(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | // it's hard to report this error, as it depends on the FS implementation [INFO] [stdout] 25 | / file.storage() [INFO] [stdout] 26 | | .expect("Malformed FS") [INFO] [stdout] 27 | | .read_all() [INFO] [stdout] 28 | | .context(ReadTicketFileSnafu) [INFO] [stdout] 29 | | .and_then(|data| { [INFO] [stdout] 30 | | Ticket::read(&mut std::io::Cursor::new(data)).context(ParseTicketFileSnafu) [INFO] [stdout] 31 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/mod.rs:145:12 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(key_set: &KeySet, storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let body = match NczBodyStorage::try_new(storage).context(NczSnafu)? { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Either::Left(ncz_storage) => Body::Ncz(ncz_storage.shared()), [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Either::Right(storage) => Body::Nca(storage.shared()), [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 145 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 146 | | body, [INFO] [stdout] 147 | | headers, [INFO] [stdout] 148 | | content_key, [INFO] [stdout] 149 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/filesystem.rs:60:12 [INFO] [stdout] | [INFO] [stdout] 59 | pub fn new_romfs(storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | Ok(Self::Romfs(RomFileSystem::new(storage)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/filesystem.rs:64:12 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new_pfs(storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Ok(Self::Pfs(PartitionFileSystem::new(storage)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/mod.rs:188:12 [INFO] [stdout] | [INFO] [stdout] 125 | mut reader: BufReader>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let storage = reader.into_inner().into_inner().shared(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let mut block_storages = Vec::new(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let uncompressed_storage = ConcatStorageN::new(block_storages); [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | [INFO] [stdout] 188 | Ok(NczBodyStorage::Block(make_cache( [INFO] [stdout] | ____________^ [INFO] [stdout] 189 | | uncompressed_storage, [INFO] [stdout] 190 | | 1024 * 1024, [INFO] [stdout] 191 | | 64, [INFO] [stdout] 192 | | Duration::from_secs(2), [INFO] [stdout] 193 | | ))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/mod.rs:218:12 [INFO] [stdout] | [INFO] [stdout] 197 | mut reader: BufReader>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | let storage = reader.into_inner().into_inner(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 212 | let compressed_storage = storage [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 215 | let uncompressed_storage = StreamingZstdStorage::new(compressed_storage, uncompressed_size) [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | Ok(NczBodyStorage::Streaming(make_cache( [INFO] [stdout] | ____________^ [INFO] [stdout] 219 | | uncompressed_storage, [INFO] [stdout] 220 | | 512 * 1024, [INFO] [stdout] 221 | | 128, [INFO] [stdout] 222 | | Duration::from_secs(2), [INFO] [stdout] 223 | | ))) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/mod.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 229 | pub fn try_new(storage: S) -> Result, S>, NczError> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | let mut reader = storage.buf_read(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | / if &block_magic == NCZ_BLOCK_MAGIC { [INFO] [stdout] 262 | | Self::make_block(reader, header, total_size) [INFO] [stdout] 263 | | } else { [INFO] [stdout] 264 | | Self::make_stream(reader, header, total_size) [INFO] [stdout] 265 | | } [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/streaming_zstd_storage.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 88 | fn reset_zstd_io(io: RawZstdIo) -> RawZstdIo { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let mut io = io.finish(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | zstd::Decoder::with_buffer(io).expect("Failed to create a new Zstd stream") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/ncz/streaming_zstd_storage.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 111 | pub fn new(storage: S, uncompressed_size: u64) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let io = zstd::Decoder::with_buffer(BufReader::new(StorageIo::new(storage))) [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | .expect("Failed to create a new Zstd stream"); [INFO] [stdout] 114 | let io = FakeSeek::new( [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | let storage = RoIoStorage::new_with_size(io, uncompressed_size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | [INFO] [stdout] 121 | Ok(Self { storage }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/verification_storage/mod.rs:83:8 [INFO] [stdout] | [INFO] [stdout] 73 | base_storage: SharedStorage, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 74 | hash_storage: B, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let data_storage = BlockAdapterStorage::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Ok(LinearAdapterStorage::new( [INFO] [stdout] | ________^ [INFO] [stdout] 84 | | IntegrityVerificationLevelStorage::new( [INFO] [stdout] 85 | | data_storage, [INFO] [stdout] 86 | | hash_storage, [INFO] [stdout] ... | [INFO] [stdout] 89 | | ), [INFO] [stdout] 90 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/verification_storage/mod.rs:163:12 [INFO] [stdout] | [INFO] [stdout] 152 | storage: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | Ok(Self::Level2(make_level2_storage( [INFO] [stdout] | ____________^ [INFO] [stdout] 164 | | storage.shared(), [INFO] [stdout] 165 | | master_hash, [INFO] [stdout] 166 | | [ [INFO] [stdout] ... | [INFO] [stdout] 178 | | params, [INFO] [stdout] 179 | | )?)) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/nca/verification_storage/mod.rs:201:12 [INFO] [stdout] | [INFO] [stdout] 183 | storage: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | Ok(match level_count { [INFO] [stdout] | ____________^ [INFO] [stdout] 202 | | 1 => Self::Level1(make_level1_storage( [INFO] [stdout] 203 | | storage.shared(), [INFO] [stdout] 204 | | master_hash, [INFO] [stdout] ... | [INFO] [stdout] 240 | | l => panic!("Invalid level count {}", l), [INFO] [stdout] 241 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/pfs/mod.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 97 | pub fn new(storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | let mut io = storage.buf_read(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | let files = file_entries [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let storage = io.into_inner().into_inner().shared(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | storage, [INFO] [stdout] 123 | | files, [INFO] [stdout] 124 | | header_size, [INFO] [stdout] 125 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/pfs/mod.rs:192:9 [INFO] [stdout] | [INFO] [stdout] 189 | let storage = self.fs.storage.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | storage.slice(offset, size).context(PfsOpenSnafu) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/pfs/open_file.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn from_path(path: impl AsRef) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | let storage = crate::storage::FileRoStorage::open(path).context(StorageSnafu)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | Self::new(storage).context(PfsParseSnafu) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/romfs/mod.rs:137:12 [INFO] [stdout] | [INFO] [stdout] 106 | pub fn new(storage: S) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 107 | let storage = storage.shared(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 108 | let mut io = storage.clone().buf_read(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let dir_hash_table = storage [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | let dir_meta_table = storage [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | let file_hash_table = storage [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 124 | let file_meta_table = storage [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 138 | | storage, [INFO] [stdout] 139 | | table, [INFO] [stdout] 140 | | data_offset: header.data_offset, [INFO] [stdout] 141 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/formats/romfs/mod.rs:214:9 [INFO] [stdout] | [INFO] [stdout] 211 | let storage = self.fs.storage.clone(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 214 | SliceStorage::new(storage, offset, size).context(RomfsOpenSnafu) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/mod.rs:112:24 [INFO] [stdout] | [INFO] [stdout] 108 | fn buf_read(self) -> BufReader> [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | BufReader::new(self.io()) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/mod.rs:135:23 [INFO] [stdout] | [INFO] [stdout] 134 | fn save_to_file(&self, path: impl AsRef) -> Result<(), StorageError> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | self.copy_to(&FileRwStorage::create(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/block_slice_storage.rs:34:12 [INFO] [stdout] | [INFO] [stdout] 17 | pub fn new(storage: S, block_offset: u64, size: u64) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 35 | | storage, [INFO] [stdout] 36 | | block_offset, [INFO] [stdout] 37 | | size, [INFO] [stdout] 38 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/io_storage.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(mut io: Io) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Self::new_with_size(io, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/io_storage.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 25 | pub fn new_with_size(io: Io, size: u64) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | Self { [INFO] [stdout] 27 | io: Mutex::new(io), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/io_storage.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn new(mut io: Io) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | Ok(Self(Mutex::new(RwIoStorageInner { io, size }))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/shared_storage.rs:13:22 [INFO] [stdout] | [INFO] [stdout] 11 | pub fn new(storage: S) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Self { [INFO] [stdout] 13 | storage: Arc::new(storage), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/storage/slice_storage.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn new(storage: S, offset: u64, size: u64) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | storage, [INFO] [stdout] 33 | | offset, [INFO] [stdout] 34 | | size, [INFO] [stdout] 35 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/switch_fs/mod.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 43 | let nca_set = nca_set_from_fs(&key_set, fs).context(NcaSetParseSnafu)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 48 | | nca_set, [INFO] [stdout] 49 | | title_set, [INFO] [stdout] 50 | | application_set, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/switch_fs/content_set/program.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 39 | let fs = nca [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | ApplicationControlProperty::read(&mut std::io::Cursor::new(control)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/hac/src/switch_fs/tickets.rs:25:13 [INFO] [stdout] | [INFO] [stdout] 23 | .try_for_each(|file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | // it's hard to report this error, as it depends on the FS implementation [INFO] [stdout] 25 | / file.storage() [INFO] [stdout] 26 | | .expect("Malformed FS") [INFO] [stdout] 27 | | .read_all() [INFO] [stdout] 28 | | .context(ReadTicketFileSnafu) [INFO] [stdout] 29 | | .and_then(|data| { [INFO] [stdout] 30 | | Ticket::read(&mut std::io::Cursor::new(data)).context(ParseTicketFileSnafu) [INFO] [stdout] 31 | | }) [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hac` (lib) due to 29 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 28 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `hac` (lib test) due to 29 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "6190764ad45e3d89fc5dffa3b407e0a44fcddb60dd0a99e253154c8f2c9c6a47", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6190764ad45e3d89fc5dffa3b407e0a44fcddb60dd0a99e253154c8f2c9c6a47", kill_on_drop: false }` [INFO] [stdout] 6190764ad45e3d89fc5dffa3b407e0a44fcddb60dd0a99e253154c8f2c9c6a47