[INFO] cloning repository https://github.com/DARKSTUFF-LAB/DataSurgeon [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/DARKSTUFF-LAB/DataSurgeon" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDARKSTUFF-LAB%2FDataSurgeon", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDARKSTUFF-LAB%2FDataSurgeon'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7d718c2a5af792061a48f56ebb83895b6d307977 [INFO] checking DARKSTUFF-LAB/DataSurgeon/7d718c2a5af792061a48f56ebb83895b6d307977 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FDARKSTUFF-LAB%2FDataSurgeon" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/DARKSTUFF-LAB/DataSurgeon on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/DARKSTUFF-LAB/DataSurgeon [INFO] finished tweaking git repo https://github.com/DARKSTUFF-LAB/DataSurgeon [INFO] tweaked toml for git repo https://github.com/DARKSTUFF-LAB/DataSurgeon written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/DARKSTUFF-LAB/DataSurgeon already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 23 packages to latest compatible versions [INFO] [stderr] Adding anstream v0.6.15 [INFO] [stderr] Adding anstyle v1.0.8 [INFO] [stderr] Adding anstyle-parse v0.2.5 [INFO] [stderr] Adding anstyle-query v1.1.1 [INFO] [stderr] Adding anstyle-wincon v3.0.4 [INFO] [stderr] Updating clap v3.2.23 -> v4.5.16 [INFO] [stderr] Adding clap_builder v4.5.15 [INFO] [stderr] Updating clap_lex v0.2.4 -> v0.7.2 [INFO] [stderr] Adding colorchoice v1.0.2 [INFO] [stderr] Updating ds v0.1.0 (/workspace/builds/worker-4-tc2/source) -> v1.0.5 [INFO] [stderr] Adding is_terminal_polyfill v1.70.1 [INFO] [stderr] Updating strsim v0.10.0 -> v0.11.1 [INFO] [stderr] Adding utf8parse v0.2.2 [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.52.6 [INFO] [stderr] Adding windows_aarch64_gnullvm v0.52.6 [INFO] [stderr] Adding windows_aarch64_msvc v0.52.6 [INFO] [stderr] Adding windows_i686_gnu v0.52.6 [INFO] [stderr] Adding windows_i686_gnullvm v0.52.6 [INFO] [stderr] Adding windows_i686_msvc v0.52.6 [INFO] [stderr] Adding windows_x86_64_gnu v0.52.6 [INFO] [stderr] Adding windows_x86_64_gnullvm v0.52.6 [INFO] [stderr] Adding windows_x86_64_msvc v0.52.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10de3b73d7536daeafb2ce0b5b506ea422912b62eca079525ea1f6642fcf3699 [INFO] running `Command { std: "docker" "start" "-a" "10de3b73d7536daeafb2ce0b5b506ea422912b62eca079525ea1f6642fcf3699", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10de3b73d7536daeafb2ce0b5b506ea422912b62eca079525ea1f6642fcf3699", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10de3b73d7536daeafb2ce0b5b506ea422912b62eca079525ea1f6642fcf3699", kill_on_drop: false }` [INFO] [stdout] 10de3b73d7536daeafb2ce0b5b506ea422912b62eca079525ea1f6642fcf3699 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 32f22f29874d6360e2787569a590fd25b25aeb60f8b1296d684abc2b8e5d5128 [INFO] running `Command { std: "docker" "start" "-a" "32f22f29874d6360e2787569a590fd25b25aeb60f8b1296d684abc2b8e5d5128", kill_on_drop: false }` [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking regex-syntax v0.6.28 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking aho-corasick v0.7.20 [INFO] [stderr] Checking regex v1.7.1 [INFO] [stderr] Checking ds v1.0.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:248:30 [INFO] [stdout] | [INFO] [stdout] 248 | .map(|key| (key, regex_map[key].clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ds` (bin "ds") due to 2 previous errors; 1 warning emitted [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:287:70 [INFO] [stdout] | [INFO] [stdout] 287 | let filtered_capture = capture_match.as_str().clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:248:30 [INFO] [stdout] | [INFO] [stdout] 248 | .map(|key| (key, regex_map[key].clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:287:70 [INFO] [stdout] | [INFO] [stdout] 287 | let filtered_capture = capture_match.as_str().clone().to_string(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ds` (bin "ds" test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "32f22f29874d6360e2787569a590fd25b25aeb60f8b1296d684abc2b8e5d5128", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32f22f29874d6360e2787569a590fd25b25aeb60f8b1296d684abc2b8e5d5128", kill_on_drop: false }` [INFO] [stdout] 32f22f29874d6360e2787569a590fd25b25aeb60f8b1296d684abc2b8e5d5128