[INFO] cloning repository https://github.com/Cypher1/steel [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Cypher1/steel" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCypher1%2Fsteel", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCypher1%2Fsteel'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 43d151bf53a6111b3d8e75a582da6208dc7b6cdd [INFO] checking Cypher1/steel/43d151bf53a6111b3d8e75a582da6208dc7b6cdd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCypher1%2Fsteel" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Cypher1/steel on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Cypher1/steel [INFO] finished tweaking git repo https://github.com/Cypher1/steel [INFO] tweaked toml for git repo https://github.com/Cypher1/steel written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Cypher1/steel already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e1720488e2191a3908bc1f503ac369b6f10eea688d680d2935adc8c252d7559 [INFO] running `Command { std: "docker" "start" "-a" "0e1720488e2191a3908bc1f503ac369b6f10eea688d680d2935adc8c252d7559", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e1720488e2191a3908bc1f503ac369b6f10eea688d680d2935adc8c252d7559", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e1720488e2191a3908bc1f503ac369b6f10eea688d680d2935adc8c252d7559", kill_on_drop: false }` [INFO] [stdout] 0e1720488e2191a3908bc1f503ac369b6f10eea688d680d2935adc8c252d7559 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 34220ae6a0d012a2b3b49f09bf980b8164115b8ffd6a92a9993fc2aea66d233d [INFO] running `Command { std: "docker" "start" "-a" "34220ae6a0d012a2b3b49f09bf980b8164115b8ffd6a92a9993fc2aea66d233d", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Checking once_cell v1.13.1 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Compiling crossbeam-epoch v0.9.10 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling ntest_proc_macro_helper v0.8.0 [INFO] [stderr] Compiling rayon-core v1.9.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Checking either v1.8.0 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking nom v7.1.1 [INFO] [stderr] Checking crossbeam-deque v0.8.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking crossbeam-channel v0.5.6 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling rayon v1.5.3 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking glasses v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Checking plotters-backend v0.3.4 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking plotters-svg v0.3.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking env_logger v0.9.1 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking plotters v0.3.4 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Compiling toml v0.5.9 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking csv v1.1.6 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling thiserror-impl v1.0.33 [INFO] [stderr] Compiling ntest_test_cases v0.8.0 [INFO] [stderr] Compiling thiserror v1.0.33 [INFO] [stderr] Compiling proc-macro-crate v1.2.1 [INFO] [stderr] Compiling ntest_timeout v0.8.1 [INFO] [stderr] Checking ntest v0.8.1 [INFO] [stderr] Checking steel v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:69:22 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn pre_parsed(program: ID) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | Self { [INFO] [stdout] 69 | program: FromStore(program), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:70:15 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn pre_parsed(program: ID) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | ..Self::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compact_arena.rs:115:26 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn add>(&mut self, value: S) -> Index { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | self.add_with_id(|_id| value) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compiler_context.rs:14:12 [INFO] [stdout] | [INFO] [stdout] 11 | fn overwrite(&mut self, id: ID, mut value: T) -> Result, E> { [INFO] [stdout] | ------ ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 14 | Ok(Some(value)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecs/mod.rs:147:12 [INFO] [stdout] | [INFO] [stdout] 141 | fn overwrite(&mut self, id: EntityId, value: T) -> Result, EcsError> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 147 | Ok(None) // The value didn't exist [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ecs/providers.rs:31:26 [INFO] [stdout] | [INFO] [stdout] 30 | fn add_component(&mut self, value: T) -> EntityId { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | self.add_with_id(|_id| value) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 19 | imp: F, [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | imp: Arc::new(Mutex::new(imp)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/interpreter.rs:360:8 [INFO] [stdout] | [INFO] [stdout] 340 | op: F, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | ) -> Result, SteelErr> { [INFO] [stdout] 342 | let l = state.get_value_for("arg_0")?.cloned(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 351 | let r = state.get_value_for("arg_1")?.cloned(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 360 | Ok(Value::I64(op(l, r))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | raw_tag::<&str, &str, SteelErr>(raw)(input) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:20:26 [INFO] [stdout] | [INFO] [stdout] 20 | .map_err(|e| SteelErr::ErrorExpected(Box::new(e.into()), raw.to_string()).into()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:39:8 [INFO] [stdout] | [INFO] [stdout] 38 | let id = context.add(value); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | Ok((input, id)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:80:8 [INFO] [stdout] | [INFO] [stdout] 79 | let id = context.add(symbol); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | Ok((input, id)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:121:8 [INFO] [stdout] | [INFO] [stdout] 120 | let id = context.add(operator); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 121 | Ok((input, id)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tombstoning_arena.rs:126:26 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn add>(&mut self, value: S) -> Index { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | self.add_with_id(|_id| value) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 14 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `steel` (lib) due to 15 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "34220ae6a0d012a2b3b49f09bf980b8164115b8ffd6a92a9993fc2aea66d233d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "34220ae6a0d012a2b3b49f09bf980b8164115b8ffd6a92a9993fc2aea66d233d", kill_on_drop: false }` [INFO] [stdout] 34220ae6a0d012a2b3b49f09bf980b8164115b8ffd6a92a9993fc2aea66d233d