[INFO] cloning repository https://github.com/Corallus-Caninus/Rot_Net [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Corallus-Caninus/Rot_Net" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCorallus-Caninus%2FRot_Net", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCorallus-Caninus%2FRot_Net'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c141dcf3ed31eac076c7b22760a373adf7ad4c7d [INFO] checking Corallus-Caninus/Rot_Net/c141dcf3ed31eac076c7b22760a373adf7ad4c7d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCorallus-Caninus%2FRot_Net" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Corallus-Caninus/Rot_Net on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Corallus-Caninus/Rot_Net [INFO] finished tweaking git repo https://github.com/Corallus-Caninus/Rot_Net [INFO] tweaked toml for git repo https://github.com/Corallus-Caninus/Rot_Net written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Corallus-Caninus/Rot_Net already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 55bd477867dac54b81f4e66da0486f25645e4f2e9e13f234b5cff2519a010cc3 [INFO] running `Command { std: "docker" "start" "-a" "55bd477867dac54b81f4e66da0486f25645e4f2e9e13f234b5cff2519a010cc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "55bd477867dac54b81f4e66da0486f25645e4f2e9e13f234b5cff2519a010cc3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "55bd477867dac54b81f4e66da0486f25645e4f2e9e13f234b5cff2519a010cc3", kill_on_drop: false }` [INFO] [stdout] 55bd477867dac54b81f4e66da0486f25645e4f2e9e13f234b5cff2519a010cc3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] df907693c7b3d4c66608889195cc08b8a80568f09251ca186b49c4649fdb48b2 [INFO] running `Command { std: "docker" "start" "-a" "df907693c7b3d4c66608889195cc08b8a80568f09251ca186b49c4649fdb48b2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling crossbeam-utils v0.8.4 [INFO] [stderr] Compiling memoffset v0.6.3 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking itertools v0.10.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.4 [INFO] [stderr] Checking crossbeam-channel v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking time v0.1.43 [INFO] [stderr] Checking rand_core v0.6.2 [INFO] [stderr] Checking timeit v0.1.2 [INFO] [stderr] Checking rand_chacha v0.3.0 [INFO] [stderr] Checking rand v0.8.3 [INFO] [stderr] Checking rot_net v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `rand::*` [INFO] [stdout] --> src/lib.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | use rand::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/lib.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::Ordering` [INFO] [stdout] --> src/lib.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | use std::cmp::Ordering; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Index` [INFO] [stdout] --> src/lib.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | use std::ops::Index; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mutex` [INFO] [stdout] --> src/lib.rs:21:26 [INFO] [stdout] | [INFO] [stdout] 21 | use std::sync::{Arc, Mutex, RwLock, Weak}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `connection` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:435:16 [INFO] [stdout] | [INFO] [stdout] 435 | pub struct connection { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Connection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `node` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:456:16 [INFO] [stdout] | [INFO] [stdout] 456 | pub struct node { [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case: `Node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `rot_net` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:520:16 [INFO] [stdout] | [INFO] [stdout] 520 | pub struct rot_net { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `RotNet` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::*` [INFO] [stdout] --> src/lib.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | use rand::*; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cell::RefCell` [INFO] [stdout] --> src/lib.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | use std::cell::RefCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::Ordering` [INFO] [stdout] --> src/lib.rs:17:9 [INFO] [stdout] | [INFO] [stdout] 17 | use std::cmp::Ordering; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::ops::Index` [INFO] [stdout] --> src/lib.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 19 | use std::ops::Index; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Mutex` [INFO] [stdout] --> src/lib.rs:21:26 [INFO] [stdout] | [INFO] [stdout] 21 | use std::sync::{Arc, Mutex, RwLock, Weak}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `connection` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:435:16 [INFO] [stdout] | [INFO] [stdout] 435 | pub struct connection { [INFO] [stdout] | ^^^^^^^^^^ help: convert the identifier to upper camel case (notice the capitalization): `Connection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `node` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:456:16 [INFO] [stdout] | [INFO] [stdout] 456 | pub struct node { [INFO] [stdout] | ^^^^ help: convert the identifier to upper camel case: `Node` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `rot_net` should have an upper camel case name [INFO] [stdout] --> src/lib.rs:520:16 [INFO] [stdout] | [INFO] [stdout] 520 | pub struct rot_net { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to upper camel case: `RotNet` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:545:21 [INFO] [stdout] | [INFO] [stdout] 545 | let mut new_node = node { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:569:21 [INFO] [stdout] | [INFO] [stdout] 569 | let mut new_node = Arc::new(RwLock::new(node { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:545:21 [INFO] [stdout] | [INFO] [stdout] 545 | let mut new_node = node { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:737:17 [INFO] [stdout] | [INFO] [stdout] 737 | let mut output_node = self.get_node(output_node_id); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:748:17 [INFO] [stdout] | [INFO] [stdout] 748 | let mut input_node = self.get_node(input_node_id); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:768:17 [INFO] [stdout] | [INFO] [stdout] 768 | let mut new_node = Arc::new(RwLock::new(node { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:569:21 [INFO] [stdout] | [INFO] [stdout] 569 | let mut new_node = Arc::new(RwLock::new(node { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:737:17 [INFO] [stdout] | [INFO] [stdout] 737 | let mut output_node = self.get_node(output_node_id); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:748:17 [INFO] [stdout] | [INFO] [stdout] 748 | let mut input_node = self.get_node(input_node_id); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:768:17 [INFO] [stdout] | [INFO] [stdout] 768 | let mut new_node = Arc::new(RwLock::new(node { [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1042:21 [INFO] [stdout] | [INFO] [stdout] 1042 | let mut ready_nodes = [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1044:21 [INFO] [stdout] | [INFO] [stdout] 1044 | let mut halted_nodes = [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `initial_differential` [INFO] [stdout] --> src/lib.rs:1175:17 [INFO] [stdout] | [INFO] [stdout] 1175 | let initial_differential = true_outputs [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_initial_differential` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error_distance` is never read [INFO] [stdout] --> src/lib.rs:1180:29 [INFO] [stdout] | [INFO] [stdout] 1180 | let mut error_distance = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:621:30 [INFO] [stdout] | [INFO] [stdout] 621 | .find(|node| node.read().unwrap().id == index) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1042:21 [INFO] [stdout] | [INFO] [stdout] 1042 | let mut ready_nodes = [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:710:25 [INFO] [stdout] | [INFO] [stdout] 709 | .map(|node| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 710 | / node.upgrade() [INFO] [stdout] 711 | | .unwrap() [INFO] [stdout] 712 | | .read() [INFO] [stdout] 713 | | .unwrap() [INFO] [stdout] 714 | | .connections [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:925:37 [INFO] [stdout] | [INFO] [stdout] 923 | ... .map(move |connection_param| { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 924 | ... ( [INFO] [stdout] 925 | / ... self.get_node( [INFO] [stdout] 926 | | ... connection_param [INFO] [stdout] 927 | | ... .output_node [INFO] [stdout] 928 | | ... .upgrade() [INFO] [stdout] ... | [INFO] [stdout] 932 | | ... .id, [INFO] [stdout] 933 | | ... ), [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:958:38 [INFO] [stdout] | [INFO] [stdout] 958 | .group_by(|node| node.0.read().unwrap().id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:963:25 [INFO] [stdout] | [INFO] [stdout] 960 | .map(|(key, group)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 963 | self.get_node(key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:964:25 [INFO] [stdout] | [INFO] [stdout] 960 | .map(|(key, group)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 964 | / group [INFO] [stdout] 965 | | .into_iter() [INFO] [stdout] 966 | | .map(|node| node.1.clone()) [INFO] [stdout] 967 | | .flatten() [INFO] [stdout] 968 | | .collect::, u8)>>(), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:995:37 [INFO] [stdout] | [INFO] [stdout] 995 | .map(|node| node.0.read().unwrap().id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1065:25 [INFO] [stdout] | [INFO] [stdout] 1052 | .map(|node| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1065 | node.0.read().unwrap().connections.par_iter().map(|out_connection|{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1086:42 [INFO] [stdout] | [INFO] [stdout] 1086 | .group_by(|node| node.0.read().unwrap().id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1091:33 [INFO] [stdout] | [INFO] [stdout] 1088 | .map(|(key, group)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1091 | self.get_node(key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1092:33 [INFO] [stdout] | [INFO] [stdout] 1088 | .map(|(key, group)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1092 | / group [INFO] [stdout] 1093 | | .into_iter() [INFO] [stdout] 1094 | | .map(|group_node| { [INFO] [stdout] 1095 | | group_node.1.clone() [INFO] [stdout] ... | [INFO] [stdout] 1098 | | .collect::, u8)>>( [INFO] [stdout] 1099 | | ), [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1118:34 [INFO] [stdout] | [INFO] [stdout] 1118 | .group_by(|node| node.0.read().unwrap().id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1121:21 [INFO] [stdout] | [INFO] [stdout] 1120 | .map(|(_key, group)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1121 | group.into_iter().collect:: [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1044:21 [INFO] [stdout] | [INFO] [stdout] 1044 | let mut halted_nodes = [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `initial_differential` [INFO] [stdout] --> src/lib.rs:1175:17 [INFO] [stdout] | [INFO] [stdout] 1175 | let initial_differential = true_outputs [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_initial_differential` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `error_distance` is never read [INFO] [stdout] --> src/lib.rs:1180:29 [INFO] [stdout] | [INFO] [stdout] 1180 | let mut error_distance = 0; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:621:30 [INFO] [stdout] | [INFO] [stdout] 621 | .find(|node| node.read().unwrap().id == index) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:710:25 [INFO] [stdout] | [INFO] [stdout] 709 | .map(|node| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 710 | / node.upgrade() [INFO] [stdout] 711 | | .unwrap() [INFO] [stdout] 712 | | .read() [INFO] [stdout] 713 | | .unwrap() [INFO] [stdout] 714 | | .connections [INFO] [stdout] | |________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rot_net` (lib test) due to 14 previous errors; 17 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:925:37 [INFO] [stdout] | [INFO] [stdout] 923 | ... .map(move |connection_param| { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 924 | ... ( [INFO] [stdout] 925 | / ... self.get_node( [INFO] [stdout] 926 | | ... connection_param [INFO] [stdout] 927 | | ... .output_node [INFO] [stdout] 928 | | ... .upgrade() [INFO] [stdout] ... | [INFO] [stdout] 932 | | ... .id, [INFO] [stdout] 933 | | ... ), [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:958:38 [INFO] [stdout] | [INFO] [stdout] 958 | .group_by(|node| node.0.read().unwrap().id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:963:25 [INFO] [stdout] | [INFO] [stdout] 960 | .map(|(key, group)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 963 | self.get_node(key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:964:25 [INFO] [stdout] | [INFO] [stdout] 960 | .map(|(key, group)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 964 | / group [INFO] [stdout] 965 | | .into_iter() [INFO] [stdout] 966 | | .map(|node| node.1.clone()) [INFO] [stdout] 967 | | .flatten() [INFO] [stdout] 968 | | .collect::, u8)>>(), [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:995:37 [INFO] [stdout] | [INFO] [stdout] 995 | .map(|node| node.0.read().unwrap().id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1065:25 [INFO] [stdout] | [INFO] [stdout] 1052 | .map(|node| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1065 | node.0.read().unwrap().connections.par_iter().map(|out_connection|{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1086:42 [INFO] [stdout] | [INFO] [stdout] 1086 | .group_by(|node| node.0.read().unwrap().id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1091:33 [INFO] [stdout] | [INFO] [stdout] 1088 | .map(|(key, group)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1091 | self.get_node(key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1092:33 [INFO] [stdout] | [INFO] [stdout] 1088 | .map(|(key, group)| { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1092 | / group [INFO] [stdout] 1093 | | .into_iter() [INFO] [stdout] 1094 | | .map(|group_node| { [INFO] [stdout] 1095 | | group_node.1.clone() [INFO] [stdout] ... | [INFO] [stdout] 1098 | | .collect::, u8)>>( [INFO] [stdout] 1099 | | ), [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1118:34 [INFO] [stdout] | [INFO] [stdout] 1118 | .group_by(|node| node.0.read().unwrap().id) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1121:21 [INFO] [stdout] | [INFO] [stdout] 1120 | .map(|(_key, group)| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1121 | group.into_iter().collect:: [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 17 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rot_net` (lib) due to 14 previous errors; 17 warnings emitted [INFO] running `Command { std: "docker" "inspect" "df907693c7b3d4c66608889195cc08b8a80568f09251ca186b49c4649fdb48b2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df907693c7b3d4c66608889195cc08b8a80568f09251ca186b49c4649fdb48b2", kill_on_drop: false }` [INFO] [stdout] df907693c7b3d4c66608889195cc08b8a80568f09251ca186b49c4649fdb48b2