[INFO] cloning repository https://github.com/Community-network/rust-tdf [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Community-network/rust-tdf" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCommunity-network%2Frust-tdf", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCommunity-network%2Frust-tdf'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 81ffb2f9da46371f9925e781bb81d089ca2e2a24 [INFO] checking Community-network/rust-tdf/81ffb2f9da46371f9925e781bb81d089ca2e2a24 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCommunity-network%2Frust-tdf" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Community-network/rust-tdf on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Community-network/rust-tdf [INFO] finished tweaking git repo https://github.com/Community-network/rust-tdf [INFO] tweaked toml for git repo https://github.com/Community-network/rust-tdf written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Community-network/rust-tdf already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49618760f324b75d9d6eef103f3611e3e2e6aeb26bd800f002188aa406541149 [INFO] running `Command { std: "docker" "start" "-a" "49618760f324b75d9d6eef103f3611e3e2e6aeb26bd800f002188aa406541149", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49618760f324b75d9d6eef103f3611e3e2e6aeb26bd800f002188aa406541149", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49618760f324b75d9d6eef103f3611e3e2e6aeb26bd800f002188aa406541149", kill_on_drop: false }` [INFO] [stdout] 49618760f324b75d9d6eef103f3611e3e2e6aeb26bd800f002188aa406541149 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d01587da846d4dbf0c3bd9fdb65aec6488ff2f48282e8b6bfb1ae1a7c8c33046 [INFO] running `Command { std: "docker" "start" "-a" "d01587da846d4dbf0c3bd9fdb65aec6488ff2f48282e8b6bfb1ae1a7c8c33046", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.125 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Compiling anyhow v1.0.42 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking peekread v0.1.1 [INFO] [stderr] Compiling itertools v0.10.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.3.9 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking simple_logger v2.1.0 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Compiling macro-tdf v0.1.0 (/opt/rustwide/workdir/macro-tdf) [INFO] [stdout] warning: unused import: `itertools::Itertools` [INFO] [stdout] --> macro-tdf/src/lib.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use itertools::Itertools; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> macro-tdf/src/lib.rs:46:9 [INFO] [stdout] | [INFO] [stdout] 46 | let mut fields = match data_struct_fields { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `comp_ident` is never used [INFO] [stdout] --> macro-tdf/src/lib.rs:11:4 [INFO] [stdout] | [INFO] [stdout] 11 | fn comp_ident(path: &syn::Path, name: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `ind_to_string` is never used [INFO] [stdout] --> macro-tdf/src/lib.rs:67:4 [INFO] [stdout] | [INFO] [stdout] 67 | fn ind_to_string(field: &Field) -> String { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking tdf v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `super::des::Deserialize` [INFO] [stdout] --> src/rtdf/ser.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use super::des::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Serialize` [INFO] [stdout] --> src/rtdf/des.rs:3:120 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::rtdf::{GenericContent, GenericType, ObjectId, ObjectType, IntList, Union, IpAddress, Localization, Generic, Serialize}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/json/ser.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BigEndian` and `WriteBytesExt` [INFO] [stdout] --> src/json/ser.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use byteorder::{BigEndian, WriteBytesExt}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PeekRead` and `SeekPeekReader` [INFO] [stdout] --> src/json/des.rs:2:16 [INFO] [stdout] | [INFO] [stdout] 2 | use peekread::{PeekRead, SeekPeekReader}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Read` and `Seek` [INFO] [stdout] --> src/json/des.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{Read, Seek}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BigEndian` and `ReadBytesExt` [INFO] [stdout] --> src/json/des.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use byteorder::{BigEndian, ReadBytesExt}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::des::Deserialize` [INFO] [stdout] --> src/rtdf/ser.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use super::des::Deserialize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Serialize` [INFO] [stdout] --> src/rtdf/des.rs:3:120 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::rtdf::{GenericContent, GenericType, ObjectId, ObjectType, IntList, Union, IpAddress, Localization, Generic, Serialize}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Write` [INFO] [stdout] --> src/json/ser.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{Write}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BigEndian` and `WriteBytesExt` [INFO] [stdout] --> src/json/ser.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use byteorder::{BigEndian, WriteBytesExt}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PeekRead` and `SeekPeekReader` [INFO] [stdout] --> src/json/des.rs:2:16 [INFO] [stdout] | [INFO] [stdout] 2 | use peekread::{PeekRead, SeekPeekReader}; [INFO] [stdout] | ^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Read` and `Seek` [INFO] [stdout] --> src/json/des.rs:3:15 [INFO] [stdout] | [INFO] [stdout] 3 | use std::io::{Read, Seek}; [INFO] [stdout] | ^^^^ ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `BigEndian` and `ReadBytesExt` [INFO] [stdout] --> src/json/des.rs:5:17 [INFO] [stdout] | [INFO] [stdout] 5 | use byteorder::{BigEndian, ReadBytesExt}; [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `has_bug` [INFO] [stdout] --> src/btdf/des.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | let has_bug = self.des_label(reader)?; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_has_bug` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `has_bug` [INFO] [stdout] --> src/btdf/des.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 133 | let has_bug = self.des_label(reader)?; [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_has_bug` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/json/des.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let key = self.read_string()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rtdf/ser.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 75 | let expected_type = match T::serialize( self) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Ok(t) => t, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Err(e) => bail!("Error serializing field ({}, {:?}): {}", label_string, value_type, e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok((label_string, expected_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rtdf/ser.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 93 | let (_, value) = self.ser_field::()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | Ok(Some(value)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdf` (lib) due to 3 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/json/des.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | let key = self.read_string()?; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rtdf/ser.rs:80:12 [INFO] [stdout] | [INFO] [stdout] 75 | let expected_type = match T::serialize( self) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | Ok(t) => t, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Err(e) => bail!("Error serializing field ({}, {:?}): {}", label_string, value_type, e), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | Ok((label_string, expected_type)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rtdf/ser.rs:95:12 [INFO] [stdout] | [INFO] [stdout] 93 | let (_, value) = self.ser_field::()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | Ok(Some(value)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `tdf` (lib test) due to 3 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d01587da846d4dbf0c3bd9fdb65aec6488ff2f48282e8b6bfb1ae1a7c8c33046", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d01587da846d4dbf0c3bd9fdb65aec6488ff2f48282e8b6bfb1ae1a7c8c33046", kill_on_drop: false }` [INFO] [stdout] d01587da846d4dbf0c3bd9fdb65aec6488ff2f48282e8b6bfb1ae1a7c8c33046