[INFO] cloning repository https://github.com/Colon-D/nights-multiplayer-server [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Colon-D/nights-multiplayer-server" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColon-D%2Fnights-multiplayer-server", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColon-D%2Fnights-multiplayer-server'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2ac35011a5c66f2f354160ec7a77b3180737294b [INFO] checking Colon-D/nights-multiplayer-server/2ac35011a5c66f2f354160ec7a77b3180737294b against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColon-D%2Fnights-multiplayer-server" "/workspace/builds/worker-2-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Colon-D/nights-multiplayer-server on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Colon-D/nights-multiplayer-server [INFO] finished tweaking git repo https://github.com/Colon-D/nights-multiplayer-server [INFO] tweaked toml for git repo https://github.com/Colon-D/nights-multiplayer-server written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Colon-D/nights-multiplayer-server already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 23d07365ce85dc52b797fffadfff1f0fd65e62d3a4662de070b7dd75c726db6c [INFO] running `Command { std: "docker" "start" "-a" "23d07365ce85dc52b797fffadfff1f0fd65e62d3a4662de070b7dd75c726db6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "23d07365ce85dc52b797fffadfff1f0fd65e62d3a4662de070b7dd75c726db6c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "23d07365ce85dc52b797fffadfff1f0fd65e62d3a4662de070b7dd75c726db6c", kill_on_drop: false }` [INFO] [stdout] 23d07365ce85dc52b797fffadfff1f0fd65e62d3a4662de070b7dd75c726db6c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1ba6574d6e139296e4396c3076eba998361f503cdf61b69fa785cf6c732cc42f [INFO] running `Command { std: "docker" "start" "-a" "1ba6574d6e139296e4396c3076eba998361f503cdf61b69fa785cf6c732cc42f", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Compiling serde v1.0.185 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling thiserror v1.0.47 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.29 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking clap_builder v4.3.23 [INFO] [stderr] Compiling serde_derive v1.0.185 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Compiling thiserror-impl v1.0.47 [INFO] [stderr] Checking clap v4.3.23 [INFO] [stderr] Checking nights-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/main.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | index: usize, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:220:17 [INFO] [stdout] | [INFO] [stdout] 220 | let mut clients = clients.lock().unwrap(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 112 | | serde_json::from_slice(&buffer).map_err(|e| DataError::JsonError(e))?, [INFO] [stdout] 113 | | remote, [INFO] [stdout] 114 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | handle_client(udp_socket, &mut stream, udp_socket_addr, index, &clients); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 302 | let _ = handle_client(udp_socket, &mut stream, udp_socket_addr, index, &clients); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nights-server` (bin "nights-server" test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `index` [INFO] [stdout] --> src/main.rs:183:5 [INFO] [stdout] | [INFO] [stdout] 183 | index: usize, [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_index` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/main.rs:220:17 [INFO] [stdout] | [INFO] [stdout] 220 | let mut clients = clients.lock().unwrap(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:111:8 [INFO] [stdout] | [INFO] [stdout] 111 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 112 | | serde_json::from_slice(&buffer).map_err(|e| DataError::JsonError(e))?, [INFO] [stdout] 113 | | remote, [INFO] [stdout] 114 | | )) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | handle_client(udp_socket, &mut stream, udp_socket_addr, index, &clients); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 302 | let _ = handle_client(udp_socket, &mut stream, udp_socket_addr, index, &clients); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `nights-server` (bin "nights-server") due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1ba6574d6e139296e4396c3076eba998361f503cdf61b69fa785cf6c732cc42f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ba6574d6e139296e4396c3076eba998361f503cdf61b69fa785cf6c732cc42f", kill_on_drop: false }` [INFO] [stdout] 1ba6574d6e139296e4396c3076eba998361f503cdf61b69fa785cf6c732cc42f