[INFO] cloning repository https://github.com/ColmTalbot/bilby_rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ColmTalbot/bilby_rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColmTalbot%2Fbilby_rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColmTalbot%2Fbilby_rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 219183cb59f3a9e3c2a8c92cbbfeb411e61725c1 [INFO] checking ColmTalbot/bilby_rust/219183cb59f3a9e3c2a8c92cbbfeb411e61725c1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FColmTalbot%2Fbilby_rust" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ColmTalbot/bilby_rust on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/ColmTalbot/bilby_rust [INFO] finished tweaking git repo https://github.com/ColmTalbot/bilby_rust [INFO] tweaked toml for git repo https://github.com/ColmTalbot/bilby_rust written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ColmTalbot/bilby_rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] af0575430da2c456a1db0e2531c84dd8be65e967da0387778ac2e81c8920431f [INFO] running `Command { std: "docker" "start" "-a" "af0575430da2c456a1db0e2531c84dd8be65e967da0387778ac2e81c8920431f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "af0575430da2c456a1db0e2531c84dd8be65e967da0387778ac2e81c8920431f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af0575430da2c456a1db0e2531c84dd8be65e967da0387778ac2e81c8920431f", kill_on_drop: false }` [INFO] [stdout] af0575430da2c456a1db0e2531c84dd8be65e967da0387778ac2e81c8920431f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 025e5c9f8b53985927f83ea5f7b6413b282317d06e84b9acba1480543c4ab271 [INFO] running `Command { std: "docker" "start" "-a" "025e5c9f8b53985927f83ea5f7b6413b282317d06e84b9acba1480543c4ab271", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.15 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ndarray v0.15.6 [INFO] [stderr] Compiling pyo3-build-config v0.21.2 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling syn v2.0.71 [INFO] [stderr] Compiling pyo3-ffi v0.21.2 [INFO] [stderr] Compiling pyo3 v0.21.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.21.2 [INFO] [stderr] Compiling pyo3-macros v0.21.2 [INFO] [stderr] Checking numpy v0.21.0 [INFO] [stderr] Checking bilby_rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/antenna.rs:294:27 [INFO] [stdout] | [INFO] [stdout] 294 | Python::with_gil(|py| PyArray1::from_vec_bound(py, times).unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/antenna.rs:327:27 [INFO] [stdout] | [INFO] [stdout] 327 | Python::with_gil(|py| PyArray3::from_vec3_bound(py, &output).unwrap().unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/response.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | Python::with_gil(|py| PyArray3::from_vec3_bound(py, &output).unwrap().unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/response.rs:61:27 [INFO] [stdout] | [INFO] [stdout] 61 | Python::with_gil(|py| PyArray1::from_vec_bound(py, output).unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/response.rs:143:27 [INFO] [stdout] | [INFO] [stdout] 143 | Python::with_gil(|py| PyArray2::from_vec2_bound(py, &output).unwrap().unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/three.rs:200:31 [INFO] [stdout] | [INFO] [stdout] 200 | Python::with_gil(|py| PyArray1::from_vec_bound(py, output).unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/three.rs:392:31 [INFO] [stdout] | [INFO] [stdout] 392 | Python::with_gil(|py| PyArray2::from_vec2_bound(py, &output).unwrap().unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | Python::with_gil(|py| PyArray1::from_vec_bound(py, times).unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bilby_rust` (lib) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/antenna.rs:294:27 [INFO] [stdout] | [INFO] [stdout] 294 | Python::with_gil(|py| PyArray1::from_vec_bound(py, times).unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/antenna.rs:327:27 [INFO] [stdout] | [INFO] [stdout] 327 | Python::with_gil(|py| PyArray3::from_vec3_bound(py, &output).unwrap().unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/response.rs:34:27 [INFO] [stdout] | [INFO] [stdout] 34 | Python::with_gil(|py| PyArray3::from_vec3_bound(py, &output).unwrap().unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/response.rs:61:27 [INFO] [stdout] | [INFO] [stdout] 61 | Python::with_gil(|py| PyArray1::from_vec_bound(py, output).unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/response.rs:143:27 [INFO] [stdout] | [INFO] [stdout] 143 | Python::with_gil(|py| PyArray2::from_vec2_bound(py, &output).unwrap().unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/three.rs:200:31 [INFO] [stdout] | [INFO] [stdout] 200 | Python::with_gil(|py| PyArray1::from_vec_bound(py, output).unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/geometry/three.rs:392:31 [INFO] [stdout] | [INFO] [stdout] 392 | Python::with_gil(|py| PyArray2::from_vec2_bound(py, &output).unwrap().unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/time.rs:174:27 [INFO] [stdout] | [INFO] [stdout] 174 | Python::with_gil(|py| PyArray1::from_vec_bound(py, times).unbind()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bilby_rust` (lib test) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "025e5c9f8b53985927f83ea5f7b6413b282317d06e84b9acba1480543c4ab271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "025e5c9f8b53985927f83ea5f7b6413b282317d06e84b9acba1480543c4ab271", kill_on_drop: false }` [INFO] [stdout] 025e5c9f8b53985927f83ea5f7b6413b282317d06e84b9acba1480543c4ab271