[INFO] cloning repository https://github.com/College-Kings/game-builder [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/College-Kings/game-builder" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCollege-Kings%2Fgame-builder", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCollege-Kings%2Fgame-builder'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f2fd1fd41cf0d09ed1dbaa99f0e11f2620ece46c [INFO] checking College-Kings/game-builder/f2fd1fd41cf0d09ed1dbaa99f0e11f2620ece46c against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCollege-Kings%2Fgame-builder" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/College-Kings/game-builder on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/College-Kings/game-builder [INFO] finished tweaking git repo https://github.com/College-Kings/game-builder [INFO] tweaked toml for git repo https://github.com/College-Kings/game-builder written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/College-Kings/game-builder already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d6c850b227466c581af5792847aea1937cbae5bd5c064472b96282ff2aa757a4 [INFO] running `Command { std: "docker" "start" "-a" "d6c850b227466c581af5792847aea1937cbae5bd5c064472b96282ff2aa757a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d6c850b227466c581af5792847aea1937cbae5bd5c064472b96282ff2aa757a4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d6c850b227466c581af5792847aea1937cbae5bd5c064472b96282ff2aa757a4", kill_on_drop: false }` [INFO] [stdout] d6c850b227466c581af5792847aea1937cbae5bd5c064472b96282ff2aa757a4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f79f6080e9869a482eeff64fe9502867c4bde64d9e57f7fb1c6105e7d627f89 [INFO] running `Command { std: "docker" "start" "-a" "0f79f6080e9869a482eeff64fe9502867c4bde64d9e57f7fb1c6105e7d627f89", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling cc v1.0.97 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking equivalent v1.0.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking openssl-probe v0.1.5 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling syn v2.0.63 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.4.4 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking bunny-cdn-wrapper v0.1.0 (https://github.com/ViridianLink/bunny-cdn-wrapper#82bad1a5) [INFO] [stderr] Checking game-builder v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:78:47 [INFO] [stdout] | [INFO] [stdout] 78 | .ok_or_else(|| Error::VersionNotFound(contents.as_str().into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:80:47 [INFO] [stdout] | [INFO] [stdout] 80 | .ok_or_else(|| Error::VersionNotFound(contents.as_str().into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:78:47 [INFO] [stdout] | [INFO] [stdout] 78 | .ok_or_else(|| Error::VersionNotFound(contents.as_str().into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:80:47 [INFO] [stdout] | [INFO] [stdout] 80 | .ok_or_else(|| Error::VersionNotFound(contents.as_str().into()))? [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patreon.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn patreon_thread(version: Arc) -> Result<(ThreadHandle, ThreadHandle)> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let pc_thread = thread::spawn(|| build_game("pc", "zip")); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | thread::sleep(Duration::from_secs(30)); [INFO] [stdout] 12 | let mac_thread = thread::spawn(|| build_game("mac", "zip")); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let pc_thread = tokio::spawn(upload_game(format!( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let mac_thread = tokio::spawn(upload_game(format!( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok((pc_thread, mac_thread)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/steam/mod.rs:20:43 [INFO] [stdout] | [INFO] [stdout] 20 | .ok_or_else(|| Error::InvalidGame(GAME_NAME.into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/patreon.rs:28:8 [INFO] [stdout] | [INFO] [stdout] 9 | pub fn patreon_thread(version: Arc) -> Result<(ThreadHandle, ThreadHandle)> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let pc_thread = thread::spawn(|| build_game("pc", "zip")); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | thread::sleep(Duration::from_secs(30)); [INFO] [stdout] 12 | let mac_thread = thread::spawn(|| build_game("mac", "zip")); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | let pc_thread = tokio::spawn(upload_game(format!( [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let mac_thread = tokio::spawn(upload_game(format!( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | Ok((pc_thread, mac_thread)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/steam/mod.rs:20:43 [INFO] [stdout] | [INFO] [stdout] 20 | .ok_or_else(|| Error::InvalidGame(GAME_NAME.into()))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `game-builder` (bin "game-builder" test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `game-builder` (bin "game-builder") due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "0f79f6080e9869a482eeff64fe9502867c4bde64d9e57f7fb1c6105e7d627f89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f79f6080e9869a482eeff64fe9502867c4bde64d9e57f7fb1c6105e7d627f89", kill_on_drop: false }` [INFO] [stdout] 0f79f6080e9869a482eeff64fe9502867c4bde64d9e57f7fb1c6105e7d627f89