[INFO] cloning repository https://github.com/CodeMan99/devconf [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/CodeMan99/devconf" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCodeMan99%2Fdevconf", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCodeMan99%2Fdevconf'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] cf16c99742658687b2a6e9b4d654d8713e60c1dd [INFO] checking CodeMan99/devconf/cf16c99742658687b2a6e9b4d654d8713e60c1dd against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCodeMan99%2Fdevconf" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/CodeMan99/devconf on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/CodeMan99/devconf [INFO] finished tweaking git repo https://github.com/CodeMan99/devconf [INFO] tweaked toml for git repo https://github.com/CodeMan99/devconf written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/CodeMan99/devconf already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e4ef0ad11e9892c85cd706841a7d380b6c865fb42bbca280af2dcc0bca482f41 [INFO] running `Command { std: "docker" "start" "-a" "e4ef0ad11e9892c85cd706841a7d380b6c865fb42bbca280af2dcc0bca482f41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e4ef0ad11e9892c85cd706841a7d380b6c865fb42bbca280af2dcc0bca482f41", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4ef0ad11e9892c85cd706841a7d380b6c865fb42bbca280af2dcc0bca482f41", kill_on_drop: false }` [INFO] [stdout] e4ef0ad11e9892c85cd706841a7d380b6c865fb42bbca280af2dcc0bca482f41 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1f5c90a7c894512a25f367c9faf14ceecb187c9ff3020c1354dff00aaf1e65dc [INFO] running `Command { std: "docker" "start" "-a" "1f5c90a7c894512a25f367c9faf14ceecb187c9ff3020c1354dff00aaf1e65dc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling serde_json v1.0.121 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking object v0.36.2 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking winnow v0.6.16 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking webpki-roots v0.26.3 [INFO] [stderr] Checking filetime v0.2.23 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling serde_jsonc v1.0.108 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking crossterm v0.25.0 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking termion v2.0.3 [INFO] [stderr] Checking newline-converter v0.2.2 [INFO] [stderr] Checking directories v5.0.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking base16ct v0.2.0 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking ascii_table v4.0.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking human_format v1.1.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking xattr v1.3.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking tar v0.4.41 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Compiling getset v0.1.2 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Checking inquire v0.6.2 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking clap-verbosity-flag v2.2.1 [INFO] [stderr] Checking clap_complete v4.5.11 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling derive_builder_core v0.20.0 [INFO] [stderr] Compiling derive_builder_macro v0.20.0 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Checking derive_builder v0.20.0 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_edit v0.22.18 [INFO] [stderr] Checking ureq v2.10.0 [INFO] [stderr] Checking oci-spec v0.6.8 [INFO] [stderr] Checking toml v0.8.17 [INFO] [stderr] Checking ocipkg v0.3.9 [INFO] [stderr] Checking tyedev v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:562:8 [INFO] [stdout] | [INFO] [stdout] 463 | pub fn read_devcontainer_index>(filename: P) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 467 | let json_value: JsonValue = serde_json::from_str(&file)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 470 | let collections: Vec = json_value [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 562 | Ok(DevcontainerIndex { collections }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:475:20 [INFO] [stdout] | [INFO] [stdout] 475 | || Err(Error::new(ErrorKind::InvalidData, "Unexpected json shape")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:543:30 [INFO] [stdout] | [INFO] [stdout] 500 | let features = features [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 543 | Some(Collection { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 544 | | source_information, [INFO] [stdout] 545 | | features, [INFO] [stdout] 546 | | templates, [INFO] [stdout] 547 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:482:47 [INFO] [stdout] | [INFO] [stdout] 482 | ... .and_then(|value| serde_json::from_value(value.to_owned()).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:502:53 [INFO] [stdout] | [INFO] [stdout] 502 | ... .flat_map(|value| match serde_json::from_value::(value.to_owned()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/registry.rs:528:53 [INFO] [stdout] | [INFO] [stdout] 528 | ... .flat_map(|value| match serde_json::from_value::