[INFO] cloning repository https://github.com/CluEleSsUK/rust-compiler-vm [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/CluEleSsUK/rust-compiler-vm" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCluEleSsUK%2Frust-compiler-vm", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCluEleSsUK%2Frust-compiler-vm'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8aca03b5a9878457c367e46070e6330509eacb56 [INFO] checking CluEleSsUK/rust-compiler-vm/8aca03b5a9878457c367e46070e6330509eacb56 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FCluEleSsUK%2Frust-compiler-vm" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/CluEleSsUK/rust-compiler-vm on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/CluEleSsUK/rust-compiler-vm [INFO] finished tweaking git repo https://github.com/CluEleSsUK/rust-compiler-vm [INFO] tweaked toml for git repo https://github.com/CluEleSsUK/rust-compiler-vm written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/CluEleSsUK/rust-compiler-vm already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ad9da8c3c5596161c3b84654077a0b02633c372319c96af20bd689447fd7bcdc [INFO] running `Command { std: "docker" "start" "-a" "ad9da8c3c5596161c3b84654077a0b02633c372319c96af20bd689447fd7bcdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ad9da8c3c5596161c3b84654077a0b02633c372319c96af20bd689447fd7bcdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad9da8c3c5596161c3b84654077a0b02633c372319c96af20bd689447fd7bcdc", kill_on_drop: false }` [INFO] [stdout] ad9da8c3c5596161c3b84654077a0b02633c372319c96af20bd689447fd7bcdc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26ccc49c4d70b8ede6608a7fc633ad79537310433a37a947e8237a4c127a5565 [INFO] running `Command { std: "docker" "start" "-a" "26ccc49c4d70b8ede6608a7fc633ad79537310433a37a947e8237a4c127a5565", kill_on_drop: false }` [INFO] [stderr] Checking compiler-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/main.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | let output = vm.run(instructions); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `peek` is never used [INFO] [stdout] --> src/stack.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait Stack<'a, T: Clone> { [INFO] [stdout] | ----- method in this trait [INFO] [stdout] 2 | fn pop(&mut self) -> Option>; [INFO] [stdout] 3 | fn peek(&self) -> Option>; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variants `PUSH` and `POP` are never constructed [INFO] [stdout] --> src/vm.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub enum Instruction { [INFO] [stdout] | ----------- variants in this enum [INFO] [stdout] 6 | NOOP, [INFO] [stdout] 7 | PUSH(AddressSize), [INFO] [stdout] | ^^^^ [INFO] [stdout] 8 | POP, [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `STRING` is never constructed [INFO] [stdout] --> src/vm.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum Object { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] 15 | INT(i32), [INFO] [stdout] 16 | STRING(*mut str), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Object` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vm.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | let mut instructions = vec![ [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vm.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | let mut instructions = vec![Instruction::POP]; [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/vm.rs:89:13 [INFO] [stdout] | [INFO] [stdout] 89 | let mut instructions = vec![ [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output` [INFO] [stdout] --> src/main.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 9 | let output = vm.run(instructions); [INFO] [stdout] | ^^^^^^ help: if this is intentional, prefix it with an underscore: `_output` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `peek` is never used [INFO] [stdout] --> src/stack.rs:3:8 [INFO] [stdout] | [INFO] [stdout] 1 | pub trait Stack<'a, T: Clone> { [INFO] [stdout] | ----- method in this trait [INFO] [stdout] 2 | fn pop(&mut self) -> Option>; [INFO] [stdout] 3 | fn peek(&self) -> Option>; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `STRING` is never constructed [INFO] [stdout] --> src/vm.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum Object { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] 15 | INT(i32), [INFO] [stdout] 16 | STRING(*mut str), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Object` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vm.rs:97:21 [INFO] [stdout] | [INFO] [stdout] 88 | let mut vm = VirtualMachine::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | assert_eq!(*vm.run(instructions), Object::INT(5)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `compiler-rust` (bin "compiler-rust" test) due to 2 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "26ccc49c4d70b8ede6608a7fc633ad79537310433a37a947e8237a4c127a5565", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26ccc49c4d70b8ede6608a7fc633ad79537310433a37a947e8237a4c127a5565", kill_on_drop: false }` [INFO] [stdout] 26ccc49c4d70b8ede6608a7fc633ad79537310433a37a947e8237a4c127a5565