[INFO] cloning repository https://github.com/Clownvin/Flashr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Clownvin/Flashr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClownvin%2FFlashr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClownvin%2FFlashr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2242bb798acddd6ae94271fd3e5e3cf6677c08ac [INFO] checking Clownvin/Flashr/2242bb798acddd6ae94271fd3e5e3cf6677c08ac against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClownvin%2FFlashr" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Clownvin/Flashr on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Clownvin/Flashr [INFO] finished tweaking git repo https://github.com/Clownvin/Flashr [INFO] tweaked toml for git repo https://github.com/Clownvin/Flashr written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Clownvin/Flashr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 100eb22b0f0ba7602ece92110aeba94b1c45a5cea71f5fc0e9eddb8e03f13752 [INFO] running `Command { std: "docker" "start" "-a" "100eb22b0f0ba7602ece92110aeba94b1c45a5cea71f5fc0e9eddb8e03f13752", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "100eb22b0f0ba7602ece92110aeba94b1c45a5cea71f5fc0e9eddb8e03f13752", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "100eb22b0f0ba7602ece92110aeba94b1c45a5cea71f5fc0e9eddb8e03f13752", kill_on_drop: false }` [INFO] [stdout] 100eb22b0f0ba7602ece92110aeba94b1c45a5cea71f5fc0e9eddb8e03f13752 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7995b364a18f5e4828fcfaedf65e44242713cd33de50911a37ffbc893adc900 [INFO] running `Command { std: "docker" "start" "-a" "f7995b364a18f5e4828fcfaedf65e44242713cd33de50911a37ffbc893adc900", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Compiling instability v0.3.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.15 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking ratatui v0.28.0 [INFO] [stderr] Checking flashr v0.5.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/modes/type_faces.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let term = &mut term; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `problems` [INFO] [stdout] --> src/modes/type_faces.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let mut problems = TypeProblemIterator::new(args.deck_cards, stats, args.faces, rng); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_problems` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `total_correct` [INFO] [stdout] --> src/modes/type_faces.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut total_correct = 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_correct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modes/type_faces.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut problems = TypeProblemIterator::new(args.deck_cards, stats, args.faces, rng); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modes/type_faces.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut total_correct = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/modes/type_faces.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | term: &TerminalWrapper, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `problem` [INFO] [stdout] --> src/modes/type_faces.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | problem: &TypeProblem, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_problem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `progress` [INFO] [stdout] --> src/modes/type_faces.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | progress: (usize, usize), [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_progress` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `type_faces` is never used [INFO] [stdout] --> src/modes/type_faces.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn type_faces(mut term: TerminalWrapper, args: ModeArguments) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TypeProblemIterator` is never constructed [INFO] [stdout] --> src/modes/type_faces.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | struct TypeProblemIterator<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/modes/type_faces.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a> TypeProblemIterator<'a> { [INFO] [stdout] | -------------------------------- associated function in this implementation [INFO] [stdout] 49 | fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `deck`, `question`, `answer`, and `index` are never read [INFO] [stdout] --> src/modes/type_faces.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 102 | struct TypeProblem<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 103 | deck: &'a Deck, [INFO] [stdout] | ^^^^ [INFO] [stdout] 104 | question: (&'a String, &'a Face), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 105 | answer: (&'a String, &'a Face), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 106 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `show_type_problem` is never used [INFO] [stdout] --> src/modes/type_faces.rs:109:4 [INFO] [stdout] | [INFO] [stdout] 109 | fn show_type_problem( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 218 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let mut iter = iter.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | Self( [INFO] [stdout] 221 | / iter.next() [INFO] [stdout] 222 | | .and_then(|first| iter.next().map(|second| (first, second))), [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:222:35 [INFO] [stdout] | [INFO] [stdout] 222 | .and_then(|first| iter.next().map(|second| (first, second))), [INFO] [stdout] | ----- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:222:51 [INFO] [stdout] | [INFO] [stdout] 222 | .and_then(|first| iter.next().map(|second| (first, second))), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 294 | fn from(err: DeckError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Self::Deck(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deck.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 403 | let files = fs::read_dir(&path) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | / files [INFO] [stdout] 410 | | .into_iter() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stats.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(path: impl Into) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | card_stats: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 43 | let raw_mode = RawMode::enable()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let alt_screen = AltScreen::enter(raw_mode)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mouse_capture = MouseCapture::enable(alt_screen)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let terminal = Terminal::new(CrosstermBackend::new(std::io::stdout()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | Ok(TerminalWrapper { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | mouse_capture, [INFO] [stdout] 50 | | terminal, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn render_widget(&mut self, widget: impl Widget) -> Result<(), FlashrError> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | self.draw(|frame| frame.render_widget(widget, frame.area())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 66 | widget: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | self.draw(|frame| frame.render_stateful_widget(widget, frame.area(), state)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 99 | let lock = Lock::acquire(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | enable_raw_mode()?; [INFO] [stdout] 101 | Ok(RawMode(lock)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 115 | fn enter(raw_mode: RawMode) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | execute!(std::io::stdout(), EnterAlternateScreen)?; [INFO] [stdout] 117 | Ok(Self(raw_mode)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 131 | fn enable(alt_screen: AltScreen) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | execute!(std::io::stdout(), EnableMouseCapture)?; [INFO] [stdout] 133 | Ok(Self(alt_screen)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flashr` (lib) due to 13 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/modes/type_faces.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | let term = &mut term; [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `problems` [INFO] [stdout] --> src/modes/type_faces.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let mut problems = TypeProblemIterator::new(args.deck_cards, stats, args.faces, rng); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_problems` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `total_correct` [INFO] [stdout] --> src/modes/type_faces.rs:37:13 [INFO] [stdout] | [INFO] [stdout] 37 | let mut total_correct = 0; [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_total_correct` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modes/type_faces.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let mut problems = TypeProblemIterator::new(args.deck_cards, stats, args.faces, rng); [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/modes/type_faces.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | let mut total_correct = 0; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `term` [INFO] [stdout] --> src/modes/type_faces.rs:110:5 [INFO] [stdout] | [INFO] [stdout] 110 | term: &TerminalWrapper, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_term` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `problem` [INFO] [stdout] --> src/modes/type_faces.rs:111:5 [INFO] [stdout] | [INFO] [stdout] 111 | problem: &TypeProblem, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_problem` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `progress` [INFO] [stdout] --> src/modes/type_faces.rs:112:5 [INFO] [stdout] | [INFO] [stdout] 112 | progress: (usize, usize), [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_progress` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `type_faces` is never used [INFO] [stdout] --> src/modes/type_faces.rs:31:8 [INFO] [stdout] | [INFO] [stdout] 31 | pub fn type_faces(mut term: TerminalWrapper, args: ModeArguments) -> Result { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TypeProblemIterator` is never constructed [INFO] [stdout] --> src/modes/type_faces.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 42 | struct TypeProblemIterator<'a> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/modes/type_faces.rs:49:8 [INFO] [stdout] | [INFO] [stdout] 48 | impl<'a> TypeProblemIterator<'a> { [INFO] [stdout] | -------------------------------- associated function in this implementation [INFO] [stdout] 49 | fn new( [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `deck`, `question`, `answer`, and `index` are never read [INFO] [stdout] --> src/modes/type_faces.rs:103:5 [INFO] [stdout] | [INFO] [stdout] 102 | struct TypeProblem<'a> { [INFO] [stdout] | ----------- fields in this struct [INFO] [stdout] 103 | deck: &'a Deck, [INFO] [stdout] | ^^^^ [INFO] [stdout] 104 | question: (&'a String, &'a Face), [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 105 | answer: (&'a String, &'a Face), [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 106 | index: usize, [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `show_type_problem` is never used [INFO] [stdout] --> src/modes/type_faces.rs:109:4 [INFO] [stdout] | [INFO] [stdout] 109 | fn show_type_problem( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:221:13 [INFO] [stdout] | [INFO] [stdout] 218 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 219 | let mut iter = iter.into_iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 220 | Self( [INFO] [stdout] 221 | / iter.next() [INFO] [stdout] 222 | | .and_then(|first| iter.next().map(|second| (first, second))), [INFO] [stdout] | |____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:222:35 [INFO] [stdout] | [INFO] [stdout] 222 | .and_then(|first| iter.next().map(|second| (first, second))), [INFO] [stdout] | ----- ^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:222:51 [INFO] [stdout] | [INFO] [stdout] 222 | .and_then(|first| iter.next().map(|second| (first, second))), [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:295:20 [INFO] [stdout] | [INFO] [stdout] 294 | fn from(err: DeckError) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 295 | Self::Deck(Box::new(err)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/deck.rs:409:5 [INFO] [stdout] | [INFO] [stdout] 403 | let files = fs::read_dir(&path) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 409 | / files [INFO] [stdout] 410 | | .into_iter() [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stats.rs:79:25 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn new(path: impl Into) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | card_stats: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 43 | let raw_mode = RawMode::enable()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | let alt_screen = AltScreen::enter(raw_mode)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 45 | let mouse_capture = MouseCapture::enable(alt_screen)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | let terminal = Terminal::new(CrosstermBackend::new(std::io::stdout()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | [INFO] [stdout] 48 | Ok(TerminalWrapper { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | mouse_capture, [INFO] [stdout] 50 | | terminal, [INFO] [stdout] 51 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:61:19 [INFO] [stdout] | [INFO] [stdout] 60 | pub fn render_widget(&mut self, widget: impl Widget) -> Result<(), FlashrError> { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | self.draw(|frame| frame.render_widget(widget, frame.area())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:69:19 [INFO] [stdout] | [INFO] [stdout] 66 | widget: W, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | self.draw(|frame| frame.render_stateful_widget(widget, frame.area(), state)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 99 | let lock = Lock::acquire(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | enable_raw_mode()?; [INFO] [stdout] 101 | Ok(RawMode(lock)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:117:12 [INFO] [stdout] | [INFO] [stdout] 115 | fn enter(raw_mode: RawMode) -> Result { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | execute!(std::io::stdout(), EnterAlternateScreen)?; [INFO] [stdout] 117 | Ok(Self(raw_mode)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/terminal.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 131 | fn enable(alt_screen: AltScreen) -> Result { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 132 | execute!(std::io::stdout(), EnableMouseCapture)?; [INFO] [stdout] 133 | Ok(Self(alt_screen)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `flashr` (lib test) due to 13 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "f7995b364a18f5e4828fcfaedf65e44242713cd33de50911a37ffbc893adc900", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7995b364a18f5e4828fcfaedf65e44242713cd33de50911a37ffbc893adc900", kill_on_drop: false }` [INFO] [stdout] f7995b364a18f5e4828fcfaedf65e44242713cd33de50911a37ffbc893adc900