[INFO] cloning repository https://github.com/ClimacusJohannes/wcr [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ClimacusJohannes/wcr" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClimacusJohannes%2Fwcr", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClimacusJohannes%2Fwcr'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 6d23b8738df01b59edc715b8a83ebbb366d48c7e [INFO] checking ClimacusJohannes/wcr/6d23b8738df01b59edc715b8a83ebbb366d48c7e against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClimacusJohannes%2Fwcr" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ClimacusJohannes/wcr on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ClimacusJohannes/wcr [INFO] finished tweaking git repo https://github.com/ClimacusJohannes/wcr [INFO] tweaked toml for git repo https://github.com/ClimacusJohannes/wcr written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ClimacusJohannes/wcr already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6073a782ca4ff4cbd06098d1fa31e309b7b8f4df3e546b3fbb7e864c4f6ee87a [INFO] running `Command { std: "docker" "start" "-a" "6073a782ca4ff4cbd06098d1fa31e309b7b8f4df3e546b3fbb7e864c4f6ee87a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6073a782ca4ff4cbd06098d1fa31e309b7b8f4df3e546b3fbb7e864c4f6ee87a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6073a782ca4ff4cbd06098d1fa31e309b7b8f4df3e546b3fbb7e864c4f6ee87a", kill_on_drop: false }` [INFO] [stdout] 6073a782ca4ff4cbd06098d1fa31e309b7b8f4df3e546b3fbb7e864c4f6ee87a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 98b8c43d0b21f0df95f342960230127c3716bdf4a6e772d15ce0c7fd9c5fa3e5 [INFO] running `Command { std: "docker" "start" "-a" "98b8c43d0b21f0df95f342960230127c3716bdf4a6e772d15ce0c7fd9c5fa3e5", kill_on_drop: false }` [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Checking unicode-blocks v0.1.9 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking words-count v0.1.6 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking float-cmp v0.9.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking bstr v1.9.1 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking wcr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `format`, `hash::Hash`, and `write` [INFO] [stdout] --> src/lib.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{error::Error, fmt::{format, write}, fs::File, hash::Hash, io::{self, BufRead, BufReader}}; [INFO] [stdout] | ^^^^^^ ^^^^^ ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `words_count::count` [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use words_count::count; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:202:36 [INFO] [stdout] | [INFO] [stdout] 202 | ... if (filename == "-") { "".to_string() } else {filename.clone() }))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 202 - if (filename == "-") { "".to_string() } else {filename.clone() }))); [INFO] [stdout] 202 + if filename == "-" { "".to_string() } else {filename.clone() }))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `format`, `hash::Hash`, and `write` [INFO] [stdout] --> src/lib.rs:1:31 [INFO] [stdout] | [INFO] [stdout] 1 | use std::{error::Error, fmt::{format, write}, fs::File, hash::Hash, io::{self, BufRead, BufReader}}; [INFO] [stdout] | ^^^^^^ ^^^^^ ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:202:36 [INFO] [stdout] | [INFO] [stdout] 202 | ... if (filename == "-") { "".to_string() } else {filename.clone() }))); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 202 - if (filename == "-") { "".to_string() } else {filename.clone() }))); [INFO] [stdout] 202 + if filename == "-" { "".to_string() } else {filename.clone() }))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `count` [INFO] [stdout] --> src/lib.rs:236:17 [INFO] [stdout] | [INFO] [stdout] 236 | use super::{count, FileInfo}; [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `count` [INFO] [stdout] --> src/lib.rs:101:16 [INFO] [stdout] | [INFO] [stdout] 101 | Ok(count) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_count` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `byte` [INFO] [stdout] --> src/lib.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | for byte in line.to_owned().bytes() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_byte` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:173:13 [INFO] [stdout] | [INFO] [stdout] 173 | for mut s in &file { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `info` [INFO] [stdout] --> src/lib.rs:205:25 [INFO] [stdout] | [INFO] [stdout] 205 | let info = FileInfo { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_info` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `info` [INFO] [stdout] --> src/lib.rs:214:25 [INFO] [stdout] | [INFO] [stdout] 214 | let info = FileInfo { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_info` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | default_values_t = vec!["-".to_owned()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | default_values_t = vec!["-".to_owned()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:33 [INFO] [stdout] | [INFO] [stdout] 199 | .and_then(|info| Ok(run_count(info))) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `count` [INFO] [stdout] --> src/lib.rs:101:16 [INFO] [stdout] | [INFO] [stdout] 101 | Ok(count) => { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_count` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `byte` [INFO] [stdout] --> src/lib.rs:106:21 [INFO] [stdout] | [INFO] [stdout] 106 | for byte in line.to_owned().bytes() { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_byte` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wcr` (lib) due to 4 previous errors; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:173:13 [INFO] [stdout] | [INFO] [stdout] 173 | for mut s in &file { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `info` [INFO] [stdout] --> src/lib.rs:205:25 [INFO] [stdout] | [INFO] [stdout] 205 | let info = FileInfo { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_info` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `info` [INFO] [stdout] --> src/lib.rs:214:25 [INFO] [stdout] | [INFO] [stdout] 214 | let info = FileInfo { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_info` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | default_values_t = vec!["-".to_owned()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | default_values_t = vec!["-".to_owned()], [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:199:33 [INFO] [stdout] | [INFO] [stdout] 199 | .and_then(|info| Ok(run_count(info))) { [INFO] [stdout] | ---- ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 8 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `wcr` (lib test) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "98b8c43d0b21f0df95f342960230127c3716bdf4a6e772d15ce0c7fd9c5fa3e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98b8c43d0b21f0df95f342960230127c3716bdf4a6e772d15ce0c7fd9c5fa3e5", kill_on_drop: false }` [INFO] [stdout] 98b8c43d0b21f0df95f342960230127c3716bdf4a6e772d15ce0c7fd9c5fa3e5