[INFO] cloning repository https://github.com/ClementNerma/ReShell [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ClementNerma/ReShell" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClementNerma%2FReShell", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClementNerma%2FReShell'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 4ec23a3d999c160ee1a96cdf5e54851d1f3c9684 [INFO] checking ClementNerma/ReShell/4ec23a3d999c160ee1a96cdf5e54851d1f3c9684 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FClementNerma%2FReShell" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ClementNerma/ReShell on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ClementNerma/ReShell [INFO] finished tweaking git repo https://github.com/ClementNerma/ReShell [INFO] tweaked toml for git repo https://github.com/ClementNerma/ReShell written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ClementNerma/ReShell already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1c3a9dfcbafe127e164bc2a6380a1d6a9af5bd713cde6830ea74afcdcbd62065 [INFO] running `Command { std: "docker" "start" "-a" "1c3a9dfcbafe127e164bc2a6380a1d6a9af5bd713cde6830ea74afcdcbd62065", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1c3a9dfcbafe127e164bc2a6380a1d6a9af5bd713cde6830ea74afcdcbd62065", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c3a9dfcbafe127e164bc2a6380a1d6a9af5bd713cde6830ea74afcdcbd62065", kill_on_drop: false }` [INFO] [stdout] 1c3a9dfcbafe127e164bc2a6380a1d6a9af5bd713cde6830ea74afcdcbd62065 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 82be65c17541198df172e24cb0319c1c5c6a6a279fa54f333173f2363acd6267 [INFO] running `Command { std: "docker" "start" "-a" "82be65c17541198df172e24cb0319c1c5c6a6a279fa54f333173f2363acd6267", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling pomsky-syntax v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking winnow v0.6.8 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking dyn-clone v1.0.17 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling thiserror v1.0.60 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking dunce v1.0.4 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling litrs v0.2.3 [INFO] [stderr] Checking clap_builder v4.5.11 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking strum v0.26.2 [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking annotate-snippets v0.11.4 [INFO] [stderr] Compiling syn v2.0.64 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.1 [INFO] [stderr] Checking pomsky v0.11.0 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking strip-ansi-escapes v0.2.0 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling thiserror-impl v1.0.60 [INFO] [stderr] Compiling strum_macros v0.26.2 [INFO] [stderr] Compiling clap_derive v4.5.11 [INFO] [stderr] Compiling cps v0.2.3 [INFO] [stderr] Compiling perfect-derive v0.1.3 [INFO] [stderr] Checking parsy v0.7.1 [INFO] [stderr] Checking clap v4.5.11 [INFO] [stderr] Checking reshell-parser v0.1.0 (/opt/rustwide/workdir/crates/parser) [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking toml_datetime v0.6.7 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking serde_json v1.0.120 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking toml_edit v0.22.17 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking ctrlc v3.4.4 [INFO] [stderr] Checking toml v0.8.16 [INFO] [stderr] Checking terminal_size v0.3.0 [INFO] [stderr] Checking fd-lock v4.0.2 [INFO] [stderr] Checking reedline v0.32.0 (https://github.com/ClementNerma/reedline.git#7165a65d) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/files.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(file_loader: FileLoader) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self(Arc::new(RwLock::new(FilesMapInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 26 | | map: HashMap::new(), [INFO] [stdout] 27 | | counter: 0, [INFO] [stdout] 28 | | file_loader, [INFO] [stdout] 29 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 82 | let value_type = recursive::(|value_type| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let single_value_type = choice::<_, SingleValueType>(( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let mapped_single_value_type = single_value_type.spanned().map(RuntimeEaten::from); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | [INFO] [stdout] 161 | choice(( [INFO] [stdout] | ________________^ [INFO] [stdout] 162 | | // Union type [INFO] [stdout] 163 | | char('(') [INFO] [stdout] 164 | | .ignore_then( [INFO] [stdout] ... | [INFO] [stdout] 174 | | mapped_single_value_type.map(ValueType::Single), [INFO] [stdout] 175 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:235:35 [INFO] [stdout] | [INFO] [stdout] 234 | .map(|((name, is_optional), typ)| { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | FnArg::Positional(FnPositionalArg { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 236 | | name, [INFO] [stdout] 237 | | is_optional: is_optional.is_some(), [INFO] [stdout] 238 | | typ, [INFO] [stdout] 239 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:255:35 [INFO] [stdout] | [INFO] [stdout] 254 | .map(|((names, is_optional), typ)| { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | FnArg::NormalFlag(FnNormalFlagArg { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 256 | | names, [INFO] [stdout] 257 | | is_optional: is_optional.is_some(), [INFO] [stdout] 258 | | typ, [INFO] [stdout] 259 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:285:44 [INFO] [stdout] | [INFO] [stdout] 285 | .map(|(name, typ)| FnArg::Rest(FnRestArg { name, typ })), [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:438:53 [INFO] [stdout] | [INFO] [stdout] 438 | filter(|c| c.is_whitespace() || c == ',' || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:497:31 [INFO] [stdout] | [INFO] [stdout] 495 | .map(|args| FnSignature { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | args, [INFO] [stdout] 497 | ret_type: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:559:21 [INFO] [stdout] | [INFO] [stdout] 557 | .map(|members| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | Value::Struct( [INFO] [stdout] 559 | / members [INFO] [stdout] 560 | | .into_iter() [INFO] [stdout] 561 | | .map(|(name, expr)| (name.data, expr)) [INFO] [stdout] 562 | | .collect::>(), [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:616:39 [INFO] [stdout] | [INFO] [stdout] 613 | let scope_id_gen_bis = scope_id_gen.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | [INFO] [stdout] 615 | let expr_inner_content = recursive(|expr_inner_content| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 616 | choice::<_, ExprInnerContent>(( [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 617 | | // [INFO] [stdout] 618 | | // Single operator (e.g. '!') application [INFO] [stdout] 619 | | // [INFO] [stdout] ... | [INFO] [stdout] 834 | | value.clone().spanned().map(ExprInnerContent::Value), [INFO] [stdout] 835 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:906:47 [INFO] [stdout] | [INFO] [stdout] 906 | filter(|c| !c.is_whitespace() && !DELIMITER_CHARS.contains(&c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:924:51 [INFO] [stdout] | [INFO] [stdout] 924 | filter(|c| !c.is_whitespace() && !DELIMITER_CHARS.contains(&c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:958:43 [INFO] [stdout] | [INFO] [stdout] 958 | filter(|c| !c.is_whitespace() && !DELIMITER_CHARS.contains(&c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:974:49 [INFO] [stdout] | [INFO] [stdout] 974 | filter(|c| c.is_whitespace() || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1041:41 [INFO] [stdout] | [INFO] [stdout] 1041 | filter(|c| c.is_whitespace() || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1184:40 [INFO] [stdout] | [INFO] [stdout] 1160 | let single_var_decl = just("mut") [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1183 | let var_decl_type = recursive(|var_decl_type| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1184 | choice::<_, VarDeconstruction>(( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 1185 | | char('[') [INFO] [stdout] 1186 | | .ignore_then(msnl) [INFO] [stdout] 1187 | | .ignore_then( [INFO] [stdout] ... | [INFO] [stdout] 1223 | | single_var_decl.map(VarDeconstruction::Single), [INFO] [stdout] 1224 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1434:49 [INFO] [stdout] | [INFO] [stdout] 1434 | filter(|c| c.is_whitespace() || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1443:49 [INFO] [stdout] | [INFO] [stdout] 1443 | filter(|c| c.is_whitespace() || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1575:20 [INFO] [stdout] | [INFO] [stdout] 1539 | .and_then(|((name, signature), body)| { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1540 | let on_type = signature [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1575 | Ok(match on_type { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1576 | | Some(on_type) => Instruction::MethodDecl { [INFO] [stdout] 1577 | | name, [INFO] [stdout] 1578 | | on_type, [INFO] [stdout] ... | [INFO] [stdout] 1585 | | }, [INFO] [stdout] 1586 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reshell-parser` (lib test) due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/files.rs:25:14 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(file_loader: FileLoader) -> Self { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | Self(Arc::new(RwLock::new(FilesMapInner { [INFO] [stdout] | ______________^ [INFO] [stdout] 26 | | map: HashMap::new(), [INFO] [stdout] 27 | | counter: 0, [INFO] [stdout] 28 | | file_loader, [INFO] [stdout] 29 | | }))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:161:16 [INFO] [stdout] | [INFO] [stdout] 82 | let value_type = recursive::(|value_type| { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | let single_value_type = choice::<_, SingleValueType>(( [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 159 | let mapped_single_value_type = single_value_type.spanned().map(RuntimeEaten::from); [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 160 | [INFO] [stdout] 161 | choice(( [INFO] [stdout] | ________________^ [INFO] [stdout] 162 | | // Union type [INFO] [stdout] 163 | | char('(') [INFO] [stdout] 164 | | .ignore_then( [INFO] [stdout] ... | [INFO] [stdout] 174 | | mapped_single_value_type.map(ValueType::Single), [INFO] [stdout] 175 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:235:35 [INFO] [stdout] | [INFO] [stdout] 234 | .map(|((name, is_optional), typ)| { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | FnArg::Positional(FnPositionalArg { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 236 | | name, [INFO] [stdout] 237 | | is_optional: is_optional.is_some(), [INFO] [stdout] 238 | | typ, [INFO] [stdout] 239 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:255:35 [INFO] [stdout] | [INFO] [stdout] 254 | .map(|((names, is_optional), typ)| { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 255 | FnArg::NormalFlag(FnNormalFlagArg { [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 256 | | names, [INFO] [stdout] 257 | | is_optional: is_optional.is_some(), [INFO] [stdout] 258 | | typ, [INFO] [stdout] 259 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:285:44 [INFO] [stdout] | [INFO] [stdout] 285 | .map(|(name, typ)| FnArg::Rest(FnRestArg { name, typ })), [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:438:53 [INFO] [stdout] | [INFO] [stdout] 438 | filter(|c| c.is_whitespace() || c == ',' || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:497:31 [INFO] [stdout] | [INFO] [stdout] 495 | .map(|args| FnSignature { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 496 | args, [INFO] [stdout] 497 | ret_type: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:559:21 [INFO] [stdout] | [INFO] [stdout] 557 | .map(|members| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 558 | Value::Struct( [INFO] [stdout] 559 | / members [INFO] [stdout] 560 | | .into_iter() [INFO] [stdout] 561 | | .map(|(name, expr)| (name.data, expr)) [INFO] [stdout] 562 | | .collect::>(), [INFO] [stdout] | |___________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:616:39 [INFO] [stdout] | [INFO] [stdout] 613 | let scope_id_gen_bis = scope_id_gen.clone(); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 614 | [INFO] [stdout] 615 | let expr_inner_content = recursive(|expr_inner_content| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 616 | choice::<_, ExprInnerContent>(( [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 617 | | // [INFO] [stdout] 618 | | // Single operator (e.g. '!') application [INFO] [stdout] 619 | | // [INFO] [stdout] ... | [INFO] [stdout] 834 | | value.clone().spanned().map(ExprInnerContent::Value), [INFO] [stdout] 835 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:906:47 [INFO] [stdout] | [INFO] [stdout] 906 | filter(|c| !c.is_whitespace() && !DELIMITER_CHARS.contains(&c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:924:51 [INFO] [stdout] | [INFO] [stdout] 924 | filter(|c| !c.is_whitespace() && !DELIMITER_CHARS.contains(&c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:958:43 [INFO] [stdout] | [INFO] [stdout] 958 | filter(|c| !c.is_whitespace() && !DELIMITER_CHARS.contains(&c)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:974:49 [INFO] [stdout] | [INFO] [stdout] 974 | filter(|c| c.is_whitespace() || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1041:41 [INFO] [stdout] | [INFO] [stdout] 1041 | filter(|c| c.is_whitespace() || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1184:40 [INFO] [stdout] | [INFO] [stdout] 1160 | let single_var_decl = just("mut") [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1183 | let var_decl_type = recursive(|var_decl_type| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1184 | choice::<_, VarDeconstruction>(( [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 1185 | | char('[') [INFO] [stdout] 1186 | | .ignore_then(msnl) [INFO] [stdout] 1187 | | .ignore_then( [INFO] [stdout] ... | [INFO] [stdout] 1223 | | single_var_decl.map(VarDeconstruction::Single), [INFO] [stdout] 1224 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1434:49 [INFO] [stdout] | [INFO] [stdout] 1434 | filter(|c| c.is_whitespace() || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1443:49 [INFO] [stdout] | [INFO] [stdout] 1443 | filter(|c| c.is_whitespace() || DELIMITER_CHARS.contains(&c)), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> crates/parser/src/parser.rs:1575:20 [INFO] [stdout] | [INFO] [stdout] 1539 | .and_then(|((name, signature), body)| { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1540 | let on_type = signature [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1575 | Ok(match on_type { [INFO] [stdout] | ____________________^ [INFO] [stdout] 1576 | | Some(on_type) => Instruction::MethodDecl { [INFO] [stdout] 1577 | | name, [INFO] [stdout] 1578 | | on_type, [INFO] [stdout] ... | [INFO] [stdout] 1585 | | }, [INFO] [stdout] 1586 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `reshell-parser` (lib) due to 19 previous errors [INFO] running `Command { std: "docker" "inspect" "82be65c17541198df172e24cb0319c1c5c6a6a279fa54f333173f2363acd6267", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82be65c17541198df172e24cb0319c1c5c6a6a279fa54f333173f2363acd6267", kill_on_drop: false }` [INFO] [stdout] 82be65c17541198df172e24cb0319c1c5c6a6a279fa54f333173f2363acd6267