[INFO] cloning repository https://github.com/Christoph-D/gallery [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/Christoph-D/gallery" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChristoph-D%2Fgallery", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChristoph-D%2Fgallery'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e8e4fcd37cd819986ae9ea9f52ea4788c2081bd7 [INFO] checking Christoph-D/gallery/e8e4fcd37cd819986ae9ea9f52ea4788c2081bd7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChristoph-D%2Fgallery" "/workspace/builds/worker-0-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/Christoph-D/gallery on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/Christoph-D/gallery [INFO] finished tweaking git repo https://github.com/Christoph-D/gallery [INFO] tweaked toml for git repo https://github.com/Christoph-D/gallery written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/Christoph-D/gallery already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a93e8808ea9c6cab207a1aec556f0f14bcf4f0685efa3ed0334edd01e9b2b33a [INFO] running `Command { std: "docker" "start" "-a" "a93e8808ea9c6cab207a1aec556f0f14bcf4f0685efa3ed0334edd01e9b2b33a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a93e8808ea9c6cab207a1aec556f0f14bcf4f0685efa3ed0334edd01e9b2b33a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a93e8808ea9c6cab207a1aec556f0f14bcf4f0685efa3ed0334edd01e9b2b33a", kill_on_drop: false }` [INFO] [stdout] a93e8808ea9c6cab207a1aec556f0f14bcf4f0685efa3ed0334edd01e9b2b33a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 495a6f855d8571605e24e34b6cf1cff360f04f0173cdbddbb79c598bd9e5c51d [INFO] running `Command { std: "docker" "start" "-a" "495a6f855d8571605e24e34b6cf1cff360f04f0173cdbddbb79c598bd9e5c51d", kill_on_drop: false }` [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling serde v1.0.208 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling pulldown-cmark v0.12.0 [INFO] [stderr] Compiling serde_derive v1.0.208 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling pest v2.7.10 [INFO] [stderr] Checking deunicode v1.6.0 [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking slug v0.1.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking handlebars v6.0.0 [INFO] [stderr] Checking gallery v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 71 | fn run_on_args(args: impl Iterator) -> Result<()> { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | output::write_files(&gallery, &args.output_config()).with_context(|| "Failed to write gallery") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | fs::create_dir_all(dir).path_context("Failed to create directory", dir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 22 | let mut handlebars = Handlebars::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Templates(handlebars)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | Ok(Box::new(HTMLFile { [INFO] [stdout] | ________^ [INFO] [stdout] 47 | | content: templates [INFO] [stdout] 48 | | .0 [INFO] [stdout] 49 | | .render("overview", &data) [INFO] [stdout] 50 | | .with_context(|| "Failed to render overview HTML page")?, [INFO] [stdout] 51 | | output_path: config.output_path.join("index.html"), [INFO] [stdout] 52 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | Ok(Some(Box::new(HTMLFile { [INFO] [stdout] | ________^ [INFO] [stdout] 85 | | content: templates.0.render("image_group", &data).with_context(|| { [INFO] [stdout] 86 | | format!( [INFO] [stdout] 87 | | "Failed to render HTML page for image group \"{}\"", [INFO] [stdout] ... | [INFO] [stdout] 91 | | output_path: config.output_path.join(image_group.url()?), [INFO] [stdout] 92 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html/markdown.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 115 | item: Event<'a>, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Event::Html(image_markdown_snippet(img).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gallery` (bin "gallery") due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 71 | fn run_on_args(args: impl Iterator) -> Result<()> { [INFO] [stdout] | ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | output::write_files(&gallery, &args.output_config()).with_context(|| "Failed to write gallery") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output.rs:108:5 [INFO] [stdout] | [INFO] [stdout] 108 | fs::create_dir_all(dir).path_context("Failed to create directory", dir) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html.rs:32:8 [INFO] [stdout] | [INFO] [stdout] 22 | let mut handlebars = Handlebars::new(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | Ok(Templates(handlebars)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html.rs:46:8 [INFO] [stdout] | [INFO] [stdout] 46 | Ok(Box::new(HTMLFile { [INFO] [stdout] | ________^ [INFO] [stdout] 47 | | content: templates [INFO] [stdout] 48 | | .0 [INFO] [stdout] 49 | | .render("overview", &data) [INFO] [stdout] 50 | | .with_context(|| "Failed to render overview HTML page")?, [INFO] [stdout] 51 | | output_path: config.output_path.join("index.html"), [INFO] [stdout] 52 | | })) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 84 | Ok(Some(Box::new(HTMLFile { [INFO] [stdout] | ________^ [INFO] [stdout] 85 | | content: templates.0.render("image_group", &data).with_context(|| { [INFO] [stdout] 86 | | format!( [INFO] [stdout] 87 | | "Failed to render HTML page for image group \"{}\"", [INFO] [stdout] ... | [INFO] [stdout] 91 | | output_path: config.output_path.join(image_group.url()?), [INFO] [stdout] 92 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/output/html/markdown.rs:133:17 [INFO] [stdout] | [INFO] [stdout] 115 | item: Event<'a>, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Event::Html(image_markdown_snippet(img).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `gallery` (bin "gallery" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "495a6f855d8571605e24e34b6cf1cff360f04f0173cdbddbb79c598bd9e5c51d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "495a6f855d8571605e24e34b6cf1cff360f04f0173cdbddbb79c598bd9e5c51d", kill_on_drop: false }` [INFO] [stdout] 495a6f855d8571605e24e34b6cf1cff360f04f0173cdbddbb79c598bd9e5c51d