[INFO] cloning repository https://github.com/ChrisPWill/login_api [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ChrisPWill/login_api" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChrisPWill%2Flogin_api", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChrisPWill%2Flogin_api'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0a54ecc5a44d6b1fb049551c35f992e71c648460 [INFO] checking ChrisPWill/login_api/0a54ecc5a44d6b1fb049551c35f992e71c648460 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChrisPWill%2Flogin_api" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ChrisPWill/login_api on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ChrisPWill/login_api [INFO] finished tweaking git repo https://github.com/ChrisPWill/login_api [INFO] tweaked toml for git repo https://github.com/ChrisPWill/login_api written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ChrisPWill/login_api already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ffac2613794a56d4e5ddf97b4094708c5d898e30df0cc35d4ecb35caac1b634f [INFO] running `Command { std: "docker" "start" "-a" "ffac2613794a56d4e5ddf97b4094708c5d898e30df0cc35d4ecb35caac1b634f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ffac2613794a56d4e5ddf97b4094708c5d898e30df0cc35d4ecb35caac1b634f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ffac2613794a56d4e5ddf97b4094708c5d898e30df0cc35d4ecb35caac1b634f", kill_on_drop: false }` [INFO] [stdout] ffac2613794a56d4e5ddf97b4094708c5d898e30df0cc35d4ecb35caac1b634f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 65fde5c4f69dde730801eeb67dad806a1215feab65f7bfca6650b34b6aa445d8 [INFO] running `Command { std: "docker" "start" "-a" "65fde5c4f69dde730801eeb67dad806a1215feab65f7bfca6650b34b6aa445d8", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.61 [INFO] [stderr] Compiling autocfg v0.1.5 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Compiling rand_core v0.4.2 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling cc v1.0.40 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling serde v1.0.98 [INFO] [stderr] Compiling rand_core v0.3.1 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Compiling typenum v1.10.0 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling ryu v1.0.0 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling rand_hc v0.1.0 [INFO] [stderr] Compiling rand_xorshift v0.1.1 [INFO] [stderr] Compiling rand_isaac v0.1.1 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling rand_jitter v0.1.4 [INFO] [stderr] Compiling siphasher v0.2.3 [INFO] [stderr] Compiling rand_os v0.1.3 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling phf_shared v0.7.24 [INFO] [stderr] Checking smallvec v0.6.10 [INFO] [stderr] Checking generic-array v0.12.3 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Compiling backtrace-sys v0.1.31 [INFO] [stderr] Checking unicode-normalization v0.1.8 [INFO] [stderr] Checking time v0.1.42 [INFO] [stderr] Checking getrandom v0.1.8 [INFO] [stderr] Compiling matches v0.1.8 [INFO] [stderr] Checking ppv-lite86 v0.2.5 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking rand_core v0.5.0 [INFO] [stderr] Compiling phf_generator v0.7.24 [INFO] [stderr] Compiling phf_codegen v0.7.24 [INFO] [stderr] Checking c2-chacha v0.2.2 [INFO] [stderr] Compiling mime_guess v1.8.7 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling brotli-sys v0.3.2 [INFO] [stderr] Checking idna v0.1.5 [INFO] [stderr] Compiling failure_derive v0.1.5 [INFO] [stderr] Checking opaque-debug v0.2.3 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking byte-tools v0.3.1 [INFO] [stderr] Compiling httparse v1.3.4 [INFO] [stderr] Checking percent-encoding v1.0.1 [INFO] [stderr] Checking safemem v0.3.1 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Checking block-padding v0.1.4 [INFO] [stderr] Checking url v1.7.2 [INFO] [stderr] Compiling aho-corasick v0.7.6 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking rand_chacha v0.2.1 [INFO] [stderr] Checking phf v0.7.24 [INFO] [stderr] Checking digest v0.8.1 [INFO] [stderr] Checking block-cipher-trait v0.6.2 [INFO] [stderr] Compiling ring v0.14.6 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking chrono v0.4.7 [INFO] [stderr] Checking serde_json v1.0.40 [INFO] [stderr] Checking regex-syntax v0.6.11 [INFO] [stderr] Compiling pq-sys v0.4.6 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Checking remove_dir_all v0.5.2 [INFO] [stderr] Checking subtle v1.0.0 [INFO] [stderr] Checking rustc-demangle v0.1.15 [INFO] [stderr] Checking backtrace v0.3.34 [INFO] [stderr] Checking crypto-mac v0.7.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Compiling synstructure v0.10.2 [INFO] [stderr] Checking blowfish v0.4.0 [INFO] [stderr] Checking gzip-header v0.3.0 [INFO] [stderr] Checking rand v0.7.0 [INFO] [stderr] Checking regex v1.2.1 [INFO] [stderr] Checking block-buffer v0.7.3 [INFO] [stderr] Checking buf_redux v0.8.4 [INFO] [stderr] Checking twoway v0.1.8 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Checking spin v0.5.1 [INFO] [stderr] Checking fake-simd v0.1.2 [INFO] [stderr] Checking untrusted v0.6.2 [INFO] [stderr] Checking ascii v0.8.7 [INFO] [stderr] Checking chunked_transfer v0.3.1 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Checking tiny_http v0.6.2 [INFO] [stderr] Checking multipart v0.15.4 [INFO] [stderr] Compiling serde_derive v1.0.98 [INFO] [stderr] Compiling diesel_derives v1.4.0 [INFO] [stderr] Checking failure v0.1.5 [INFO] [stderr] Checking sha2 v0.8.0 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking threadpool v1.7.1 [INFO] [stderr] Checking bcrypt v0.5.0 [INFO] [stderr] Checking rand v0.5.6 [INFO] [stderr] Checking hmac v0.7.1 [INFO] [stderr] Checking base64 v0.9.3 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking filetime v0.2.6 [INFO] [stderr] Checking sha1 v0.6.0 [INFO] [stderr] Compiling if_chain v1.0.0 [INFO] [stderr] Checking easy_password v0.1.2 [INFO] [stderr] Checking dotenv v0.14.1 [INFO] [stderr] Checking diesel v1.4.2 [INFO] [stderr] Compiling validator v0.9.0 [INFO] [stderr] Checking rouille v3.0.0 [INFO] [stderr] Checking jsonwebtoken v6.0.1 [INFO] [stderr] Compiling validator_derive v0.9.0 [INFO] [stderr] Checking login_api v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `connection` [INFO] [stdout] --> src/v1/user.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | connection: &DalConnection, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_connection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `user_id` [INFO] [stdout] --> src/v1/user.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | user_id: i64, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_user_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 38 | let connection = DalConnection::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | / connection [INFO] [stdout] 43 | | .pg_connection [INFO] [stdout] 44 | | .transaction::(|| { [INFO] [stdout] 45 | | Ok(routes(request, &connection)) [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v1/models/user.rs:18:10 [INFO] [stdout] | [INFO] [stdout] 18 | #[derive(Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v1/token.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 35 | let mut response = Response::json(&SingleErrorResponse { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | match handlers::user::create_token( [INFO] [stdout] | ___________^ [INFO] [stdout] 54 | | connection, [INFO] [stdout] 55 | | &body.email, [INFO] [stdout] 56 | | &body.password, [INFO] [stdout] 57 | | &request.remote_addr().ip().to_string(), [INFO] [stdout] 58 | | request.header("User-Agent").unwrap(), [INFO] [stdout] 59 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v1/token.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 84 | let mut response = Response::json(&SingleErrorResponse { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match handlers::user::verify_token(connection, &body.token) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `login_api` (bin "login_api" test) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `connection` [INFO] [stdout] --> src/v1/user.rs:74:5 [INFO] [stdout] | [INFO] [stdout] 74 | connection: &DalConnection, [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_connection` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `user_id` [INFO] [stdout] --> src/v1/user.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | user_id: i64, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_user_id` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 38 | let connection = DalConnection::new( [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | / connection [INFO] [stdout] 43 | | .pg_connection [INFO] [stdout] 44 | | .transaction::(|| { [INFO] [stdout] 45 | | Ok(routes(request, &connection)) [INFO] [stdout] 46 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v1/models/user.rs:18:10 [INFO] [stdout] | [INFO] [stdout] 18 | #[derive(Deserialize)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v1/token.rs:53:11 [INFO] [stdout] | [INFO] [stdout] 35 | let mut response = Response::json(&SingleErrorResponse { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | match handlers::user::create_token( [INFO] [stdout] | ___________^ [INFO] [stdout] 54 | | connection, [INFO] [stdout] 55 | | &body.email, [INFO] [stdout] 56 | | &body.password, [INFO] [stdout] 57 | | &request.remote_addr().ip().to_string(), [INFO] [stdout] 58 | | request.header("User-Agent").unwrap(), [INFO] [stdout] 59 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/v1/token.rs:93:11 [INFO] [stdout] | [INFO] [stdout] 84 | let mut response = Response::json(&SingleErrorResponse { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | match handlers::user::verify_token(connection, &body.token) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `login_api` (bin "login_api") due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "65fde5c4f69dde730801eeb67dad806a1215feab65f7bfca6650b34b6aa445d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "65fde5c4f69dde730801eeb67dad806a1215feab65f7bfca6650b34b6aa445d8", kill_on_drop: false }` [INFO] [stdout] 65fde5c4f69dde730801eeb67dad806a1215feab65f7bfca6650b34b6aa445d8