[INFO] cloning repository https://github.com/ChidiRnweke/squishlink_rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ChidiRnweke/squishlink_rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChidiRnweke%2Fsquishlink_rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChidiRnweke%2Fsquishlink_rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ab92ce0431bac7c5522056969de9e1985eedb81d [INFO] checking ChidiRnweke/squishlink_rs/ab92ce0431bac7c5522056969de9e1985eedb81d against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FChidiRnweke%2Fsquishlink_rs" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] validating manifest of git repo https://github.com/ChidiRnweke/squishlink_rs on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking git repo https://github.com/ChidiRnweke/squishlink_rs [INFO] finished tweaking git repo https://github.com/ChidiRnweke/squishlink_rs [INFO] tweaked toml for git repo https://github.com/ChidiRnweke/squishlink_rs written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate git repo https://github.com/ChidiRnweke/squishlink_rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c0c65d217db1a4cf54c94bdfad22b852078a451bbbcefd1726470ad3f4d55332 [INFO] running `Command { std: "docker" "start" "-a" "c0c65d217db1a4cf54c94bdfad22b852078a451bbbcefd1726470ad3f4d55332", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c0c65d217db1a4cf54c94bdfad22b852078a451bbbcefd1726470ad3f4d55332", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c0c65d217db1a4cf54c94bdfad22b852078a451bbbcefd1726470ad3f4d55332", kill_on_drop: false }` [INFO] [stdout] c0c65d217db1a4cf54c94bdfad22b852078a451bbbcefd1726470ad3f4d55332 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5b7f2d206b592a317a8b8c54d32a72d9eb54898d176952f6e87644fd3ba72dee [INFO] running `Command { std: "docker" "start" "-a" "5b7f2d206b592a317a8b8c54d32a72d9eb54898d176952f6e87644fd3ba72dee", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling serde v1.0.201 [INFO] [stderr] Compiling rustversion v1.0.16 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling pq-sys v0.4.8 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling syn v2.0.61 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Compiling axum-core v0.4.3 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling axum v0.7.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking dotenvy v0.15.7 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking simplelog v0.12.2 [INFO] [stderr] Compiling diesel_table_macro_syntax v0.1.0 [INFO] [stderr] Compiling serde_derive v1.0.201 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling async-trait v0.1.80 [INFO] [stderr] Compiling diesel_derives v2.1.4 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking diesel v2.1.6 [INFO] [stderr] Checking serde_spanned v0.6.5 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking serde_path_to_error v0.1.16 [INFO] [stderr] Checking toml_edit v0.19.15 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking hyper-util v0.1.3 [INFO] [stderr] Checking toml v0.7.8 [INFO] [stderr] Checking migrations_internals v2.1.0 [INFO] [stderr] Compiling migrations_macros v2.1.0 [INFO] [stderr] Checking diesel_migrations v2.1.0 [INFO] [stderr] Checking squishlink_rs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `id`, `short_link`, and `created_at` are never read [INFO] [stdout] --> src/generator/database.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Link { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 19 | pub id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 20 | pub original_link: String, [INFO] [stdout] 21 | pub short_link: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 22 | pub created_at: SystemTime, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:57:75 [INFO] [stdout] | [INFO] [stdout] 53 | let app_state = Arc::new(AppState::new(config, name_generator)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let cleanup = async move { spawn_cleanup_task(Arc::clone(&app_state)).await }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generator/database.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / result [INFO] [stdout] 57 | | .ok_or(AppError::NotFoundError) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generator/database.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 80 | let connection = establish_connection(db_config)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Ok(Self::from_connection(connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn make_router(app_state: Arc) -> Router { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let state = Arc::clone(&app_state); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | / Router::new() [INFO] [stdout] 24 | | .route("/s", post(shorten)) [INFO] [stdout] 25 | | .route("/s/:short_link", get(retrieve_original_link)) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `short_link`, and `created_at` are never read [INFO] [stdout] --> src/generator/database.rs:19:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Link { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 19 | pub id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 20 | pub original_link: String, [INFO] [stdout] 21 | pub short_link: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 22 | pub created_at: SystemTime, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:57:75 [INFO] [stdout] | [INFO] [stdout] 53 | let app_state = Arc::new(AppState::new(config, name_generator)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | let cleanup = async move { spawn_cleanup_task(Arc::clone(&app_state)).await }; [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `squishlink_rs` (bin "squishlink_rs" test) due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generator/database.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | / result [INFO] [stdout] 57 | | .ok_or(AppError::NotFoundError) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/generator/database.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 80 | let connection = establish_connection(db_config)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | Ok(Self::from_connection(connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/routes.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn make_router(app_state: Arc) -> Router { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 22 | let state = Arc::clone(&app_state); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | / Router::new() [INFO] [stdout] 24 | | .route("/s", post(shorten)) [INFO] [stdout] 25 | | .route("/s/:short_link", get(retrieve_original_link)) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `squishlink_rs` (bin "squishlink_rs") due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "5b7f2d206b592a317a8b8c54d32a72d9eb54898d176952f6e87644fd3ba72dee", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5b7f2d206b592a317a8b8c54d32a72d9eb54898d176952f6e87644fd3ba72dee", kill_on_drop: false }` [INFO] [stdout] 5b7f2d206b592a317a8b8c54d32a72d9eb54898d176952f6e87644fd3ba72dee